Re: [Wireshark-dev] [Wireshark-commits] rev 30910: /trunk/gtk/ /trunk/gtk/: new_packet_list.c

2009-11-10 Thread Stig Bjørlykke
this check valid again? Does this patch work? -- Stig Bjørlykke invalidate_current_row.patch Description: Binary data ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org

Re: [Wireshark-dev] [Wireshark-commits] rev 30929: /trunk/gtk/ /trunk/gtk/: capture_if_dlg.c

2009-11-11 Thread Stig Bjørlykke
get two usbmon interfaces. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options

Re: [Wireshark-dev] What's wrong with 1.3?

2009-11-12 Thread Stig Bjørlykke
On 12. nov. 2009, at 22.58, David Aggeler wrote: I'm facing things I can't really explain and it is driving me nuts. Try make clean, that usually works for me. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing

Re: [Wireshark-dev] Modify preferences from popup menu

2009-11-17 Thread Stig Bjørlykke
wireshark does not work for the new packet list yet, so you have to use the old packet list or implement support for adding columns to the new packet list. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark

Re: [Wireshark-dev] review_to_checkin: Bug 3540: incorrect timestamps in netscaler capture file format?

2009-11-17 Thread Stig Bjørlykke
On 17. nov. 2009, at 19.12, Ravi Kondamuru wrote: Can you review and commit the patch submitted for this bug. Sure, Committed revision 30994. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev

Re: [Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-ppc

2009-11-18 Thread Stig Bjørlykke
? It looks like a timeout creating libwireshark. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] Lua syntax question

2009-11-19 Thread Stig Bjørlykke
On 19. nov. 2009, at 23.00, Beth wrote: Can someone tell me the correct syntax? newtvb = tvbuffer(50):tvb() next_dissector:call( newtvb, pinfo, treeitem ) -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing

Re: [Wireshark-dev] [Wireshark-commits] rev 28928: /trunk/gtk/ /trunk/gtk/: new_packet_list.c

2009-11-27 Thread Stig Bjørlykke
moving a column we get out of sync with the column_info data, so when auto-resizing or creating a filter from the packet list we get wrong data. Is anyone looking at this issue? -- Stig Bjørlykke ___ Sent via:Wireshark-dev

Re: [Wireshark-dev] Problem building Wireshark on redhat 4.6

2009-11-30 Thread Stig Bjørlykke
On Mon, Nov 30, 2009 at 12:51 PM, Varun Gupta varun.gu...@aricent.com wrote: If anybody has any idea on how to solve this issue please help me. You have to install the development packages. -- Stig Bjørlykke ___ Sent via

Re: [Wireshark-dev] [Wireshark-commits] rev 31343: /trunk/gtk/ /trunk/gtk/: main_packet_list.c main_packet_list.h menus.c new_packet_list.c new_packet_list.h

2009-12-22 Thread Stig Bjørlykke
On 22. des. 2009, at 00.07, s...@wireshark.org wrote: Add Ignore all packets, just like Mark all packets Should we rename the menu items to Mark all displayed packets and Ignore all displayed packets? This would clearify the usage. -- Stig Bjørlykke

Re: [Wireshark-dev] Wireshark 1.2.5 is now available

2010-01-05 Thread Stig Bjørlykke
No patch-wireshark-1.2.4-to-1.2.5.diff? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org

[Wireshark-dev] Compile with PIE

2010-01-05 Thread Stig Bjørlykke
Hi, Can we build Wireshark and friends as Position-independent executables (PIE)? The attached patch seems to do this. Any objections against this patch? -- Stig Bjørlykke configure-pie.patch Description: Binary data

Re: [Wireshark-dev] small patch for smtps on port 465

2010-01-10 Thread Stig Bjørlykke
On 9. jan. 2010, at 16.46, rmkml wrote: ok I have created a small patch for packet-smtp.c dissector, redirect to ssl dissector for smtps (on port 465). Committed revision 31482. -- Stig Bjørlykke ___ Sent via

Re: [Wireshark-dev] [Wireshark-commits] rev 31644: /trunk/gtk/ /trunk/gtk/: prefs_column.c

2010-01-24 Thread Stig Bjørlykke
, both from the Preferences - Columns and the packet list column header context menu, the title is not escaped. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http

Re: [Wireshark-dev] [Wireshark-commits] rev 31649: /trunk/ /trunk/epan/: column.c column.h /trunk/gtk/: new_packet_list.c prefs_column.c

2010-01-25 Thread Stig Bjørlykke
On Sun, Jan 24, 2010 at 11:25 PM, di...@wireshark.org wrote: Log:  Handle underscore escaping/unescaping of the column titles  under the new packet list Now we only get double underscore in the preferences file, in column.format. -- Stig Bjørlykke

Re: [Wireshark-dev] filtering not working

2010-01-26 Thread Stig Bjørlykke
. Try this: proto_tree_add_item(helen_sub_tree, hf_helen_flowname, tvb, offset, 8, FALSE); -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org

Re: [Wireshark-dev] filtering not working

2010-01-26 Thread Stig Bjørlykke
, offset, 4, seq, Sequence #: %d, seq); but using proto_tree_add_item() is the preferred method. The _format functions are for special needs. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark

Re: [Wireshark-dev] ipv6 address help

2010-01-26 Thread Stig Bjørlykke
, helen.ipv6, FT_IPv6, BASE_NONE, NULL, 0x0, Helen IPv6 Address, HFILL }}, proto_tree_add_item(helen_sub_tree, hf_helen_ipv6, tvb, offset, 16, FALSE); -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] [Wireshark-commits] rev 31685: /trunk/ /trunk/epan/dissectors/: packet-ansi_801.c /trunk/epan/: column.c column.h prefs.c strutil.c strutil.h /trunk/gtk/: main_packet_list.c new_pa

2010-01-26 Thread Stig Bjørlykke
and we can't have to escape/unescape every time we modify our internal values. Have a look at the output from our File-Export functions. I have committed revision 31689, which fixes this. Now we may move the ws_strdup_escape/unescape_underscore() functions to gtk/new_packet_list.c? -- Stig

Re: [Wireshark-dev] [Wireshark-commits] rev 31774: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-clnp.c packet-p_mul.c packet-tcp.c packet-x25.c

2010-02-03 Thread Stig Bjørlykke
for the length. I'll change to reassembled.length. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] Save extracted data from reassembled packets

2010-02-22 Thread Stig Bjørlykke
suppose in this situation the FT_PROTOCOL should be handled as a byte array, and maybe this is the best handling. I have just committed revision 31951 with a fix for this, please try a automated build[1] in an hour or so. [1] http://www.wireshark.org/download/automated/ -- Stig Bjørlykke

Re: [Wireshark-dev] Lua script: get to HTTP GET / POST body [sort-of-SOLVED]

2010-02-25 Thread Stig Bjørlykke
-- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 32119: /trunk/ /trunk/cmake/modules/: FindGTK2.cmake /trunk/: CMakeLists.txt

2010-03-05 Thread Stig Bjørlykke
On Fri, Mar 5, 2010 at 12:35 AM, jma...@wireshark.org wrote: Log:  Copy over the introduction of Makefile.common change  Replace FindGTK2 by version included in cmake 2.8.x I get this when compiling on OS X with latest port updates. -- Disabled features: GTK2 YAPP -- Stig Bjørlykke

Re: [Wireshark-dev] FindGTK2.cmake /trunk/: CMakeLists.txt

2010-03-06 Thread Stig Bjørlykke
On 6. mars 2010, at 18.28, Joerg Mayer wrote: Can you please try to find out a few more details as to what goes wrong? Missing search in /opt/local for includes and libs. Fixed in revision 32129. -- Stig Bjørlykke

Re: [Wireshark-dev] FindGTK2.cmake /trunk/: CMakeLists.txt

2010-03-07 Thread Stig Bjørlykke
On 7. mars 2010, at 20.42, Kovarththanan Rajaratnam wrote: Is this something we should push upstream? I suppose we should. I also have to enable the check for GDKPIXBUF to make it link. Is this only needed on OS X? -- Stig Bjørlykke

Re: [Wireshark-dev] FindGTK2.cmake /trunk/: CMakeLists.txt

2010-03-07 Thread Stig Bjørlykke
(GTK2_GDKPIXBUF_LIBRARY gdk_pixbuf false true) elseif(_GTK2_component STREQUAL gtkmm) -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists

Re: [Wireshark-dev] Compilation errors in wiretap/ (without zlib)

2010-04-17 Thread Stig Bjørlykke
2010/4/12 Jakub Zawadzki darkja...@darkjames.ath.cx: Attaching patch for vms and packetlogger. Committed revision 32501. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives

Re: [Wireshark-dev] [Wireshark-commits] rev 32522: /trunk/gtk/ /trunk/gtk/: main_proto_draw.c

2010-04-20 Thread Stig Bjørlykke
On Tue, Apr 20, 2010 at 9:47 AM, etx...@wireshark.org wrote:  From Jakub Zawadzki:  Improve bitview display This patch introduces the bugs listed in comment 1 in the bug report. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413#c1 -- Stig Bjørlykke

Re: [Wireshark-dev] manual address resolution (Was: [Wireshark-commits] rev 32571: /trunk/ /trunk/epan/: addr_resolv.c addr_resolv.h /trunk/gtk/: CMakeLists.txt Makefile.common help_dlg.c help_dlg.h m

2010-04-29 Thread Stig Bjørlykke
? I'm sure it's possible, I'll have a look. And maybe from the main menu, View - Name Resolution - Manually Resolve Address. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives

Re: [Wireshark-dev] [Wireshark-commits] rev 32633: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ip.c

2010-05-02 Thread Stig Bjørlykke
On Sun, May 2, 2010 at 5:36 PM, etx...@wireshark.org wrote:  From Jakub Zawadzki:  patch for ip.flags (using proto_tree_add_bits_item).  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413 Where did the tree entry Flags go? It used to be above Fragment offset. -- Stig Bjørlykke

Re: [Wireshark-dev] Wireshark 1.4

2010-05-12 Thread Stig Bjørlykke
internal structures. Try moving a column and apply/prepare a filter from an entry in the moved column. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http

Re: [Wireshark-dev] [Wireshark-commits] rev 32804: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2010-05-14 Thread Stig Bjørlykke
- Interfaces)? This is used in a profile where I always want to capture in monitor mode. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists

Re: [Wireshark-dev] [Wireshark-commits] rev 32804: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2010-05-14 Thread Stig Bjørlykke
preferences. Great! I'm just curious because I use this features daily. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev

Re: [Wireshark-dev] Wireshark 1.4 Cmake status

2010-05-17 Thread Stig Bjørlykke
AUTHORS-SHORT-FORMAT, wireshark.pod /bin/sh: AUTHORS-SHORT: No such file or directory make[2]: *** [AUTHORS-SHORT-FORMAT] Error 1 make[1]: *** [CMakeFiles/auxiliary.dir/all] Error 2 make: *** [all] Error 2 -- Stig Bjørlykke

Re: [Wireshark-dev] MacOSX snow leo integration

2010-05-22 Thread Stig Bjørlykke
ports? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 32969: /trunk/ /trunk/: capture_sync.c

2010-05-26 Thread Stig Bjørlykke
On Wed, May 26, 2010 at 7:33 AM, g...@wireshark.org wrote: Log:  Don't report EINTR - it might be from a ^C.  Do report the error string for other read errors, though. I'm getting this error every time I stop capture: Error reading from sync pipe: Unknown error: 0 -- Stig Bjørlykke

[Wireshark-dev] Capture with pcap-ng crashes

2010-05-26 Thread Stig Bjørlykke
Is anyone capturing with pcap-ng? I'm getting a crash in the packet list, and I think this stopped working a few weeks ago. Observed on OSX 10.6, it seems to work on Ubuntu 10.04. -- Stig Bjørlykke ___ Sent via

Re: [Wireshark-dev] [Wireshark-commits] rev 33168: /trunk/gtk/ /trunk/gtk/: filter_autocomplete.c

2010-06-08 Thread Stig Bjørlykke
On Tue, Jun 8, 2010 at 11:45 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: Does this fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4306 Yes, I suppose it will. At least I'm running on a x86_64 kernel, and I have never seen this crash before. -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 33300: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ber.c

2010-06-23 Thread Stig Bjørlykke
, and two keys defined, name and syntax. What about using a UAT for entering this values? Then we can have a drop-down with valid syntax values, and we have more control over the input. -- Stig Bjørlykke ___ Sent via

Re: [Wireshark-dev] [Wireshark-commits] rev 33175: /trunk/tools/ /trunk/tools/: asn2wrs.py

2010-06-24 Thread Stig Bjørlykke
others) from X.411. I tried adding -R in x411, but got all PDUs exported, which is not what I really want... -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http

Re: [Wireshark-dev] Resolved/Unresolved column (Was: [Wireshark-users] Adding DSCP column in Wireshark 1.4.0rc1)

2010-06-25 Thread Stig Bjørlykke
. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] val_to_str()

2010-06-28 Thread Stig Bjørlykke
On Mon, Jun 28, 2010 at 3:15 PM, Vishal Kumar Singh vishal.is...@gmail.com wrote: Please tell me, how to resolve the Unknown Type from val_to_str() of dissector code. You have to add a description for your type in the table used in the second argument to val_to_str(). -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 33351: /trunk/ /trunk/epan/dissectors/: Makefile.common packet-gtpv2.c packet-ranap.c packet-ranap.h packet-s1ap.c /trunk/asn1/ranap/: ranap.cnf /trunk/asn1

2010-06-28 Thread Stig Bjørlykke
On Mon, Jun 28, 2010 at 6:35 PM, Guy Harris g...@alum.mit.edu wrote: It now needs a packet-s1ap-template.h in asn1/s1ap, in order to generate packet-s1ap.h, and then it needs packet-s1ap.h in epan/dissectors as well. I've fixed this. -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 33048: /trunk/ /trunk/epan/dissectors/: packet-ber.c packet-pres.c /trunk/asn1/pres/: pres.cnf

2010-06-29 Thread Stig Bjørlykke
is marked as [Unreassembled Packet], while it used to display fine with a single-ASN1-type in PRES. Graeme: are you able to look at this? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org

Re: [Wireshark-dev] [Wireshark-commits] rev 33048: /trunk/ /trunk/epan/dissectors/: packet-ber.c packet-pres.c /trunk/asn1/pres/: pres.cnf

2010-06-29 Thread Stig Bjørlykke
2010/6/29 Stig Bjørlykke s...@bjorlykke.org: I'm also having problem with this patch.  Have a look at this packet which is marked as [Unreassembled Packet], while it used to display fine with a single-ASN1-type in PRES. Ok, and now with the example packet. -- Stig Bjørlykke pres.pcap

Re: [Wireshark-dev] [Wireshark-commits] rev 33048: /trunk/ /trunk/epan/dissectors/: packet-ber.c packet-pres.c /trunk/asn1/pres/: pres.cnf

2010-06-29 Thread Stig Bjørlykke
On Tue, Jun 29, 2010 at 4:11 PM, Graeme Lunt gra...@lunt.uk.com wrote: However, I believe this is because ISO8823-PRESENTATION.asn should say: CHOICE {single-ASN1-type   [0] ANY, This much better aligns with the original ASN.1. Ah, yes this sounds reasonable. Just check it in. -- Stig

Re: [Wireshark-dev] Wireshark SSTP Dissector

2010-06-30 Thread Stig Bjørlykke
/SendingFilesToWireshark -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options

Re: [Wireshark-dev] [Wireshark-commits] rev 33270: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ip.c

2010-07-05 Thread Stig Bjørlykke
. Should we change back to using the COL_DSCP_VALUE as a special column? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev

Re: [Wireshark-dev] MacOS/X builds

2010-07-06 Thread Stig Bjørlykke
On Tue, Jul 6, 2010 at 12:01 PM, Sake Blok s...@euronet.nl wrote: I'm starting to build Wireshark on my MacBook. It all compiles well, but when I do 'make osx-install' the created Wireshark.app does not execute. I'm using the attached patch to build on my system (OSX 10.6.4). -- Stig

Re: [Wireshark-dev] [Wireshark-commits] rev 30979: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-tcp.c

2010-07-15 Thread Stig Bjørlykke
-- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] Correct way of adding a HTTP subdissector on port 80 with no content type?

2010-07-19 Thread Stig Bjørlykke
On Mon, Jul 19, 2010 at 4:39 PM, Tarjei Knapstad tarjei.knaps...@gmail.com wrote: However, my dissector (or heurisic dissector) never gets called in any of these cases. What happens if you disable the http dissector? Or remove port 80 from the http preferences? -- Stig Bjørlykke

Re: [Wireshark-dev] where is the best place to do the calculation

2010-07-21 Thread Stig Bjørlykke
latitude = tvb_get_ntohl (tvb, offset) / 100 - 90.0; proto_tree_add_double(olsr_sub_tree, hf_olsr_latitude, tvb, offset, 4, latitude); -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev

Re: [Wireshark-dev] 6lowpan dissector fails RFC 4944 compliance: field hop limit

2010-07-22 Thread Stig Bjørlykke
easily see what's wrong. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options

Re: [Wireshark-dev] Wireshark support for 802.15.4 non-FCS packets

2010-08-07 Thread Stig Bjørlykke
On Sat, Aug 7, 2010 at 12:08 AM, Jon Smirl jonsm...@gmail.com wrote: Now that we have the new DLT for 802.15.4 it needs to be enabled in Wireshark. Committed revision 33728. -- Stig Bjørlykke ___ Sent via:Wireshark

Re: [Wireshark-dev] [Wireshark-commits] rev 33729: /trunk/ /trunk/epan/: prefs.c /trunk/gtk/: gui_utils.c gui_utils.h main.c prefs_gui.c prefs_layout.c /trunk/: ui_util.h

2010-08-09 Thread Stig Bjørlykke
On Sat, Aug 7, 2010 at 4:37 PM, etx...@wireshark.org wrote: Log:  From Cal Turney:  Optionally display Wireshark version in the main window's title bar.  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5040 With this patch I get a crash at startup on both OSX and Linux. -- Stig

Re: [Wireshark-dev] Export to CSV

2010-09-01 Thread Stig Bjørlykke
://bugs.wireshark.org/bugzilla/ so we don't forget about it. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] Export to CSV

2010-09-01 Thread Stig Bjørlykke
as PSML. The second time a PSML file is saved it's missing the headers. I'll fix both cases :) -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org

Re: [Wireshark-dev] [Wireshark-commits] rev 34098: /trunk/ /trunk/: CMakeLists.txt

2010-09-15 Thread Stig Bjørlykke
On Wed, Sep 15, 2010 at 12:17 AM, Joerg Mayer jma...@loplof.de wrote: What's the idea of this patch? I get a lot of warnings when using CMake 2.8.1 on OSX about using relative paths. So I tried this fix. Should we do it differently? -- Stig Bjørlykke

Re: [Wireshark-dev] rev 34098: /trunk/ /trunk/: CMakeLists.txt

2010-09-16 Thread Stig Bjørlykke
as well? I get no warnings with this patch when removing my previous fix. I suppose this is the correct fix :) -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http

Re: [Wireshark-dev] [Wireshark-commits] rev 34167: /trunk/gtk/ /trunk/gtk/: menus.c

2010-09-21 Thread Stig Bjørlykke
() you seem to use ui_manager_packet_list_heading before it's initialized. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 34186: /trunk/ /trunk/epan/: column-utils.c column.c column.h column_info.h epan.c epan.h prefs.c proto.c proto.h /trunk/gtk/: main.c main_packet_list.c new

2010-09-23 Thread Stig Bjørlykke
this value from the heading popup menu. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman

Re: [Wireshark-dev] configure fails with cmake on macosx

2010-09-23 Thread Stig Bjørlykke
On Thu, Sep 23, 2010 at 9:01 PM, H.sivank hsiv...@gmail.com wrote: -cmake_authors.diff : sometimes reconfigure does not find authors file Doesn't this write the file in the source dir? I suppose this should be put in the build dir? -- Stig Bjørlykke

Re: [Wireshark-dev] configure fails with cmake on macosx

2010-09-23 Thread Stig Bjørlykke
On Thu, Sep 23, 2010 at 9:01 PM, H.sivank hsiv...@gmail.com wrote: -cmake_zlib.diff : fix zlib librairies env Is the ${Z_LIBRARIES} a typo? I don't see it used anywhere else. -- Stig Bjørlykke ___ Sent via:Wireshark

Re: [Wireshark-dev] configure fails with cmake on macosx

2010-09-23 Thread Stig Bjørlykke
problems with plugins building with CMake on OSX, but never looked into it. I will have a look at this tomorrow. And sorry for the overlapping commits :) -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] configure fails with cmake on macosx

2010-09-24 Thread Stig Bjørlykke
/CheckCLinkerFlag.cmake. When running cmake check_c_linker_flag() returns 1 for -Wl,--as-needed, but this flag not work when compiling. Maybe cmake uses different tools when checking? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing

Re: [Wireshark-dev] Virtual WireShark appliance

2010-09-24 Thread Stig Bjørlykke
34233, does this work for you? And please keep the discussion in the correct thread :) -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists

Re: [Wireshark-dev] Virtual WireShark appliance

2010-09-24 Thread Stig Bjørlykke
On Fri, Sep 24, 2010 at 3:55 PM, Joerg Mayer jma...@loplof.de wrote:    Stig: you mentioned problems with XCODE? Yes. CMake determines to use -Wl,--as-needed, but the linker does not like this option. Any idea what to look for? -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 34247: /trunk/ /trunk/epan/: proto.c /trunk/gtk/: main.c prefs_column.c

2010-09-25 Thread Stig Bjørlykke
functionality. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 34247: /trunk/ /trunk/epan/: proto.c /trunk/gtk/: main.c prefs_column.c

2010-09-25 Thread Stig Bjørlykke
invalid filters, but I would like to see filtering on all occurrences like in the comment. I think this is the behavior the user would expect. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 34248: /trunk/ /trunk/cmake/modules/: COPYING-CMAKE-SCRIPTS FindGLIB2.cmake FindGMODULE2.cmake /trunk/: CMakeLists.txt CMakeOptions.txt /trunk/wiretap/: CMa

2010-09-27 Thread Stig Bjørlykke
status -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] configure fails with cmake on macosx

2010-10-03 Thread Stig Bjørlykke
2010/9/24 Stig Bjørlykke s...@bjorlykke.org: When running cmake check_c_linker_flag() returns 1 for -Wl,--as-needed, but this flag not work when compiling. I'm still having problem with this when using XCode. Anything I should check? Making with Makefiles works as expected. -- Stig

Re: [Wireshark-dev] [Wireshark-commits] rev 34371: /trunk/ /trunk/tools/: Makefile.am make-services.pl /trunk/: Makefile.am Makefile.nmake services

2010-10-04 Thread Stig Bjørlykke
), and the conflicting entry to tcp/udp port 2049 (shilp). -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] [Wireshark-commits] rev 34186: /trunk/ /trunk/epan/: column-utils.c column.c column.h column_info.h epan.c epan.h prefs.c proto.c proto.h /trunk/gtk/: main.c main_packet_list.c new

2010-10-05 Thread Stig Bjørlykke
[1]? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] rev 34186: /trunk/ /trunk/epan/: column-utils.c column.c column.h column_info.h epan.c epan.h prefs.c proto.c proto.h /trunk/gtk/: main.c main_packet_list.c new

2010-10-05 Thread Stig Bjørlykke
, but I can use -E occurrence=l. I have to put another enhancement request on my growing todo list... :) -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http

Re: [Wireshark-dev] [Wireshark-commits] rev 34330: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2010-10-06 Thread Stig Bjørlykke
Sake: Did you know that the syntax check also check for valid hostnames via DNS? Try adding host localhost in the capture filter and watch the DNS traffic. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list

[Wireshark-dev] The TCP dissector needs an update

2010-10-09 Thread Stig Bjørlykke
of special handling, do we need this? Can't we use the common reassembly routines? Or maybe refactor some routines? Any takers? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives

Re: [Wireshark-dev] [Wireshark-commits] rev 34392: /trunk-1.4/ /trunk-1.4/epan/dfilter/: dfilter-macro.c /trunk-1.4/epan/dissectors/: packet-gsm_map.c packet-gtp.c packet-tcp.c packet-tcp.h /trunk-1.4

2010-10-13 Thread Stig Bjørlykke
On Wed, Oct 13, 2010 at 2:56 AM, Gerald Combs ger...@wireshark.org wrote: Can you try r34494 in the 1.4 trunk? Yes, this is the correct fix. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev

[Wireshark-dev] Register XML fields only once

2010-10-17 Thread Stig Bjørlykke
to test my changes with. Can anyone using the DTDS try the attached patch to see if we can do this optimization? -- Stig Bjørlykke packet-xml-register-once.patch Description: Binary data ___ Sent via:Wireshark-dev mailing

Re: [Wireshark-dev] deprecating check_col()

2010-10-22 Thread Stig Bjørlykke
this check in all col_* functions was that you do not _need_ to use check_col(), but may use it if something needs to be calculated before put in a column. So a case-by-case basis sounds right to me. -- Stig Bjørlykke ___ Sent via

[Wireshark-dev] Rebuilding asn1 dissectors

2010-10-31 Thread Stig Bjørlykke
to 0x01. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] Problems creating the OsX App

2010-11-18 Thread Stig Bjørlykke
in packaging/macosx/Wireshark.app/Contents/Resources/bin/ results in: This is fixed in trunk in revision 34583, I'll add it to the roadmap for released versions. Try the attached patch. -- Stig Bjørlykke ws-gdk-pixbuf.patch Description: Binary data

Re: [Wireshark-dev] [Wireshark-commits] rev 35975: /trunk/epan/dfilter/ /trunk/epan/dfilter/: dfilter-macro.c dfilter.c

2011-02-17 Thread Stig Bjørlykke
On Thu, Feb 17, 2011 at 9:15 AM, g...@wireshark.org wrote:  OK, let's try a couple more explicit checks against NULL, to see whether  that de-confuses Microsoft's code analyzer. Do we really want such changes? Personally I think it makes the code harder to read. -- Stig Bjørlykke

Re: [Wireshark-dev] Eliminate annoying color filter dialog

2011-03-09 Thread Stig Bjørlykke
(s). Maybe display all warnings (fetched from statusbar_push_temporary_msg?) in one window at startup, with an option to disable? This window can also be available from the menu for later analysis of all warnings. -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 36170: / /trunk/epan/dissectors/: packet-mndp.c /trunk/epan/: CMakeLists.txt

2011-03-09 Thread Stig Bjørlykke
tried, but I get a warning: packet-mndp.c: In function 'dissect_tlv': packet-mndp.c:192: warning: cast from pointer to integer of different size -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev

Re: [Wireshark-dev] New openSAFETY dissector

2011-03-18 Thread Stig Bjørlykke
On Fri, Mar 18, 2011 at 2:34 PM, Roland Knall rkn...@gmail.com wrote: Could someone please tell me, if sending a new dissector in as bug, is the accepted method of adding a new dissector? Yes. But you have to set review_for_checkin on the attached patch. -- Stig Bjørlykke

Re: [Wireshark-dev] Segmentation fault with SVN revision 36377 when configuring a specific DLT_USER

2011-03-29 Thread Stig Bjørlykke
./temp.pcap -V ./output_pcap.txt I think I'll fix this in proto_get_protocol_name(), because find_protocol_by_id() may return NULL. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives

Re: [Wireshark-dev] Segmentation fault with SVN revision 36377 when configuring a specific DLT_USER

2011-03-29 Thread Stig Bjørlykke
On Tue, Mar 29, 2011 at 12:20 PM, Pascal Quantin pascal.quan...@gmail.com wrote: What do you guys think ? I added this fix until I implement the correct fix, which may require some more work. Committed revision 36392. -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 36614: /trunk/ /trunk/epan/dissectors/: packet-snmp.c /trunk/asn1/snmp/: packet-snmp-template.c

2011-04-13 Thread Stig Bjørlykke
think? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] Compilation errors

2011-04-21 Thread Stig Bjørlykke
in the default branch if not having GEOIP (which will never happend, but will remove the warning). -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists

Re: [Wireshark-dev] Compilation errors

2011-04-21 Thread Stig Bjørlykke
for GEOIP because we only use hostlist_sort_column with values 0 and 1 without GEOIP. But I'm not sure if we will get a warning about unused code if we always return before g_assert, and g_assert is intended here, so maybe the return 0 will be wrong. -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c

2011-04-21 Thread Stig Bjørlykke
, ett_pn_io_profisafe_f_parameter_prm_flag1); This fix is completely wrong! You have no need for a proto_item_add_subtree without using the return value. In this case I suppose flags1_tree should be use in the next dissect_dcerpc_uint8 calls instead of using flags1_item. -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c

2011-04-21 Thread Stig Bjørlykke
of proto_item_add_subtree() may change. Comments? -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman

Re: [Wireshark-dev] Crash in capture_dlg.c:1890 (latest SVN)

2011-04-28 Thread Stig Bjørlykke
On Thu, Apr 28, 2011 at 10:29 AM, Kaul myk...@gmail.com wrote: When trying to run wireshark, then - capture - options from SVN 36928, F15beta/x86_64: I think this was introduced in revision 36741. Try the fix in revision 36929. -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 37072: /trunk/ /trunk/gtk/: ansi_a_stat.c gsm_a_stat.c gui_stat_menu.h main_statusbar.c menus.c menus.h /trunk/: Makefile.nmake config.h.win32 config.nmake

2011-05-13 Thread Stig Bjørlykke
think with this change? Startup time: Load time: 00:00.001 does not make any sense to me after closing a file. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http

Re: [Wireshark-dev] [Wireshark-commits] rev 37171: /trunk/ /trunk/: dumpcap.c

2011-05-26 Thread Stig Bjørlykke
). This is used in Live list of the capture interfaces from GUI. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] [Wireshark-commits] rev 37171: /trunk/ /trunk/: dumpcap.c

2011-05-27 Thread Stig Bjørlykke
On Fri, May 27, 2011 at 12:12 AM, Gerald Combs ger...@wireshark.org wrote: On 5/26/11 2:24 PM, Stig Bjørlykke wrote: On Mon, May 16, 2011 at 12:54 AM,  tue...@wireshark.org wrote: Log:  Change internal data structures to store and handle mulitple  pcap devices / pipes to capture from and open

Re: [Wireshark-dev] [Wireshark-commits] rev 37601: /trunk/gtk/ /trunk/gtk/: dcerpc_stat.c graph_analysis.c prefs_dlg.c rtp_player.c sctp_assoc_analyse.c sctp_byte_graph_dlg.c sctp_graph_dlg.c sctp_sta

2011-06-08 Thread Stig Bjørlykke
On Wed, Jun 8, 2011 at 12:52 AM, wme...@wireshark.org wrote: Log:  Fix gcc 4.6 set but not used [-Wunused-but-set-variable] warnings; prefs_dlg.c: In function ‘pref_check’: prefs_dlg.c:936:12: error: ignoring return value of ‘strtoul’, declared with attribute warn_unused_result -- Stig

Re: [Wireshark-dev] [Wireshark-commits] rev 37602: /trunk/gtk/ /trunk/gtk/: iax2_analysis.c rtp_analysis.c

2011-06-08 Thread Stig Bjørlykke
’, declared with attribute warn_unused_result iax2_analysis.c:2195:22: error: ignoring return value of ‘write’, declared with attribute warn_unused_result iax2_analysis.c:2198:22: error: ignoring return value of ‘write’, declared with attribute warn_unused_result -- Stig Bjørlykke

Re: [Wireshark-dev] [Wireshark-commits] rev 37601: /trunk/gtk/ /trunk/gtk/: dcerpc_stat.c graph_analysis.c prefs_dlg.c rtp_player.c sctp_assoc_analyse.c sctp_byte_graph_dlg.c sctp_graph_dlg.c sctp_sta

2011-06-08 Thread Stig Bjørlykke
or not). Still getting the warning. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman

Re: [Wireshark-dev] How to build on MACOS

2011-06-19 Thread Stig Bjørlykke
I'm using MacPorts (http://www.macports.org/) which works very well. It's easy to install needed libraries and follow updates. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org

<    1   2   3   4   5   6   >