[Wireshark-dev] Recommended QT version to build Wireshark Master ?

I'm finally getting around to building Wireshark (Windows 7 32 bit) again. What version of QT should be used ? WSDG sec 2.2.4 doesn't really say (although shows 5.5 in the example). WSDG sec 2.2.10 (which I just happened to see) says 5.6.1 The Master buildbot seems to be using 5.3 Also: wdsg

Re: [Wireshark-dev] Recommended QT version to build Wireshark Master ?

On 9/12/2016 3:11 PM, Bill Meier wrote: I'm finally getting around to building Wireshark (Windows 7 32 bit) again. What version of QT should be used ? WSDG sec 2.2.4 doesn't really say (although shows 5.5 in the example). WSDG sec 2.2.10 (which I just happened to see) says 5.6.1 The Master

Re: [Wireshark-dev] Enable extcap by default or not

On 9/9/2016 1:42 AM, Roland Knall wrote: Hello List There is currently a discussion going on in https://code.wireshark.org/review/#/c/17498 in regard to enabling extcap features by default or not. There are basically two sides to the argument: Cons - extcap interfaces are advanced features,

Re: [Wireshark-dev] Some planned cleanups of the 802.11 dissector

On 6/26/2016 6:07 PM, Joerg Mayer wrote: Hello, I plan to do some cleanups to - somewhat improve the readability of the code 1) Get rid of reduntant author entries and code comments, see https://code.wireshark.org/review/16154 2) Get rid of those fixed field functions that only add

Re: [Wireshark-dev] 802.11ac support version

On 4/6/2016 12:11 PM, Alexis La Goutte wrote: Hi, It is already supported on Wireshark from some major release But it is possible some stuff don't decode by Wireshark Cheers Looks to me like the initial (partial) 11ac support was added in Wireshark-1.10 (released in 2013). It should be

Re: [Wireshark-dev] build with vs2015

On 12/31/2015 10:45 AM, Anders Broman wrote: > I got it building at one point without qt, but I haven't tried for a while so it's possible some new errors have creapt in. What are the warnings/errors and you are building from top of trunk? Regards Anders The last time I built GTK Wireshark

[Wireshark-dev] config.h differences when generated by Autofoo vs CMake

Differences re #define statements for autofoo vs cmake generated config.h files on Linux. Notes: 1. "Used"/"Not used" for the #define'd symbols as shown below is based upon a simple grep though all the Wireshark *.h, *.c, *.cpp source files. 2. The comparison between the config.h files was

[Wireshark-dev] CMake: Disable building with QT ?

How do I disable building QT Wireshark when using CMake ? Thanks Bill ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe:

Re: [Wireshark-dev] CMake: Disable building with QT ?

On 11/12/2015 1:13 PM, Bill Meier wrote: How do I disable building QT Wireshark when using CMake ? Thanks Bill Answering my own question: cmake -DBUILD_wireshark=OFF ... ___ Sent via:Wireshark-dev mailing list

[Wireshark-dev] GCC GTK3 Wireshark build warnings ?

When building GTK3 Wireshark on my Fedora system (after not having done so for a while), I'm getting many warnings similar to the following: CC libgtkui_a-about_dlg.o In file included from /usr/include/gtk-3.0/gtk/gtk.h:263:0, from about_dlg.c:28:

Re: [Wireshark-dev] GCC GTK3 Wireshark build warnings ?

On 11/11/2015 9:57 PM, Bill Meier wrote: On 11/11/2015 1:24 PM, Bálint Réczey wrote: It looks like Balint already sent a patch to Gtk: https://www.wireshark.org/lists/wireshark-dev/201403/msg00042.html It seems to be a new breakage, I have to check it. Yep: from the gtk 3.18 repository

Re: [Wireshark-dev] GCC GTK3 Wireshark build warnings ?

On 11/11/2015 1:24 PM, Bálint Réczey wrote: It looks like Balint already sent a patch to Gtk: https://www.wireshark.org/lists/wireshark-dev/201403/msg00042.html It seems to be a new breakage, I have to check it. Yep: from the gtk 3.18 repository: gtkstyle.h commit 2015-05-14 Amend

Re: [Wireshark-dev] Dissect using val_to_str from external file

On 11/9/2015 10:49 AM, Jo wrote: Hello, In my protocol, one TLV is called "proto" and contains the IANA number of a well-known protocol. How can I display the value together with the string and using the available data from , for example? I know how to do it via val_to_str() but I am failing

Re: [Wireshark-dev] The ieee802.11 dissector is a steaming pile of ordure

On 9/9/2015 11:23 AM, Richard Sharpe wrote: Take a look at epan/dissectors/packet-ieee80211.c! Specifically, add_tagged_field. That function is approximately 2,300 lines long and it consists of one big switch statement with every arm containing open-coded statements to add things to the proto

Re: [Wireshark-dev] The ieee802.11 dissector is a steaming pile of ordure

On 9/9/2015 12:03 PM, Bill Meier wrote: On 9/9/2015 11:23 AM, Richard Sharpe wrote: Take a look at epan/dissectors/packet-ieee80211.c! Specifically, add_tagged_field. That function is approximately 2,300 lines long and it consists of one big switch statement with every arm containing open

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

On 8/31/2015 4:24 AM, Pascal Quantin wrote: > May be directly move to GeoIP 2 ? > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10658 > > > > I think the code is available from here: > > https://github.com/maxmind/libmaxminddb Hi all, I propose to do it in 2 steps as changing the

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

On 8/12/2015 12:21 PM, Bill Meier wrote: 2. I had to disable building with geoip because: #error: Macro definition of snprintf conflicts with Stan dard Library function declaration (compiling source file packet-ip.c) A little digging finds that the Windows Wireshark version of the GeoIP

[Wireshark-dev] MSVC 2015 (VC14) notes/issue

[Resend] I see that several people (Anders, ...) been building with MSVC-2015 (VC14) and have fixed a number of issues. So: I decided to download VC14 and give it a try (using NMake). A few questions: Are you using CMake or NMake ? If using NMake, I assume that you've updated config.nmake

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

I used nmake If using NMake, I assume that you've updated config.nmake etc. Is there some reason you've not committed the changes ? Oops: I hadn't checked for and noticed change #8683. I would have saved myself a lot of effort. I'll try it out. So far:

Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

On 8/12/2015 3:17 PM, Bill Meier wrote: I used nmake Oops: I hadn't checked for and noticed change #8683. I would have saved myself a lot of effort. I'll try it out. Ok: There are a few additional changes needed to config.nmake when building on a 32-bit Windows system. I'll upload

[Wireshark-dev] Gtk2 xor Gtk3

Seen on gtk-l...@gnome.org From eba...@gmail.com snip Having said that, I must also warn you: do not try to support GTK+ 2 and GTK+ 3 in the same code base. It was doable back when GTK+ 3 was new, four years ago, but the code base, requirement, assumptions, and API have been diverging to the

Re: [Wireshark-dev] Google deprecating OpenID 2.0

On 2/22/2015 9:16 AM, Evan Huus wrote: From the looks of it [1] Gerrit upstream is planning to just drop support for logging in with Google. [1] https://code.google.com/p/gerrit/issues/detail?id=2715 From the link given above: * You are already registered and you are using Google OpenID

Re: [Wireshark-dev] How do you start a petri-dish review in the review page?

On 2/15/2015 8:46 PM, Richard Sharpe wrote: Hi folks, How can I start a petri-dish build etc? Can't seem to figure it out. On the review page, you should have sections Code-Review Verified Petri-Dish Click +1 Test under Petri-Dish and then click Publish Comments

Re: [Wireshark-dev] Mailing List Discussions for Patches

On 2/9/2015 5:29 PM, Kevin Grigorenko wrote: Hi there. I wrote a patch to add a Sum column to the Service Response Time window which I've found useful in some customer work. I've reviewed § 3.9 Contribute your changes in the Developer's Guide and I didn't find any notes about whether or not

[Wireshark-dev] lua_bitop.c: MSVC2013 Code Analysis Warning

Hadriel: MSVC2013 Code Analysis is giving the following warning: ...\ws-git\epan\wslua\lua_bitop.c(116) : warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Results might not be an expected value. After quick look at the code, my reaction: Uh Oh...

Re: [Wireshark-dev] where to put the Bug: line for bugzilla integration

On 1/15/2015 10:44 AM, Jeff Morriss wrote: On 01/15/15 10:21, Evan Huus wrote: Public service announcement, since I've gotten a few emails from people confused why bugzilla integration seems flaky: The bugzilla integration will not automatically pick up on the Bug: line unless it is part

Re: [Wireshark-dev] [Wireshark-commits] master b0e6fbf: umts_fp: Replace se_new0(...) by wmem_new0(wmem_file_scope(), ...)

On 12/31/2014 11:31 AM, Evan Huus wrote: This is an init routine, which can be called when no file is in scope, so wmem_file_scope() is incorrect (and se_* was also incorrect). I'm actually not sure what this routine is doing, since it deals with conversations but there will never be any

Re: [Wireshark-dev] [Wireshark-commits] master b0e6fbf: umts_fp: Replace se_new0(...) by wmem_new0(wmem_file_scope(), ...)

On 12/31/2014 12:52 PM, Bill Meier wrote: On 12/31/2014 11:31 AM, Evan Huus wrote: This is an init routine, which can be called when no file is in scope, so wmem_file_scope() is incorrect (and se_* was also incorrect). I'm actually not sure what this routine is doing, since it deals

Re: [Wireshark-dev] Change in wireshark[master]: Remove unneeded #includes from epan/dissectors

On 12/19/2014 11:28 PM, Bill Meier wrote: I will make the changes (for packet.h related) to the epan/dissector .c files and upload the changes to Gerrit in the next day or so. Bill Done (committed) ... ___ Sent via

Re: [Wireshark-dev] Change in wireshark[master]: [WIP] Add .mailmap: fix duplicate/wrong e-mail or name in co...

On 12/18/2014 4:19 PM, Alexis La Goutte (Code Review) wrote: [WIP] Add .mailmap: fix duplicate/wrong e-mail or name in commit log It will be reused form generate AUTHORS file If the AUTHORS file is to be autogenerated: I vaguely remember that there may have been cases where someone

Re: [Wireshark-dev] Change in wireshark[master]: Remove unneeded #includes from epan/dissectors

On 12/19/2014 12:05 PM, Martin Mathieson (Code Review) wrote: Change subject: Remove unneeded #includes from epan/dissectors .. Remove unneeded #includes from epan/dissectors Martin: Obviously, #includes usage in

Re: [Wireshark-dev] Change in wireshark[master]: Remove unneeded #includes from epan/dissectors

On 12/19/2014 4:19 PM, Bill Meier wrote: On 12/19/2014 12:05 PM, Martin Mathieson (Code Review) wrote: Change subject: Remove unneeded #includes from epan/dissectors .. Remove unneeded #includes from epan/dissectors Martin

Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...

On 12/13/2014 4:56 PM, Evan Huus wrote: I didn't think single-byte fields could really have an endianess, so I thought ENC_NA was appropriate for them? Evan Using ENC_NA is certainly reasonable (and makes logical sense) for fetching single-byte fields. That being said, the convention

Re: [Wireshark-dev] Bugzilla permissions

On 12/12/2014 8:11 AM, Alexis La Goutte wrote: On Fri, Dec 12, 2014 at 8:47 AM, Michael Oed michael@gmail.com wrote: Hello, Hi Mike, it's some time ago, i was active in the wireshark project. But I'm back and will spend some more time to develop in the community. :-) Re-Welcome ! Now

Re: [Wireshark-dev] removed functions fast way to find substitutes?

On 11/21/2014 9:29 AM, Pascal Quantin wrote: 2014-11-21 14:06 GMT+01:00 Semjon se...@web.de mailto:se...@web.de: Am 21.11.2014 um 10:06 schrieb Guy Harris: On Nov 21, 2014, at 12:48 AM, Semjon semgo-S0/gaf8t...@public.gmane.org mailto:gaf8t...@public.gmane.org

Re: [Wireshark-dev] RoCE and CM dissector fixes

On 10/10/2014 4:43 PM, Tim (Thanh) Nguyen wrote: Hi Alexis, Sorry, I'm not familiar with Gerrit, and right now my normal work doesn't leave me any cycles to learn it for this purpose. If someone else would like to take this patch and properly submit it ,then feel free. Tim. See:

Re: [Wireshark-dev] Bugzilla / Gerrit hook not working anymore?

On 9/25/2014 5:16 PM, Pascal Quantin wrote: Hi, it looks like the hook updating Bugzilla with the changes pushed to Gerrit does not work (my last 2 changes did not update the corresponding bugs). Cheers, Pascal. It hasn't been working for me for a while with Windows Git, but I noted that

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

On 8/25/2014 1:48 PM, Alexis La Goutte wrote: Should we add some info then to the Dev Guide as to where to get the hook, It's already in http://wiki.wireshark.org/Development/SubmittingPatches#Setup We keep running into this problem - should the wiki page and the dev guide be consolidated?

Re: [Wireshark-dev] Adding trace to buildbot for fuzz testing

On 8/25/2014 3:37 PM, Stalley, Sean wrote: Hello All, I have a trace that I would like to add to the buildbot for regression testing. I uploaded it here: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=13015action=edit Is there a way I can add this trace to the list of traces that the

[Wireshark-dev] Expert name field in same name space as hf[] abbrev field ?

Since both the ei_register_info 'name' field and the hf_register_info 'abbrev' field can be used as filters I expect that they effectively are in the same name space and thus there should not be a matching 'name'/'abbrev' between the ei[] entries and the hf[] entries in a dissector. Is this

Re: [Wireshark-dev] Adding a new dissector - beginners guide

On 8/22/2014 5:22 AM, Graham Bloice wrote: On 22 August 2014 10:18, Thomas Wiens th.wi...@gmx.de mailto:th.wi...@gmx.de wrote: I've got another question to working on the comments in the review system: Is it good style to push every fixed comment as a single commit, or should

Re: [Wireshark-dev] Adding a new dissector - beginners guide

On 8/22/2014 10:15 AM, Thomas Wiens wrote: On 22 August 2014 16:05, wrote Graham Bloice: As I noted on the review, I think you must have removed the Change-ID: line from the commit message that Gerrit uses to track a new patch set for an existing change. You should have used `git commit

Re: [Wireshark-dev] [Wireshark-commits] master 31f3187: Fix warning: no previous prototype for ... [-Wmissing-prototypes]

On 8/18/2014 5:11 PM, Jeff Morriss wrote: On 08/18/14 09:14, Wireshark code review wrote: Fix warning: no previous prototype for ... [-Wmissing-prototypes] [...] Actions performed: from 3adbd93 Fix warning: no previous prototype for ... [-Wmissing-prototypes] adds 31f3187

[Wireshark-dev] The recent changes to proto.c appear to have broken things badly ...

Specifically: For some/many/all? dissectors, the protocol never appears in the 'protocol' column', isn't in the list of protos, filters for the protocol don't work. etc etc I guess something fails with respect to the proto_tree_add_item(..., proto_..., ...) call. Oddly enough, the actual

Re: [Wireshark-dev] The recent changes to proto.c appear to have broken things badly ...

On 8/3/2014 11:32 PM, Evan Huus wrote: On Sun, Aug 3, 2014 at 11:20 PM, Bill Meier wme...@newsguy.com mailto:wme...@newsguy.com wrote: Specifically: For some/many/all? dissectors, the protocol never appears in the 'protocol' column', isn't in the list of protos, filters

Re: [Wireshark-dev] O2 compile option makes it difficult to debug.

Hi, It seems like the O2 option interferes with running the debugger. Would it be better to only use O2 on release builds? I'm not sure how to do that, add nmake -f makefile.nmake release option? What I've done is to alter config.nmake slightly to allow the specification of

Re: [Wireshark-dev] Change in wireshark[master]: Skip the NCP dissector when building on Windows without Python

On 7/25/2014 8:52 AM, Joerg Mayer wrote: Does it really make sense to allow Windows builds without python installed? IMO we should by now require python to be present to be able to build on Windows (or any other plattform). +1 Ciao Jörg PS: In my opinion this is one of the cases

[Wireshark-dev] Difference between Autofoo and CMake build ?

(For Jörg Mayer) While reviewing the new ceph dissector [1], two issues cropped up where my build on Linux (using Autofoo) apparently gave different results then a build by Kevin Cox (the submitter of the new dissector) using CMake on Linux. He used GCC 4.9.1 and CMake while I used GCC

Re: [Wireshark-dev] Difference between Autofoo and CMake build ?

On 7/24/2014 2:09 PM, Kevin Cox wrote: I usually get these too. Maybe it was a compiler bug or something. I will try checking out the old version and doing a clean build to see if the warning/error shows up now. I just did a complete rebuild and I am now getting this error under CMake as

[Wireshark-dev] Current 'pre-commit' issues

I've been working with the current 'pre-commit' and have noticed the following issues: 1. Using the current pre-commit which calls checkAPIs, etc, it doesn't seem possible to make changes to certain files (e.g., wsgetopt.c) and submit them to Gerrit. - The files fail checkAPIs.pl

Re: [Wireshark-dev] Current 'pre-commit' issues

On 7/11/2014 3:09 PM, Evan Huus wrote: On Fri, Jul 11, 2014 at 12:42 PM, Bill Meier wme...@newsguy.com When you try and push a change to gerrit without a Commit-ID, the error message it returns includes the Commit-ID it's expecting, so you can manually git commit --amend and paste

Re: [Wireshark-dev] Backport request for proto_tree_add_subtree[_format]

On 7/10/2014 5:32 PM, Pascal Quantin wrote: Le 10 juil. 2014 23:19, Peter Wu pe...@lekensteyn.nl mailto:pe...@lekensteyn.nl a écrit : Hi all, I would like to have the proto_tree_add_subtree and proto_tree_add_subtree_format functions backported to master-1.12. Any objects to that?

Re: [Wireshark-dev] Patching as per checkAPI

On 6/18/2014 3:40 AM, Evan Huus wrote: If they're distinct changes on a single branch (so they're related, but make sense as individual commits in the final repo) then #2. Gerrit might warn you, but I think it will let you do it as long as you confirm you mean it. One push with multiple

Re: [Wireshark-dev] iSER dissector submission question

On 6/16/2014 6:33 AM, Yan Burman wrote: Hi, I am new to wireshark development. I have posted on gerrit a new iSER dissector. I also added a minor bug fix in ib_sdp dissector that I found while running fuzz tests (not part of the iSER patches). I do not know whom to add as reviewers in gerrit

Re: [Wireshark-dev] Does _U_ get defined to something non-null on Windows?

On 5/28/2014 7:29 PM, Richard Sharpe wrote: Hi folks, Does _U_ work with the Windows C/C++ compiler? If so, how is it defined? From windows config.h (derived from config.h.win32): #define _U_ So: _U_ on Windows is effectively ignored.

[Wireshark-dev] Use of tcp_dissect_pdus() with a protocol which has a variable length PDU length field

To: TCP re-assembly experts: The MQTT protocol dissected by packet-mqtt.c runs over TCP. The field which specifies the MQTT PDU length can be 1 to 4 bytes; the length of a complete MQTT PDU can be less than 4 bytes. So: trying use tcp_dissect_pdus() won't work since the fixed length needed

Re: [Wireshark-dev] Failed for master-1.10: [Automatic manuf, services and enterprise-numbers update for 2014-04-27]

On 4/28/2014 4:40 PM, Peter Wu wrote: On Monday 28 April 2014 22:36:46 Jaap Keuter wrote: I noticed that master and master-1.8 got their weekly updates, but master-1.10 missed it? Can we find out why? It probably has something to do with IANA changes, see

Re: [Wireshark-dev] Building with Visual Studio Professional 2013 ...

On 4/27/2014 6:16 PM, Richard Sharpe wrote: Woohoo! It works! With 1 caveat... :) I expect that probably trying to use Lua with Wireshark built with VS2013 will fail in some manner. Currently, building with VS2013 (VC12) is configured to link with a Lua DLL which is linked with the

[Wireshark-dev] Gerrit Diff format

(To: Gerald) Currently the Gerrit diff shows whitespace changes. Previously, when viewing diffs of SVN commits via the web, whitespace changes were not shown. If others agree, is it possible to configure the Gerrit diff to not show whitespace changes ? (Or to provide an option ?) Bill

Re: [Wireshark-dev] Viewing code in Gerrit

On 3/24/2014 9:21 AM, Evan Huus wrote: In summary: the diff is computed locally in javascript, and seems to be worse than O(n) on the size of the underlying file; viewing the diff for any file 1k lines may be slow, but if you just let it run it will finish eventually. Avoid

Re: [Wireshark-dev] Viewing code in Gerrit

On 3/24/2014 12:03 PM, Evan Huus wrote: IOW: The 2 versions being diff'd are downloaded in total before doing a local compare ? It seems so; however it doesn't appear to be the bandwidth that's the problem, but the actual diff algorithm. The bottleneck is definitely CPU. For those of us

Re: [Wireshark-dev] [Wireshark-commits] master 04c39bb: Add Lua heuristic dissector support

Re; doc/README.heuristic | 10 +-- + * but ONLY do this if your heuristic sits directly on top of UDP or TCP (ie, you did heur_dissector + * otherwise you'll be overriding the dissector that called your heuristic dissector. I think this is not correct.

Re: [Wireshark-dev] GIT tutorials

On 3/11/2014 1:47 PM, Hadriel Kaplan wrote: On Mar 11, 2014, at 1:18 PM, Christopher Maynard christopher.mayn...@gtech.com wrote: If possible, add some information/basic steps on a few more topics as well? For example: 1) How do you undo a commit, or undo part of a commit? You can reset

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 9817] Provide a way to clear the capture window without restarting the capture or reapplying the filter

On 2/28/2014 2:46 PM, bugzilla-dae...@wireshark.org wrote: *Comment # 3 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9817#c3 on bug 9817 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9817 from Guy Harris mailto:g...@alum.mit.edu * (In reply tocomment #2 show_bug.cgi?id=9817#c2)

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 9817] Provide a way to clear the capture window without restarting the capture or reapplying the filter

On 2/28/2014 3:45 PM, Guy Harris wrote: On Feb 28, 2014, at 11:52 AM, Bill Meier wme...@newsguy.com wrote: How about a third choice: just clear the summary pane (or scroll down so that the previous last line shown is at now the top (or similar) ? The summary pane currently shows what

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

On 2/25/2014 7:50 PM, Hadriel Kaplan wrote: On Feb 25, 2014, at 7:06 PM, Joerg Mayer jma...@loplof.de wrote: gerrit jmayer@egg:~/work/wireshark/git(master) git branch newsupdate jmayer@egg:~/work/wireshark/git(master) git checkout newsupdate Switched to branch 'newsupdate' % git checkout -b

[Wireshark-dev] Add a capability to disable/enable a dissector table ?

It seems to me that it would be nice to be able to disable/enable specific dissector and heuristic tables. For example, this would be useful when investigating tcp level issues for which tcp payload dissection is not interesting. All the different protocols which run over tcp wouldn't need to

Re: [Wireshark-dev] what is the meaning of function proto_register_subtree_array?

On 2/16/2014 7:44 AM, 我想不无聊 wrote: when you register a protocol,you should do the following three steps, 1.proto_register_protocol(); 2.proto_register_field_array(); 3.proto_register_subtree_array() what does the third function proto_register_subtree_array do?why ?and do it for what reason?

Re: [Wireshark-dev] Feature request: show context frames for frames matching display filter

On 2/16/2014 2:38 AM, Reinhard Nissl wrote: Hi, when investigating network issues with a display filter like frame.time_delta 0.1 it would be useful to also see the previous 10 and next 5 frames of the matching frame for example, to get an idea what caused that delay. This feature is

Re: [Wireshark-dev] [Wireshark-commits] rev 54983: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bgp.c

On 1/27/2014 12:23 PM, Evan Huus wrote: We should maybe make tshark -G values part of the test suite? (and maybe the other tshark -G dumps as well?) Certainly 'tshark -G values' should be added. (I'll do so). A quick look suggests that crashes in most (all ?) of the other -G dumps would

Re: [Wireshark-dev] Compilation failure on Fedora 20 - GTK3 issues

On 12/20/2013 12:46 PM, Joerg Mayer wrote: As Wireshark development doesn't really care about the compatibility with future GTK versions (we are migrating to Qt) I have disabled that warning for cmake builds. So either apply a similar change to the autotools build Done in SVN #54337.

Re: [Wireshark-dev] r54005 by wmeier for packet-mq.c and packet-mq-pcf.c

On 12/14/2013 5:30 AM, RobiOneKenobi wrote: Yes, if it didn't disturb too much people to have such long lines, I will prefer that you revert this part (hf[] entries reformatting), otherwise I will follow the majority wishses I've restored the single line per hf[] entry format in SVN #54005.

Re: [Wireshark-dev] r54005 by wmeier for packet-mq.c and packet-mq-pcf.c

On 12/18/2013 11:57 AM, Bill Meier wrote: On 12/14/2013 5:30 AM, RobiOneKenobi wrote: Yes, if it didn't disturb too much people to have such long lines, I will prefer that you revert this part (hf[] entries reformatting), otherwise I will follow the majority wishses I've restored the single

Re: [Wireshark-dev] Coding style and example dissector

On 12/18/2013 7:52 AM, Joerg Mayer wrote: On Tue, Dec 17, 2013 at 05:55:30PM -0800, Michael Lum wrote: Could someone please write a coding style section for the new dissectors and perhaps point to the best example dissector. doc/README.developer last sections (5. White space convention) more

[Wireshark-dev] Should existing use of 'LL' and 'ULL' when specifying a constant be fixed ?

README.developer says: When specifying an integral constant that doesn't fit in 32 bits, don't use LL at the end of the constant - not all compilers use LL for that. Instead, put the constant in a call to the G_GINT64_CONSTANT() macro, e.g. G_GINT64_CONSTANT(11644473600U) rather than

Re: [Wireshark-dev] [Wireshark-commits] rev 53531: /trunk/ /trunk/epan/dissectors/: packet-x11.c x11-declarations.h x11-enum.h x11-extension-errors.h x11-extension-implementation.h x11-glx-render-enum

On 11/23/2013 8:32 PM, morr...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=53531 User: morriss Date: 2013/11/24 01:32 AM Log: Some patches from Peter Harris to make it possible to build the X11 dissector again (and some various other improvements):

Re: [Wireshark-dev] r54005 by wmeier for packet-mq.c and packet-mq-pcf.c

On 12/13/2013 12:21 PM, RobiOneKenobi wrote: Reformat hf[] entries ? Why, now all seems no more aligned for me, and your reformat also left spaces between text and comma. You're right; I was sloppy about leaving spaces between the text and the comma. :) I do not agree with such

[Wireshark-dev] How about we change Filter button to say Diisplay Filter on the main Wireshark GUI page ?

Maybe this would help to make things a bit more clear. I'd also like to add text to the tooltip: Something like: (To enter a capture filter see Capture/Options) Opinions ? ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] Windows build setup - Concept required

Re: creating/using a standard package directory structure on Windows It sounds like you're suggesting that we take the packages as distribited and move things around to a standard structure. This sounds to me like the effort to do this it might be crazy-making ... Also: A

Re: [Wireshark-dev] Windows build setup - Concept required

On 12/5/2013 3:02 PM, Bill Meier wrote: I like Gerald's answers much better than mine :) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists

Re: [Wireshark-dev] Wireshark coding style help

On 11/21/2013 8:05 PM, Guy Harris wrote: On Nov 21, 2013, at 4:37 PM, Michael Lum michael@starsolutions.com wrote: Can someone tell me why code like this: i++; would have been changed to this: i += 1; ? If the code in question is stepping through a packet, and i is actually offset

Re: [Wireshark-dev] Problem...

On 11/17/2013 12:53 PM, Herb Falk h...@sisconet.com wrote: I just got the SVN stuff to compile, but from the documentation I can’t figure out what file is missing and where to put it… Based upon some preliminary research, it's possible that a setup command will be needed. I need to do a

Re: [Wireshark-dev] Problem...

On 11/17/2013 12:53 PM, Herb Falk h...@sisconet.com wrote: I just got the SVN stuff to compile, but from the documentation I can't figure out what file is missing and where to put it. Based upon some preliminary research, it's possible that a setup command will be needed. I need to do a

Re: [Wireshark-dev] 1.11.0 release

On 10/10/2013 10:56 AM, mman...@netscape.net wrote: My vote would be to install in a central location and make it just another step in +1 http://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html, just like installing Visual Studio. -Original Message- From: Gerald Combs

Re: [Wireshark-dev] Building on Windows with CMake: Status and help needed

On 10/6/2013 7:27 PM, Joerg Mayer wrote: The executables now compile and link except the gtk and qt guis. I have not yet been able to run the executables as running the binaries inside the build tree doesn't seem to work (unlike on linux). Ideas how to get this to work? Thanks Jörg This

Re: [Wireshark-dev] Transport name resolution

On 9/16/2013 4:15 PM, Dirk Jagdmann wrote: Should we, instead, look the port number up in the tcp.port or udp.port (or sctp.port) dissector table and, if it finds a dissector handle, look up the short name of the protocol for that dissector handle and use that? I think this is more useful,

Re: [Wireshark-dev] Clang build with ASAN

On 8/13/2013 9:43 AM, Evan Huus wrote: On Mon, Aug 12, 2013 at 11:17 AM, Alexis La Goutte alexis.lagou...@gmail.com mailto:alexis.lagou...@gmail.com wrote: Hi, it is now possible to build wireshark with clang (CC=clang ./configure make) (i fix last issue last week end). I

Re: [Wireshark-dev] [Wireshark-commits] rev 48652: /trunk/ui/gtk/ /trunk/ui/gtk/: capture_dlg.c

On 3/30/2013 7:57 AM, j...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=48652 User: jake Date: 2013/03/30 04:57 AM Log: Have 'Capture file' and 'Stop after' extries left aligned in GTK+ 3 as well. Directory: /trunk/ui/gtk/ ChangesPath

Re: [Wireshark-dev] [Wireshark-commits] rev 48555: /trunk/epan/ /trunk/epan/: value_string.c

On 3/25/2013 8:37 PM, g...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=48555 User: guy Date: 2013/03/25 05:37 PM Guy; I'm curious why you added the following test in the recent value_string.c patch if (first_value vs_p[i].value) {

Re: [Wireshark-dev] [Wireshark-commits] rev 48555: /trunk/epan/ /trunk/epan/: value_string.c

On 3/26/2013 1:29 PM, Guy Harris wrote: On Mar 26, 2013, at 5:40 AM, Bill Meier wme...@newsguy.com wrote: I'm curious why you added the following test in the recent value_string.c patch if (first_value vs_p[i].value) { g_warning(Extended value string %s forced to fall back

Re: [Wireshark-dev] [Wireshark-commits] rev 48445: /trunk/ui/gtk/ /trunk/ui/gtk/: capture_dlg.c conversations_table.c gui_utils.c gui_utils.h hostlist_table.c

On 3/20/2013 6:41 PM, ger...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=48445 User: gerald Date: 2013/03/20 03:41 PM Gerald: There recently was an issue in capture_if_dlg.c where the use of gtk_window_get_size() and gtk_window_resize() seemed not

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

On 3/17/2013 10:30 AM, Evan Huus wrote: These are still happening occasionally. I dug out my XP-32 virtualbox instance but have not been able to reproduce. Tangentially, running the test suite from cygwin I get the following failure (after the test the build-bot keeps failing on): 5 Suite:

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

On 3/17/2013 11:00 AM, Bill Meier wrote: Basically: You have to setup the Windows cmd environment so that MSVC can be invoked from the command line. (nmake, etc) (When you then run cygwin bash to run the test scripts nmake etc will be available). For instance: in my Windows cmd line setup

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

On 3/17/2013 12:09 PM, Evan Huus wrote: I'm still not having any luck (and I've reread https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html to no avail). I have two shells available: cygwin's bash and windows' cmd.exe. If I run cmd.exe and then run the vcvars32 script, I can build

Re: [Wireshark-dev] Fun with window resizing in GTK3

On 3/13/2013 5:49 PM, Guy Harris wrote: On Mar 13, 2013, at 1:04 PM, wme...@wireshark.org wrote: (This stuff in GTK3 about parents inheriting expand/fill properties from children is driving me crazy). Presumably the GTK+ developers thought that this was a Good Idea. Have we just not been

[Wireshark-dev] -Wmissing-prototypes ??

Anders: Just out of curiosity, why are the prototypes in the following change needed ? Or: maybe the real question is: why is -Wmissing_prototypes needed ? We already catch any .h files which are missing prototypes of global functions because we use -Wimplicit-function-declaration (part of

[Wireshark-dev] dlg_utils.c comment completely obsolete ??

In dlg_utils.c: GtkWidget * dlg_window_new(const gchar *title) { ... /* * XXX - if we're running in the capture child process, we can't easily * make this window transient for the main process's window. We just * punt here. * * Perhaps the child process should only capture packets, write

[Wireshark-dev] Editcap link warnings

Recent Windows 7 and Windows XP Buildbot builds have been giving locally defined symbol ... imported in ... warnings while linking editcap: (I get the same warnings on my system). From the Window 7 Buildbot log: Linking editcap.exe link

Re: [Wireshark-dev] finishing Cmake (Was: Simpifying exporting DLL symbols)

On 2/27/2013 11:51 AM, Bálint Réczey wrote: Hi, - Add asn1 autogen target (assigned: krj) Since the asn1 seems to be assigned already I did not want to intervene with it. ;-) The last commit from krj was in r35324 | krj | 2011-01-02 03:29:33 -0500 (Sun, 02 Jan 2011) so, I expect,

Re: [Wireshark-dev] Simpifying exporting DLL symbols

On 2/26/2013 5:11 PM, Bálint Réczey wrote: 2013/2/26 Pascal Quantin pascal.quan...@gmail.com: ... Thank you! If no one opposes I'll commit the patch on Thursday and then start converting the remaining libs. It sounds like the change is significant. if so, I suggest we consider if we

  1   2   3   4   5   6   7   >