Re: [Wireshark-dev] Pointers needed for building Wireshark 2.6.3 on a Raspberry Pi model 3B (armv7 processor?)

2018-09-20 Thread Ed Beroset
On 9/17/18 1:04 PM, Jaap Keuter wrote: HI, Just a few responses on some items here. It seems that you got into building a (rather complicated) program for the first time. Please excuse us for not being in the business of teaching ‘first timers’ how this is done on the multitude of platforms

Re: [Wireshark-dev] Building RPM proprietarry plugin including math.h fails

2018-08-28 Thread Ed Beroset
On 08/28/2018 09:35 AM, Anders Broman wrote: Hi, tfo/packet-tfo.c:3754: undefined reference to `pow' collect2: error: ld returned 1 exit status when running make-rpm-package That's the symptom of missing the math library on the linker command line. You'd need to add '-lm' to the linker

[Wireshark-dev] donation to menagerie?

2018-03-06 Thread Ed Beroset
I submitted a tiny patch to address a particular need I saw recently. (https://code.wireshark.org/review/#/c/26280/) The patch just adds a more specific expert warning ("Payload IE in header") already would have been flagged by a more general expert warning ("Unsupported IE ID"). The

Re: [Wireshark-dev] gerrit registration problems

2018-02-21 Thread Ed Beroset
On 02/20/2018 10:39 PM, Richard Sharpe wrote: On Tue, Feb 20, 2018 at 7:07 PM, Ed Beroset <bero...@mindspring.com> wrote: On 01/31/2018 09:44 AM, Ed Beroset wrote: I've submitted code to Wireshark in the past, but not since Gerrit. I tried again yesterday to register and now I rememb

Re: [Wireshark-dev] gerrit registration problems

2018-02-20 Thread Ed Beroset
On 01/31/2018 09:44 AM, Ed Beroset wrote: I've submitted code to Wireshark in the past, but not since Gerrit.  I tried again yesterday to register and now I remember why it's been so long -- I can't seem to register.  Is this the place to ask for help, or is there a better way to do it? I

[Wireshark-dev] report from the bleeding edge (VS 2017)

2018-02-09 Thread Ed Beroset
On 04/24/2017 01:01 PM, Graham Bloice wrote: Who knows what will be in the next Visual Studio.  I haven't seen any announcements, but as VS 2017 was only released just over a month ago I don't expect any public announcements yet. It's possible that future C++ language changes may force them

Re: [Wireshark-dev] gerrit registration problems

2018-02-01 Thread Ed Beroset
On 01/31/2018 11:36 AM, Jeff Widman wrote: What error message are you hitting when you try to register? I had two problems, which may be related. First, I appear to have been able to register, but when I tried to assign myself a user name, it rejected it saying that it needed to consist of

[Wireshark-dev] gerrit registration problems

2018-01-31 Thread Ed Beroset
I've submitted code to Wireshark in the past, but not since Gerrit. I tried again yesterday to register and now I remember why it's been so long -- I can't seem to register. Is this the place to ask for help, or is there a better way to do it? Ed

Re: [Wireshark-dev] Adding pcap-ng pipe support to dumpcap

2017-08-31 Thread Ed Beroset
On 08/30/2017 09:31 PM, Guy Harris wrote: On Aug 30, 2017, at 6:00 PM, Ed Beroset <bero...@mindspring.com> wrote: One problem is that as dumpcap is currently written, it treats files and pipes very differently. *Files* and pipes, or *capture devices* and pipes? Actually, I meant

Re: [Wireshark-dev] Adding pcap-ng pipe support to dumpcap

2017-08-30 Thread Ed Beroset
On 08/30/2017 07:58 PM, Stephen Donnelly wrote: Why pcap-ng specifically? Although pcap-ng is higher featured than pcap, it is not Wireshark's internal representation. Pcap-ng is merely the default output format. I don't know about other people's desire for this, but here's mine: I am

Re: [Wireshark-dev] Adding pcap-ng pipe support to dumpcap

2017-08-29 Thread Ed Beroset
On 08/29/2017 02:35 PM, Richard Sharpe wrote: On Tue, Aug 29, 2017 at 10:50 AM, Ed Beroset <bero...@mindspring.com> wrote: On 06/16/2017 01:27 PM, Richard Sharpe wrote: I've just encountered a need for this as well. Have you made progress, Evan? Do you want some help? Evan seems t

Re: [Wireshark-dev] Adding pcap-ng pipe support to dumpcap

2017-08-29 Thread Ed Beroset
On 06/16/2017 01:27 PM, Richard Sharpe wrote: On Fri, Jun 16, 2017 at 9:36 AM, Kvidera, Evan D wrote: Hello Wireshark Devs, My name is Evan Kvidera and I am a senior undergraduate student studying Computer Science. I have a decent amount of programming experience, but

Re: [Wireshark-dev] Remove our bundled crypto library (in favor of Libgcrypt)?

2017-02-11 Thread Ed Beroset
Bálint Réczey wrote: +1 for going without a new layer of indirections. Making libgcrypt mandatory is easy and every level of indirection make understanding the code harder which is a source of bugs. If we ever feel dropping libgcrypt necessary we can add the new layer. FWIW, I heartily agree

Re: [Wireshark-dev] Menagerie

2015-02-27 Thread Ed Beroset
Dario Lombardo wrote: Should be supported by your torrent client (maybe create torrent or something). Once you succeded, send us the torrent. How large it is? From the originally sent torrent, it seems to be 1.88G. I'm interested in this too and could seed pretty much perpetually once we get it

[Wireshark-dev] error initializing git review

2015-02-05 Thread Ed Beroset
I've followed the steps here: https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcObtain.html And I've successfully gotten to the step where it says to run git review -s but then it fails. The full error dump is: Traceback (most recent call last): File /usr/bin/git-review, line 10, in

Re: [Wireshark-dev] error initializing git review

2015-02-05 Thread Ed Beroset
Graham Bloice wrote: On 5 February 2015 at 17:48, Ed Beroset bero...@mindspring.com wrote: Problems encountered installing commit-msg hook The following command failed with exit code 104 GET https://bero...@code.wireshark.org/tools/hooks/commit-msg; --- [...] I

Re: [Wireshark-dev] Update Windows Build Instructions

2015-01-05 Thread Ed Beroset
Stephen Fisher wrote: Yes, use CMake :-) There are other cross-platform build solutions such as SCons, but it's just as bad as CMake (or maybe worse, I haven't tried anything other than a toy project). Adding a dissector to CMake is as simple as it is for nmake with the bonus that it

Re: [Wireshark-dev] On which platforms is there a need for Wireshark to have a Language preference?

2014-11-06 Thread Ed Beroset
Guy Harris wrote: but in home I want to use Italian Wireshark and sometimes Polish/English. Set language in GUI is really helpful. Is the ability to set the language on a *per-application* basis, rather than on a system-wide basis, really helpful to very many users? It doesn't seem so to me,

Re: [Wireshark-dev] ctype.h calls

2014-10-28 Thread Ed Beroset
Jeff Morriss wrote: Is there any reason the remaining ctype.h calls in master shouldn't be removed [and the functions put on the prohibited list in checkAPIs.pl]? One of the calls in ctype.h is tolower() which is used in wsutil/strncasecmp.c. Could we simply remove that entire file and use

Re: [Wireshark-dev] How to support wireshark w/o having an OpenID

2014-08-11 Thread Ed Beroset
Evan Huus wrote: On Aug 10, 2014, at 21:43, Ed Beroset wrote: I'm not sure it matters sufficiently that it could or should cause course alteration, but as one who has contributed modestly to Wireshark before the move to gerrit, but not since then, I'd have to say that for me, the setup

Re: [Wireshark-dev] How to support wireshark w/o having an OpenID

2014-08-10 Thread Ed Beroset
-Original Message- From: Kevin Cox kevin...@kevincox.ca Sent: Aug 9, 2014 4:05 PM To: Developer support list for Wireshark wireshark-dev@wireshark.org Subject: Re: [Wireshark-dev] How to support wireshark w/o having an OpenID On 09/08/14 12:51, Toralf Förster wrote: My question is

Re: [Wireshark-dev] gtk.h not found when compiling Wireshark 1.10.2 on Fedora 19

2014-01-15 Thread Ed Beroset
John Powell wrote: I am trying to compile wireshark-1.10.2 on Fedora 19. Most of my machines are currently running Fedora 19, so I know this actually works. I get the following error: checking for GTK+ - version = 2.12.0 and 3.0... no [...] conftest.c:34:21: fatal error: gtk/gtk.h: No such

[Wireshark-dev] setcap for CMake install under Linux

2014-01-12 Thread Ed Beroset
I've recently been trying to get used to the new system (git, gerrit, CMake) and noticed that unlike the autotools installation, the CMake installation does not seem to have support for setcap. Is that correct, or am I just overlooking something? Ed

Re: [Wireshark-dev] Expert item for TCP RST flag

2014-01-09 Thread Ed Beroset
Joerg Mayer wrote: The reason for my question is that someone had network trouble and looked at the error/warning items. Had RST been at that level, he would have found the problem lots of work hours earlier - the RSTs were indications of a real problem. So the question is: Do we allow lazy

Re: [Wireshark-dev] Git + Gerrit: next steps

2013-12-18 Thread Ed Beroset
Gerald Combs wrote: I'm assuming everyone has had a chance to test the Gerrit installation at test.code.wireshark.org If you haven't, now might be a good time. Had the chance to, perhaps, but haven't yet. I'm not sure I saved the old emails about it, and http://www.wireshark.org/develop.html

Re: [Wireshark-dev] OID/BER memory oddness

2013-12-15 Thread Ed Beroset
Evan Huus wrote: In one sense the problem is easy to trace: the oid resolution code is returning the resolved string in an ep-allocated buffer, which is then getting freed and subsequently used. However, I'm having trouble tracking down exactly where this resolved oid is being persisted between

Re: [Wireshark-dev] OID/BER memory oddness

2013-12-15 Thread Ed Beroset
Evan Huus wrote: The part that's confusing me is that somehow actx-external.direct_reference seems to be getting a pointer to this stale ep-allocated buffer, but I can't find anywhere in the call stack that value could be set to such a stale buffer. That would probably be

Re: [Wireshark-dev] OID/BER memory oddness

2013-12-15 Thread Ed Beroset
Ed Beroset wrote: Evan Huus wrote: The part that's confusing me is that somehow actx-external.direct_reference seems to be getting a pointer to this stale ep-allocated buffer, but I can't find anywhere in the call stack that value could be set to such a stale buffer. That would probably

Re: [Wireshark-dev] [Wireshark-commits] rev 52701: /trunk/epan/ /trunk/epan/: oids_test.c

2013-10-21 Thread Ed Beroset
Joerg Mayer wrote: On Sun, Oct 20, 2013 at 02:18:19AM +, eapa...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=52701 User: eapache Date: 2013/10/20 02:18 AM Log: Don't use g_assert_cmpint, it isn't happy on Windows. g_assert is nearly as good

[Wireshark-dev] asn1 plugin

2013-10-19 Thread Ed Beroset
Recently, while I was working on unit tests for oids.c (see https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9294 ), I noticed a few lines toward the bottom of the oids.h file which say: /* macros for legacy oid functions */ #define oid_resolv_cleanup() ((void)0) #define subid_t guint32 It

[Wireshark-dev] column format strings

2013-10-15 Thread Ed Beroset
While attempting to answer a question[1] on ask.wireshark.org, I looked for the documentation for column format codes that may be used to customize tshark's output. After a few minutes of searching, it seemed to me that the only place they're documented was in the source code, which seems

Re: [Wireshark-dev] Handling of generated dissectors

2013-10-07 Thread Ed Beroset
mmann78 wrote: I think the issue is that not all generated dissectors can be generated on all platforms Wireshark supports (for varying reasons). There were separate steps (outside of the Wireshark build process) to generate the PIDL dissector source as well as idl2wrs (GIOP) ones and I

Re: [Wireshark-dev] wireshark crashing [SOLVED]

2013-09-13 Thread Ed Beroset
Following up to my own report, I figured out the problem. Somehow, I had two older versions of the libwiretap libraries lying around in my /usr/local/lib directory: lrwxrwxrwx. 1 root root19 Sep 12 09:54 libwiretap.so - libwiretap.so.0.0.0 lrwxrwxrwx. 1 root root19 Sep 12

[Wireshark-dev] wireshark crashing

2013-09-12 Thread Ed Beroset
In working through the tutorial for ns3 (see http://www.nsnam.org/docs/release/3.14/tutorial/singlehtml/index.html ) I've created two simple pcap files. When I try to look at them using wireshark, I get a signal 11 (segmentation fault). I've done a backtrace and the last function call is

Re: [Wireshark-dev] rev 50749: /trunk/ /trunk/: CMakeLists.txt

2013-07-23 Thread Ed Beroset
Joerg Mayer wrote: On Tue, Jul 23, 2013 at 11:38:00PM +0200, Jakub Zawadzki wrote: I've tried googling for this error message... Have you tried uninstallation of VC runtimes / compilers? It's suggested by:

Re: [Wireshark-dev] manual address resolution is broken

2013-05-28 Thread Ed Beroset
Anders Broman wrote: Ed Beroset wrote: My inclination would be for option 2 be the default, but with option 1 being available as a configuration checkbox. Yes this sounds like the thing to do for me to, regarding address resolution there has been discussions of a rewrite using normal hash

[Wireshark-dev] manual address resolution is broken

2013-05-23 Thread Ed Beroset
Today I was analyzing some capture files and wanted to use manual name resolution to make things a little to interpret, but I found out that manual name resolution no longer works. The bug has already been reported https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8462 and a patch submitted,

Re: [Wireshark-dev] Start and stop capture toolbar buttons?

2013-04-09 Thread Ed Beroset
Evan Huus wrote: The *proper* (for certain values of that word) way to decide this issue is really to do a usability study, however that is expensive/time-consuming so unless Riverbed wants to make that investment it isn't likely to happen with any degree of rigour. There was a study on that very

Re: [Wireshark-dev] proposed graph_analysis.c change

2013-03-23 Thread Ed Beroset
Jaap Keuter wrote: On 03/23/2013 12:58 AM, Ed Beroset wrote: In working on fixing a bug today, I made a proposed change or two to graph_analysis.c. See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7418 for the context. The first patch was a very conservative one that simply added a bit

[Wireshark-dev] proposed graph_analysis.c change

2013-03-22 Thread Ed Beroset
In working on fixing a bug today, I made a proposed change or two to graph_analysis.c. See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7418 for the context. The first patch was a very conservative one that simply added a bit of code to address a problem with not being able to resize

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2013-03-17 Thread Ed Beroset
-Original Message- From: Evan Huus eapa...@gmail.com Sent: Mar 17, 2013 12:09 PM To: Developer support list for Wireshark wireshark-dev@wireshark.org Subject: Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86 I'm still not having any

Re: [Wireshark-dev] wtap_dump_file_seek() and _tell()

2013-03-16 Thread Ed Beroset
Guy Harris wrote: On Mar 3, 2013, at 11:10 AM, Ed Beroset bero...@mindspring.com wrote: According to svn, version 36318 (March 2011) added, among other things, the following lines to the wiretap/wtap-int.h file: extern gint64 wtap_dump_file_seek(wtap_dumper *wdh, gint64 offset, int whence

Re: [Wireshark-dev] wtap_dump_file_seek() and _tell()

2013-03-16 Thread Ed Beroset
Ed Beroset wrote: Done, and submitted as a patch to Bug 8416: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416. I haven't compiled this under Windows yet, but will later today. OK, now I've updated the patch to work correctly under Windows as well. Ed

[Wireshark-dev] wtap_dump_file_seek() and _tell()

2013-03-03 Thread Ed Beroset
According to svn, version 36318 (March 2011) added, among other things, the following lines to the wiretap/wtap-int.h file: extern gint64 wtap_dump_file_seek(wtap_dumper *wdh, gint64 offset, int whence, int *err); extern gint64 wtap_dump_file_tell(wtap_dumper *wdh); However, unlike most of

[Wireshark-dev] Bug 8416 - remove C++ incompatibilities from packet-pw-atm.c

2013-02-28 Thread Ed Beroset
As mentioned in the subject line, I've added Bug 8416 - remove C++ incompatibilities from packet-pw-atm.c with the associated patch. Doing a little forensic work on the C++ incompatibilities still present in the code base, here are the types of issues of the 4919 c++-incompat lines in a

Re: [Wireshark-dev] Bug 8416 - remove C++ incompatibilities from packet-pw-atm.c

2013-02-28 Thread Ed Beroset
Jaap Keuter jaap.keu...@xs4all.nl What I would like to see is the abolishment of the pwc_packet_properties_t type altogether. This is _not_ an enum. I agree, and have come across another such enum abuse instance that may be harder to address. Specifically, in the header file gmessages.h there

Re: [Wireshark-dev] Win7 - 64 bit build

2013-02-23 Thread Ed Beroset
Alex Lindberg wrote: One additional item. When building an NSIS install package on a Win7 64 bit system, the NSIS installs to C:\Program Files (x86)\NSIS. In config.nmake, the makensis.exe files uses C:\Program Files, thus failing. I did the following: Added:

Re: [Wireshark-dev] Idle Thought - Compiling with C++

2013-02-16 Thread Ed Beroset
Evan Huus wrote: If we do plan to migrate we will definitely be using only C-style constructs to start. It will be enough work transitioning compilers without changing language constructs at the same time. I've created a patch which implements one small part of this and have attached it to

Re: [Wireshark-dev] Thoughts on the default layout

2013-02-16 Thread Ed Beroset
Evan Huus wrote: I've been playing with various layouts for the main dissection interface and I've found one that works better (for me) than the default. It leaves the packet list on top, but puts the details and bytes panes side by side on the bottom (details on the left, bytes on the right).

Re: [Wireshark-dev] Google Summer of Code 2013

2013-02-15 Thread Ed Beroset
Guy Harris wrote: What is the user to do when informed that a new version exists? [...] (I.e., different OSes do this differently, and perhaps we should handle this differently on different OSes.) VLC, which runs on Windows, Linux and OSX (I think) relies on separate package handlers under

Re: [Wireshark-dev] Idle Thought - Compiling with C++

2013-02-11 Thread Ed Beroset
Evan Huus wrote: On Mon, Feb 11, 2013 at 1:47 PM, Guy Harris g...@alum.mit.edu wrote: Note all the lines flagged with [-Wc++-compat]; those are for code that's valid C but not valid C++ and that would have to be fixed in order to compile with a C++ compiler (unless there's a let valid C code

Re: [Wireshark-dev] Idle Thought - Compiling with C++

2013-02-10 Thread Ed Beroset
Donald White wrote: That said, I have some experience with C to C++ transitions. Twice in my career, the team I was with was given the job of maintaining legacy products written in C (several 100K lines of code) to maintain and enhance. In both cases, our first step was to recompile with a C++

Re: [Wireshark-dev] Having issues with wireshark dissector installation

2013-01-30 Thread Ed Beroset
-Original Message- From: Graham Bloice graham.blo...@trihedral.com Sent: Jan 30, 2013 12:41 PM To: Developer support list for Wireshark wireshark-dev@wireshark.org Subject: Re: [Wireshark-dev] Having issues with wireshark dissector installation On 30 January 2013 17:10, Arshad

Re: [Wireshark-dev] Win7 - 64 bit build

2013-01-30 Thread Ed Beroset
Alex Lindberg wrote: I was having issues compiling a x64 build of Wireshark on a Win7x64 bit PC. I followed the instructions to the letter as referenced in the Win build page: http://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html All to no avail. After reinstalling several

Re: [Wireshark-dev] I need help with Capture Filter

2012-10-12 Thread Ed Beroset
Chuck H Wilson wrote: As the subject line states: I need help getting WireShark's capture filter to work. I have put together details of the problem(s) I'm having, but in keeping with the request of keeping the E-mail file size small, and not sending more information that would be useful for

Re: [Wireshark-dev] should editcap support -H and -W?

2012-10-02 Thread Ed Beroset
Jeff Morriss wrote: I noticed today (in fighting to get name resolution blocks into my PCAPNG files) that editcap does not (contrary to the man page) support the -H and -W options. Should it? I coded up a patch today but realized that it would require linking editcap against libwireshark. Do

[Wireshark-dev] tshark summary lines

2012-10-02 Thread Ed Beroset
Someone has asked a question on the wiki http://ask.wireshark.org/questions/14581/how-to-use-tshark-to-output-a-tcpdump-into-text-formatted-file Which asks if tshark can emit both the summary lines AND the details from -V. There is currently no way to do that, but it seemed to me like a

Re: [Wireshark-dev] tshark summary lines

2012-10-02 Thread Ed Beroset
printing from Wireshark. Ed -Original Message- From: Ed Beroset bero...@mindspring.com To: Developer support list for Wireshark wireshark-dev@wireshark.org Sent: Tue, Oct 2, 2012 11:25 am Subject: [Wireshark-dev] tshark summary lines Someone has asked a question on the wiki http

Re: [Wireshark-dev] tshark summary lines

2012-10-02 Thread Ed Beroset
Christopher Maynard wrote: They are all different: For bug 2892, if you use -T fields, there's no way to have the info column information also displayed. Support would have to be added to be able to specify something like e.g., -e col.info I think you're right. It would probably be

Re: [Wireshark-dev] tshark summary lines

2012-10-02 Thread Ed Beroset
Christopher Maynard wrote: Ed Beroset beroset@... writes: They are all different: For bug 2892, if you use -T fields, there's no way to have the info column information also displayed. Support would have to be added to be able to specify something like e.g., -e col.info I think you're right

Re: [Wireshark-dev] Transmission Latency Calculation

2012-10-01 Thread Ed Beroset
Christopher Maynard wrote: Herb Falk herb@... Herb@... writes: I am creating a dissector that needs to be able to calculate the transmission latency of a packet. The protocol being dissected has the timestamp of the “transmission”, I need to be able to gain access to the time of capture of

Re: [Wireshark-dev] RFD: Creating subdirectories in epan/dissectors/

2012-08-30 Thread Ed Beroset
Evan Huus wrote: On Thu, Aug 30, 2012 at 1:46 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: Unwieldy how? Except for having to know not to do vi epan/dissectors/tabtab (for fear of too many pages of output) I don't find the directory unwieldy. That's part of it - I still do that

Re: [Wireshark-dev] small query

2012-08-29 Thread Ed Beroset
Krishnamurthy Mayya wrote: Hi all, If i am writing a new file, in order for it to be compiled do i have to include the file-name in any existing directory/files?? the location of the new file is epan/dissectors. Generally, yes. The easiest way to find out where in a well-established

[Wireshark-dev] updating the developer's guide

2012-06-21 Thread Ed Beroset
I recently changed laptop computers (running Windows) and had to reconfigure everything to be able to once again rebuild Wireshark. Since it had been a while, I referred to the developer's guide, but that didn't quite fit what I wanted to do, which was to configure so that I could build with

[Wireshark-dev] privilege separation

2012-05-18 Thread Ed Beroset
On the Wireshark wish list is Add privilege separation for POSIX environments (in progress). What's left to do on that one? Apply the privilege during a make install? Ed ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] Query

2012-03-16 Thread Ed Beroset
krishna hegde wrote: I am using the Visual studio 2010 for the building Wire shark Source . I understand that Visual studio already has nmake utitiy. I am getting the error as Error 1 error U1065: invalid option '-' C:\Wireshark\NMAKE wireshark Error 2 error MSB3073: The command nmake -f

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2012-02-17 Thread Ed Beroset
Graham Bloice wrote: Most likely it has a problem with the / instead of \ in uil/util.obj. Does someone have an idea how to resolve this? util.obj is being produced in the top level root directory, but the linker is looking for it in ui\. I'm looking at the makefile now. Hmm. I think

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2012-02-17 Thread Ed Beroset
Jeff Morriss wrote: I've been a little uneasy with the fact that there's no makefile in ui/ . It seems like putting source files in there but no makefile is asking for trouble. But I haven't thought about it much. We have the same issue in ui/cli. Ed

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2012-02-17 Thread Ed Beroset
Jeff Morriss wrote: Joerg Mayer wrote: On Fri, Feb 17, 2012 at 09:59:22AM -0500, Jeff Morriss wrote: Ed Beroset wrote: Graham Bloice wrote: Most likely it has a problem with the / instead of \ in uil/util.obj. Does someone have an idea how to resolve this? util.obj is being produced

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Visual-Studio-Code-Analysis

2012-01-15 Thread Ed Beroset
Jeorg, eax.c(32) : fatal error C1083: Cannot open include file: 'gcrypt.h': No such file or directory Ideas anyone? I see you already found and fixed the problem in version 40502. I apologize for accidentally deleting that change from the patch I submitted, Joerg. Thanks for doing that.

Re: [Wireshark-dev] Problem with tools/win-setup.sh

2012-01-06 Thread Ed Beroset
Ed Beroset wrote: Weir, Alan wrote: Hi Ed, When running nmake -f makefile.nmake verify_tools the message: ERROR: The contents of C:\wireshark-win32-libs\current_tag.txt is (unknown). It should be 2011-06-27. Is emitted even though the file exists and contains the correct text. Ah, good

Re: [Wireshark-dev] Problem with tools/win-setup.sh

2012-01-06 Thread Ed Beroset
Bill Meier wrote: So: We should add 'cat' to the list of tools checked. I have been thinking about this. We could either do that or, perhaps somewhat perversely, we could use an alternative based on an already required application such as Perl or Python. Also, we don't necessarily care

Re: [Wireshark-dev] Problem with tools/win-setup.sh

2012-01-05 Thread Ed Beroset
Weir, Alan wrote: The log indicates that the removal should be benign as it eliminated a warning but in my case (and others based on googling the error message) it prevents the cycwin path from being constructed correctly. I'm not a cycwin expert - anyone have any insight? Could be, but I'd

Re: [Wireshark-dev] happy birthday, bug 5531!

2012-01-05 Thread Ed Beroset
Joerg Mayer wrote: I have a few small questions that came up during looking at the patch (not all of them relevant to this patch!): - why is eax.[ch] in epan instead of epan/crypt/? - why do we have files named crypt/crypt-aes.c instead of crypt/aes.c? - is eax.c added to CMakeLists.txt as

Re: [Wireshark-dev] happy birthday, bug 5531!

2011-12-30 Thread Ed Beroset
Joerg Mayer wrote: I looked at this patch a bit but as I don't know anything about BER I can't comment on much. I have a few small questions that came up during looking at the patch (not all of them relevant to this patch!): - why is eax.[ch] in epan instead of epan/crypt/? It could be moved

Re: [Wireshark-dev] happy birthday, bug 5531!

2011-12-29 Thread Ed Beroset
Chris Maynard wrote: Ed Berosetberoset@... writes: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5531 It's been a year since it was originally submitted. As always, if there's anything I can do to help get this into the main code, please let me know. I know a number of people that

[Wireshark-dev] happy birthday, bug 5531!

2011-12-28 Thread Ed Beroset
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5531 It's been a year since it was originally submitted. As always, if there's anything I can do to help get this into the main code, please let me know. I know a number of people that are waiting for it. And thanks again for a mighty

[Wireshark-dev] how to fix Wiki login problem

2011-12-13 Thread Ed Beroset
Sorry if this is the wrong place to ask, but the right place to ask is not obvious to me. I've done a number of edits on the Wireshark wiki (most recently in October) and intended to do a few more today, but found that my account won't work any longer and the various password recovery options

Re: [Wireshark-dev] for error on verify tools installed for Wireshark development

2011-12-08 Thread Ed Beroset
Song, Yuyin wrote: I am new to Whireshark development. I have installed all tools and Wireshark development version. When I verify all tools installed using command nmake –f Makefile.nmake verify_tools. I got the error message namke: fatal error U1073: don't konw hpw to make '-f' . What is

Re: [Wireshark-dev] Wireshark 1.6.4 is now available

2011-11-20 Thread Ed Beroset
Gerald Combs wrote: I'm proud to announce the release of Wireshark 1.6.4. Good news! Is there any chance that the next version can include the patch for C12.22? It's coming up on a year since it was originally submitted. If there are any remaining impediments, please let me know. Thanks!

[Wireshark-dev] updated developer guide to show proper use of ENC_BIG_ENDIAN

2011-10-24 Thread Ed Beroset
I've entered a bug and attached a patch to both fix a minor build issue (typo in makefile) and to update the Developer Guide to show the correct use of ENC_BIG_ENDIAN rather than FALSE in the final argument of proto_tree_add_item() calls. It might be worth reviewing further to see if some of

Re: [Wireshark-dev] working with header data

2011-10-17 Thread Ed Beroset
Guy Harris wrote: crypto. If that can be done in a different fashion, as per my earlier suggestion, that code shouldn't even exist. I implemented your suggestion over the weekend and tested it today on multiple platforms. It has less monkeying around with the packet memory at the expense

[Wireshark-dev] working with header data

2011-10-14 Thread Ed Beroset
I've written a dissector for a protocol (ANSI C12.22) which employs cryptography for both assuring the integrity of the message (including the unencrypted header) and the confidentiality of the payload (by encrypting it). It uses what's called an AEAD (Authenticated Encryption with Associated

Re: [Wireshark-dev] working with header data

2011-10-14 Thread Ed Beroset
Guy Harris wrote: On Oct 14, 2011, at 6:03 AM, Ed Beroset wrote: There is a portion of the code called canonify_unencrypted_header(). In order to cryptographically process the ASN.1 components of the header, the data must be canonified. To do this, the dissector must process the pieces

Re: [Wireshark-dev] working with header data

2011-10-14 Thread Ed Beroset
Guy Harris wrote: On Oct 14, 2011, at 1:16 PM, Ed Beroset wrote: I did two earlier versions of the code that did something like that. One version used knowledge of what the tags are and recalculated the length based on the length of the tvb. The other one looked attempted to verify

Re: [Wireshark-dev] [Wireshark-commits] rev 39328: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-2dparityfec.c packet-acn.c packet-ancp.c packet-ansi_a.c packet-aodv.c packet-aruba-papi.c pa

2011-10-10 Thread Ed Beroset
Bill Meier wrote: On 10/10/2011 1:07 AM, Guy Harris wrote: FT_UINT_STRING For FT_UINT_STRING, what character encoding was used? FT_UTF_8 or FT_ASCII? Actually: for the FT_UINT_STRING cases I just changed TRUE/FALSE to ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN None of them had ENC_UTF_8/

[Wireshark-dev] updated patch file for bug 5531

2011-10-07 Thread Ed Beroset
Based on the current discussion about the use of the format field for proto_tree_add_item(), I have once again revised the patch file for Bug 5531 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5531 ). It has gotten a lot of votes and was originally submitted over nine months ago. Is

Re: [Wireshark-dev] modelines

2011-09-28 Thread Ed Beroset
Stephen Fisher wrote: Can modelines be at the top of a file? Yes, for vim (and I assume others). That's where I usually put them. The boiler plate copyright notice from doc/README.developer might be a good place to put it. I think that's a good approach. It may also be useful to think

Re: [Wireshark-dev] Can't compile latest trunk

2011-09-15 Thread Ed Beroset
Yosi Saggi wrote: Can't find: bison flex unzip wget ERROR: These application(s) are either not installed or simply can't be found in the current PATH: /cygdrive/c/Python26:/cygdrive/c/Program [...] For additional help, please visit:

Re: [Wireshark-dev] Problem compiling Wireshark 1.6.1

2011-08-29 Thread Ed Beroset
Guy Harris wrote: I think at least once I've had my path set incorrectly when building Wireshark on Windows, and getting the wrong command run - a Cygwin port of some UN*X command being run instead of some other Windows tool that had the same name but was a different tool. I think that's

[Wireshark-dev] how to check a field

2011-08-12 Thread Ed Beroset
I am working on refining a dissector and need to make sure the tree I'm passed actually points to the field I intend. This code may be called either before or after the packet is dissected. To do this I'm using code like this: if (PNODE_FINFO(tree)-hfinfo-id == hf_myproto_specialfield) {

Re: [Wireshark-dev] Traffic generation for ASN.1 PER

2011-08-10 Thread Ed Beroset
ANISH M wrote: I want to generate some ASN.1 PER traffic, is there any tools available for that? Please let me know. It's not clear exactly what you're asking. ASN.1 is a notation to express a protocol and PER is a means of encoding it. What's missing from your question is some particular

Re: [Wireshark-dev] CaveBear's Ethernet link is dead

2011-08-06 Thread Ed Beroset
Chris Maynard wrote: The tools/make-manuf script attempts to gather Ethernet codes from IEEE, but also from CaveBear at http://www.cavebear.com/CaveBear/Ethernet/Ethernet.txt, but unfortunately this link is dead. I could not find any meaningful contact information to Karl Auerbach on the site

Re: [Wireshark-dev] CaveBear's Ethernet link is dead

2011-08-06 Thread Ed Beroset
Joerg Mayer wrote: http://www.cavebear.com/archive/cavebear/Ethernet/Ethernet.txt If this file has been static for so long, how about integrating its content into our template file? That's probably the best idea, and then just have the link as documentation. In fact, if anybody's

Re: [Wireshark-dev] Makefile for wireshark dissector

2011-07-18 Thread Ed Beroset
sagar sg wrote: I am trying to compile my dissector independently by writing a single make file and Included some wireshark libraries. Can i do this or i need to compile it with wireshark s source code only?? If it's a plugin, and you've done things the way the other plugins are done,

Re: [Wireshark-dev] Problem with recommended Makefile.nmake

2011-07-14 Thread Ed Beroset
eymanm wrote: While building a plugin on Windows with Wireshark 1.6.0, I'm trying to follow directions provided in README.plugins. With the recommended content of \plugins\myudp\Makefile.nmake (attachment Recommended_Makefile.nmake) I'm getting compilation errors as shown in attachment

Re: [Wireshark-dev] Procedure to compile wireshark dissector on linux

2011-07-11 Thread Ed Beroset
sagar sg wrote: Hi, What is the procedure for compiling the wireshark dissector in linux. http://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBuildFirstTime.html#id521996 Ed ___ Sent via:Wireshark-dev mailing

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Ed Beroset
mman...@netscape.net wrote: While I see grouped protocols in the current epan\dissector directory, I thought maybe Profinet could have its own directory off of it if otherwise 'pollutes' the main dissector directory. I just see the plugins directory as Windows only, and I don't think any

Re: [Wireshark-dev] Finding duplicate (conflicting) value_string entries

2011-05-18 Thread Ed Beroset
Jeff Morriss wrote: Jakub Zawadzki wrote: On Wed, May 18, 2011 at 05:10:09PM +0100, Martin Mathieson wrote: On Wed, May 18, 2011 at 4:49 PM, Jakub Zawadzki nospam wrote: This patch is OK for me. I didn't measure, but it didn't noticibly add to the startup time This O(n^2) loop sucks a

[Wireshark-dev] climbing trees

2011-05-17 Thread Ed Beroset
(I posted this email twelve hours ago, but it hasn't shown up, so I'm resending. Sorry if it's a duplicate.) I've updated the patch for bug 5531 per comments from Jeff Morriss (thanks, Jeff!) but he brought up a comment I don't know how to address, so I thought I'd ask here. The comment is

  1   2   >