Re: [Wireshark-dev] Current Lua test failures on the buildbot

> -- Forwarded message -- > From: João Valverde > Date: Sun, Aug 7, 2016 at 2:39 PM > Subject: Re: [Wireshark-dev] Current Lua test failures on the buildbot > To: Developer support list for Wireshark > > Seriously,

Re: [Wireshark-dev] Trying to submit a patch

I just tried pushing with https, and it works. But of course you'll still need a Change-ID and such. What *exact* error message are you seeing? Also, why would you submit something new into master-1.12? We only do bug fixes for 1.12, not new features. New features go in master (i.e., 1.99.x).

Re: [Wireshark-dev] Wiretap changes for pcapng

BTW, I think you should propose these as new IDB options on the pcapng-format mailing list. They're obviously generally useful things to have in the file, no matter how wiretap is implemented. -hadriel On Mon, Aug 31, 2015 at 2:43 PM, Guy Harris wrote: > > We might also

Re: [Wireshark-dev] Wiretap changes for pcapng

On Mon, Aug 31, 2015 at 2:43 PM, Guy Harris wrote: > > For example, in bug 4221 > > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4221 > > Paul Long of Microsoft says that we discard interface information in Network > Monitor files *and* that, ideally, the NetMon

[Wireshark-dev] Wiretap changes for pcapng

Howdy, I'd like to modify tshark/wireshark/etc., to fully handle the pcapng file format. But to do that, wiretap needs to be changed in a non-trivial fashion. So instead of enumerating all the changes I propose to make to wiretap in an email, I've created a page on the wiki to describe my

Re: [Wireshark-dev] Problem writing a file dissector for vwr capture files

Did you add the magic info into the magic_files array in wiretap/mime_file.c? It looks like it's necessary. -hadriel On Sun, Aug 30, 2015 at 4:22 AM, Joerg Mayer jma...@loplof.de wrote: Hello, I'm trying to write a file dissector for the IxVeriWave (.vwr) capture files (without loosing the

Re: [Wireshark-dev] use of FT_PROTOCOL

On Tue, Aug 25, 2015 at 11:55 PM, Cody Doucette douce...@bu.edu wrote: I *think* (though I could easily be wrong), that the purpose of declaring a field of type FT_PROTOCOL is for cases where one protocol's dissector is about to invoke another protocol's dissector for encapsulated data, and

Re: [Wireshark-dev] The 'in' display filter operation

I believe just in the past month sometime, someone was talking about using the { } braces in the display filter to indicate fields grouped in the same application-layer PDU. So that for example a filter like { foo bar } would only match true if foo and bar were both true in the same PDU, as

Re: [Wireshark-dev] Bug in Wireshark Display filter engine caused by optimization of proto tree during dissect

To be clear, I think he meant: p_add_proto_data() (as discussed in the README.dissector section titled Per-packet information) -hadriel On Fri, Aug 21, 2015 at 10:44 AM, Anders Broman a.broma...@gmail.com wrote: Den 21 aug 2015 16:37 skrev Richard Sharpe realrichardsha...@gmail.com: On Fri,

Re: [Wireshark-dev] use of FT_PROTOCOL

On Thu, Aug 20, 2015 at 5:17 PM, Cody Doucette douce...@bu.edu wrote: I am trying to extend the XIP dissector to include a sub-protocol that should only come after an XIP header. I want it displayed at the top-level in the Packet Details pane, so adding this protocol *inside* of the XIP

[Wireshark-dev] Windows file wildcard support

Howdy, Can someone with a Windows build platform try building the current repo and run the mergecap test suite and figure out how to get the file wildcarding to work? The Windows buildbots are failing due to the test suite failing, and it's failing because the wildcard method doesn't seem to work

Re: [Wireshark-dev] Windows file wildcard support

Of Hadriel Kaplan Sent: den 20 augusti 2015 14:26 To: Developer support list for Wireshark Subject: [Wireshark-dev] Windows file wildcard support Howdy, Can someone with a Windows build platform try building the current repo and run the mergecap test suite and figure out how to get the file

[Wireshark-dev] removing mergecap -T option

Howdy, Due to some reported bugs and inconsistencies, I'm refactoring the capture file merging code in mergecap.c and file.c's cf_merge_files() - basically gutting them and putting most of the logic into a common merge_files() function in merge.c. While merging their function code logic, I

Re: [Wireshark-dev] removing mergecap -T option

But isn't that the purpose of editcap? I'm only talking about removing it from mergecap. -hadriel On Fri, Aug 14, 2015 at 12:26 PM, Pascal Quantin pascal.quan...@gmail.com wrote: Le 14 août 2015 6:18 PM, Hadriel Kaplan the.real.hadr...@gmail.com a écrit : Howdy, Due to some reported bugs

[Wireshark-dev] unicode replacement character in online docs

Anyone else seeing the unicode replacement character all over the online auto-generated docs? (user guide and developer guide) I don't recall having seen them there before, though maybe they've always been there. https://www.wireshark.org/docs/wsdg_html_chunked/index.html

[Wireshark-dev] Windows petri-dish unhappy

Howdy, The Windows petri-dish keeps failing in the middle of git fetching. It's failed 4 times in a row now, including for change 9769 which is basically just master. Looking at stackoverflow responses to similar issues, it seems some people have better luck using SSH instead of HTTPS (the

Re: [Wireshark-dev] Windows petri-dish unhappy

Oh right, looking at successful builds, it looks like git basically *always* fails once. Weird. -hadriel On Fri, Jul 24, 2015 at 11:28 AM, Graham Bloice graham.blo...@trihedral.com wrote: On 24 July 2015 at 16:18, Hadriel Kaplan the.real.hadr...@gmail.com wrote: Howdy, The Windows petri

Re: [Wireshark-dev] mailing list test

:) Martin On Wed, Jul 22, 2015 at 12:36 AM, Hadriel Kaplan the.real.hadr...@gmail.com wrote: Testing the list, since emails from my normal account aren't getting through apparently... -hadriel ___ Sent via:Wireshark

[Wireshark-dev] mailing list test

Testing the list, since emails from my normal account aren't getting through apparently... -hadriel ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:

[Wireshark-dev] Pcap-ng mailing list dead?

Howdy, Is the pcap-ng-for...@winpcap.org mailing list not working? I subscribed to the list and sent an email to it yesterday, which I have not seen back nor do the online archives show any messages on it since April. I was curious if this was a yahoo mail issue, since I use that and it fails

Re: [Wireshark-dev] Enabling/disabling ANY heuristic dissector

On Jul 13, 2015, at 9:32 AM, mman...@netscape.net wrote: I thought somebody might complain about something like this, but I was more focused on the Wireshark (packet) context menu, where I was less inclined to make changes. This however seems like a more valid use case to consider. My

Re: [Wireshark-dev] Enabling/disabling ANY heuristic dissector

On Jul 6, 2015, at 3:12 AM, Guy Harris g...@alum.mit.edu wrote: The use case for some but not other underlying protocols would appear to be traffic atop protocol X is rarely if ever mis-identified as being for protocol Z, so leave the heuristic on, but traffic atop protocol Y is often

[Wireshark-dev] odd Windows petri-dish failure

Anyone seen this type of petri-dish failure before, on the Windows petri-dish, and know what it means? Resolving deltas: 71% (3551/4999) Resolving deltas: 72% (3600/4999) error: index-pack died of signal 11 fatal: index-pack failed program finished with exit code 128

Re: [Wireshark-dev] Put back closing } accidentally removed in previous commit.

It was only failing on windows builds (it was inside a #ifdef Q_OS_WIN), so unless you built for windows, you wouldn’t have seen it. -hadriel On Jul 8, 2015, at 2:12 AM, Joerg Mayer jma...@loplof.de wrote: On Wed, Jul 08, 2015 at 05:18:06AM +, Wireshark code review wrote: URL:

Re: [Wireshark-dev] Preparing to Write Dissector for New IPv6 Destination Option

Try the attached. There is one caveat: it won’t work correctly if you have a IPv6 Destination Options Header with the PDM option but also other option types in that same header. Also, I have no idea if I did the time scaling correctly. BTW, there’s a bug in the draft: page 8 says for the

Re: [Wireshark-dev] Preparing to Write Dissector for New IPv6 Destination Option

get called Is there another way I should be doing this? Thanks, Nalini Elkins Inside Products, Inc. (831) 659-8360 www.insidethestack.com From: Hadriel Kaplan hadri...@yahoo.com To: Nalini Elkins nalini.elk...@insidethestack.com Cc: Developer

Re: [Wireshark-dev] Preparing to Write Dissector for New IPv6 Destination Option

If you can wait an hour, I’ll find some free time to look at your script in detail and see if I can send you an updated/corrected one. Some quick comments from skimming the script: The first error you’re seeing is because on line 34 (and lines after) you’re invoking the subtreeitem:add() with

Re: [Wireshark-dev] Enabling/disabling ANY heuristic dissector

My 2 cents: On Jul 5, 2015, at 11:32 PM, Guy Harris g...@alum.mit.edu wrote: Heuristic Protocol or Heuristic Dissector”? While “Dissector” makes more sense to me personally, do most users/IT-folks understand what a “Dissector” is? I think we’ve been conditioned to think of that word

Re: [Wireshark-dev] Enabling/disabling ANY heuristic dissector

On Jul 5, 2015, at 7:02 PM, mman...@netscape.net wrote: I uploaded a patch to Gerrit that allows enabling/disabling of any heuristic dissector (https://code.wireshark.org/review/9508/). Some comments about the patch (others are welcome to add more): 1. Not sure how to best express the

[Wireshark-dev] Enabling/disabling ANY heuristic dissector

Howdy, as part of the discussion for several recent bugs and gerrit changes to add preference settings for various protocols to enable/disable heuristic dissection, Michael Mann suggested we just provide a way to enabled/disable *any* heuristic dissector (i.e., for all of them, automagically in

Re: [Wireshark-dev] Netflow: How should Sequence Number field work?

Since Netflow v9 is a Cisco-defined protocol, their own docs should arguably trump the IETF RFC for their protocol. (personally I would read that RFC to mean the number of packets/frames, not number of flows) According to this:

Re: [Wireshark-dev] Buildbot Lua Init Tests

Yeah, I figured it would break Lua when I saw his changes on gerrit this morning, but he was doing the changes in little pieces so I thought I’d wait until some of it got into master before doing the necessary changes to wslua. -hadriel On Jul 3, 2015, at 9:57 PM, Evan Huus eapa...@gmail.com

Re: [Wireshark-dev] Buildbot Lua Init Tests

Should be fixed now, in master. -hadriel On Jul 3, 2015, at 11:20 PM, Hadriel Kaplan hadri...@yahoo.com wrote: Yeah, I figured it would break Lua when I saw his changes on gerrit this morning, but he was doing the changes in little pieces so I thought I’d wait until some of it got

[Wireshark-dev] v2.0 feature: Lua GUI support

Howdy, At Sharkfest during the closing session, Gerald mentioned some of the things he’d like to see completed before 2.0 goes out, so I thought I’d add my 2 cents for something I’d like to have done before 2.0 ships: bug 9845, which is to add to Qt the same GUI support for Lua plugins that GTK

Re: [Wireshark-dev] lua_bitop.c: MSVC2013 Code Analysis Warning

This appears to be a false positive. According to: https://msdn.microsoft.com/en-us/library/9t02bbsx.aspx ...the warning is generated because If the shift overflowed the 32-bit value, bits are lost. But that's what is actually intended in bitop (it's a 32-bit bit operations library). I

Re: [Wireshark-dev] lua_bitop.c: MSVC2013 Code Analysis Warning

I'll take a look. -hadriel On Feb 7, 2015, at 4:54 PM, Bill Meier wme...@newsguy.com wrote: Hadriel: MSVC2013 Code Analysis is giving the following warning: ...\ws-git\epan\wslua\lua_bitop.c(116) : warning C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit

Re: [Wireshark-dev] error initializing git review

On Feb 5, 2015, at 1:02 PM, Ed Beroset bero...@mindspring.com wrote: Shouldn't it be https://bero...@code.wireshark.org/wireshark/tools/hooks/commit-msg What does git remote -v show? originhttps://bero...@code.wireshark.org/review/wireshark (fetch) origin

[Wireshark-dev] checkfiltername.pl failures in LDAP

Howdy, A small change I made to asn1/ldap/packet-ldap-template.c has triggered the pre-commit's invoked checkfiltername.pl verification script to fail, with the failures at the bottom of this email. This is causing the petri-dish to fail. The comments in checkfiltername.pl state that any

Re: [Wireshark-dev] JSON as mime type

It doesn't look like that's enough. A MIME file type is read by wiretap/mime-file.c, and it appears to look for a magic string at the beginning of the file to decide it's a mime file type. Since a json file won't match any of those magic strings, the file won't be opened as a mime file type.

Re: [Wireshark-dev] [Wireshark-commits] master 1e1d96f: Modify the errorcode defenition to suit ANSI MAP, this is (probably) OK as ANSI MAP is currently the only user of ANSI TCAP. Bug: 6112

We could put a check for that in a post-commit hook, either in commit-msg or post-commit hook - if the check is in commit-msg we could even auto-fix it for the developer, but the hook would have to include the change-id creation. (i.e., added to the existing commit-msg hook) -hadriel On Jan

Re: [Wireshark-dev] Trying to write a LUA dissector for wireshark. How's the support?

There is still active development. The docs, on the other hand, appear to have some issues, because there were two big changes in the past several months: 1) the LUA stuff was moved from the User's Guide to the Developer's Guide 2) the documentation system for Lua was changed from perl-XML-HTML

Re: [Wireshark-dev] Trying to write a LUA dissector for wireshark. How's the support?

There is still active development. The docs, on the other hand, appear to have some issues, because there were two big changes in the past several months: 1) the LUA stuff was moved from the User's Guide to the Developer's Guide 2) the documentation system for Lua was changed from perl-XML-HTML

[Wireshark-dev] Protocol stats list in GUI

With the addition of another protocol statistic [1], I noticed the list of the various stats is growing long and ugly in the Statistics menu of the GUIs (both GTK and Qt). It's also a jumble of generic things such as 'Flow Graph' and 'Compare...', and protocol-specific stats. And some of those

Re: [Wireshark-dev] How can Wireshark improve

On Apr 19, 2014, at 3:48 PM, Guy Harris g...@alum.mit.edu wrote: So perhaps there should be a way to have a display filter show related packets in addition to packets that match the packet-matching expression. However, there are multiple flavors of related, and sometimes you might want

Re: [Wireshark-dev] Header field with scaling factor/units?

On Apr 9, 2014, at 7:16 PM, Guy Harris g...@alum.mit.edu wrote: We might want to add syntax so that, for a field with a scale factor of 0.5, we might have wlan.rate = raw(22) or wlan.rate = 11 (no, that was not a randomly-chosen field example :-)). Other suggestions

Re: [Wireshark-dev] TCP and IP reassembling code

On Apr 9, 2014, at 12:09 PM, Aaron Lewis the.warl0ck.1...@gmail.com wrote: Hi Where can I find the TCP and IP reassembling code in Wireshark, epan/reassemble.h epan/reassemble.c Is that re-usable? Yes, it's used by a bunch of dissectors. (grep for 'reassembly_table_init') -hadriel

Re: [Wireshark-dev] No tvb_get for string-encoded numbers?

me find one bug in packet-sdp.c. :) -hadriel On Apr 4, 2014, at 5:01 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: On Apr 4, 2014, at 4:04 PM, Guy Harris g...@alum.mit.edu wrote: On Apr 4, 2014, at 7:30 AM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: I might be overlooking

Re: [Wireshark-dev] No tvb_get for string-encoded numbers?

On Apr 4, 2014, at 4:04 PM, Guy Harris g...@alum.mit.edu wrote: Likewise, it’s not clear if there’s a way to define a protocol field that is encoded as a string in the packet but is internally a uint8/16/32/64 (e.g., for filtering purposes, val_string lookup, etc.). For example such that

Re: [Wireshark-dev] overriding dissector for port 8080

On Apr 4, 2014, at 9:56 AM, John Dill john.d...@greenfieldeng.com wrote: I also noticed a disabled_protos.[ch], so maybe there is a feature to disable other protocols. Is there a feature that could be used to hide protocols I don't need in the Filter Expression (to reduce the list to

[Wireshark-dev] test

please ignore this email - just testing, because I can’t seem to send new non-reply emails to this list… ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:

[Wireshark-dev] No tvb_get for string-encoded numbers?

Hi, I might be overlooking something, but I don’t see a tvb_get_* function to get a uint8/16/32/64 that was encoded as a ascii or utf-8 string in the packet. Is there such a thing? Instead, it seems the dissectors that deal with string messages do a tvb_get_string_enc() or tvb_format_text(),

Re: [Wireshark-dev] overriding dissector for port 8080

On Apr 4, 2014, at 10:43 AM, John Dill john.d...@greenfieldeng.com wrote: The Filter Expression dialog is the best place in Wireshark to locate the data elements they are looking for, so it was mentioned as a nice to have”. Oh well if it’s just the dialog, why not just disable the other

Re: [Wireshark-dev] No tvb_get for string-encoded numbers?

On Apr 4, 2014, at 4:04 PM, Guy Harris g...@alum.mit.edu wrote: On Apr 4, 2014, at 7:30 AM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: I might be overlooking something, but I don’t see a tvb_get_* function to get a uint8/16/32/64 that was encoded as a ascii or utf-8 string

Re: [Wireshark-dev] checkhf.pl fails only on pre-commit hook

On Apr 4, 2014, at 10:36 PM, mman...@netscape.net wrote: I've taken the pre-commit hook file provided in \tools and put it in my git hooks folder. However, whenever I commit something (I've focused mostly on dissector patches and they all fail this way), it fails with Search pattern not

Re: [Wireshark-dev] checkhf.pl fails only on pre-commit hook

On Apr 4, 2014, at 11:26 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: I barely know perl, but checkhf.pl line 564 does indeed look bogus to me. (the double slashes are what it thinks is starting a regex search pattern that's not terminated I believe) Actually, no it's fine. I don't

Re: [Wireshark-dev] checkhf.pl fails only on pre-commit hook

... and at the same time get the bonus of re-using common character syntax used for completely different purposes; otherwise what fun would Perl be if it were easy to debug?) -hadriel On Apr 4, 2014, at 11:35 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: On Apr 4, 2014, at 11:26 PM, Hadriel

Re: [Wireshark-dev] checkhf.pl fails only on pre-commit hook

, $h, $k; } It's infinitesimally worse performance, but it's perl so that hardly matters. ;) -hadriel On Apr 4, 2014, at 11:42 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: What version of Perl do you have? I think that line 564's logical-or only became available in Perl 5.10

Re: [Wireshark-dev] checkhf.pl fails only on pre-commit hook

Ugh, forgot the defined. So this: for my $k (sort keys %{$href}) { my $h = defined($href-{$k}) ? $href-{$k} : undef; printf %-40.40s %5.5s %s\n, $title, $h, $k; } On Apr 4, 2014, at 11:49 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: Change this at line 563

Re: [Wireshark-dev] Lua Dissector lua fake item

Doesn’t happen for me, on Windows-XP (sorry I don’t have a newer windows to try it on right now - my main machine’s a Mac). If you can’t show your real script, can you try downloading the “dissector.lua one on the script examples wiki page, along with the dns_port.pcap file, and try those to

Re: [Wireshark-dev] Lua Dissector lua fake item

Do you have the “Display hidden protocol items” enabled in your Protocol preferences for some reason? That would probably cause that “fake lua item” to be displayed. -hadriel On Apr 3, 2014, at 11:46 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: Doesn’t happen for me, on Windows-XP

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

On Apr 2, 2014, at 6:07 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: In that case I'd vote no: Redhat EL 6 comes with 5.1.4 and it probably has a long lifetime ahead of it. How hard/painful would it be to install Lua 5.2.x? (I don't know the answer - just asking) It's a tiny little

Re: [Wireshark-dev] What about backporting fixes to older releases with the new workflow?

On Mar 31, 2014, at 5:17 PM, Gerald Combs ger...@wireshark.org wrote: For each cherry-pick the release notes need to be updated with any bug fixes, protocol updates and (if needed) an advisory. This can be done by amending or with a separate commit. Huh, I did not know that. Do we need to

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

On Mar 31, 2014, at 2:55 PM, Gerald Combs ger...@wireshark.org wrote: Yes exactly. Right now our binaries seem to come from http://luabinaries.sourceforge.net/download.html (Gerald will confirm). That's correct. The Lua development teams is one of the few that provide Windows libraries

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

On Mar 31, 2014, at 2:05 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: Do you mean Wireshark would no longer compile/run if the Lua version was 5.2? Yes, that would be the ultimate goal. That way someone writing a Lua script and wants to share it with others doesn't have to worry

[Wireshark-dev] Can we move to Lua 5.2.3 only?

Howdy, Is there any reason not to make wireshark 1.11.x and beyond only use Lua 5.2? Right now the automated builds are getting built with 5.1. There's very little difference to end users (i.e., older scripts should continue to work)... but for the C-code it's a lot more painful to have to

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

: +1 On Fri, Mar 28, 2014 at 11:29 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: Howdy, Is there any reason not to make wireshark 1.11.x and beyond only use Lua 5.2? Right now the automated builds are getting built with 5.1. There's very little difference to end users

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

, and I use MacPorts). -hadriel On Mar 28, 2014, at 11:34 AM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: The bugs are listed here: http://www.lua.org/bugs.html 5.2.3 was only released this past December, but 5.2.2 has been out since 2012. What do you mean by we have a 5.2.1 library

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

On Mar 28, 2014, at 11:42 AM, Pascal Quantin pascal.quan...@gmail.com wrote: 2014-03-28 16:34 GMT+01:00 Hadriel Kaplan hadriel.kap...@oracle.com: The bugs are listed here: http://www.lua.org/bugs.html 5.2.3 was only released this past December, but 5.2.2 has been out since 2012. What

Re: [Wireshark-dev] (no subject)

Start here: http://wiki.wireshark.org/Development https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob;f=doc/README.dissector https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob;f=doc/README.developer -hadriel On Mar 28, 2014, at 8:49 PM, khemis haythem

Re: [Wireshark-dev] How to include new dissector wrriten in Lua (pure Lua) to Wireshark

On Mar 26, 2014, at 1:29 AM, Nakayama Kenjiro nakayamakenj...@gmail.com wrote: Recently I wrote new dissector by pure Lua[1] and I am thinking about submitting a request to include the dissector to Wireshark. But as far as I checked upstream, there are no pure Lua dissector yet. Right, none

Re: [Wireshark-dev] How to get wireshark's plugins path with lua?

On Mar 25, 2014, at 11:00 AM, Nakayama Kenjiro nakayamakenj...@gmail.com wrote: I want to get the wireshark's plugins path. eg) /usr/local/lib/wireshark/plugins/1.11.3 That would be the global plugins path, yes? Not the personal plugins path. According to [1], there are no function

Re: [Wireshark-dev] Viewing code in Gerrit

On Mar 24, 2014, at 9:21 AM, Evan Huus eapa...@gmail.com wrote: On Mon, Mar 24, 2014 at 8:55 AM, mman...@netscape.net wrote: I can't consistently view the code of patches submitted to Gerrit (the Side-by-Side or Unified links). I've tried on IE8 and 9 as well as Firefox v28 (all on

Re: [Wireshark-dev] Viewing code in Gerrit

On Mar 24, 2014, at 11:26 AM, Bill Meier wme...@newsguy.com wrote: On 3/24/2014 9:21 AM, Evan Huus wrote: In summary: the diff is computed locally in javascript, and seems to be worse than O(n) on the size of the underlying file; viewing the diff for any file 1k lines may be slow, but if

Re: [Wireshark-dev] Clang code analysis buildbot

On Mar 21, 2014, at 5:31 PM, Guy Harris g...@alum.mit.edu wrote: On Mar 21, 2014, at 2:18 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: How long does the clang code analysis buldbot You mean the beat the living hell out of Wireshark to look for bugs in many different ways buildbot

Re: [Wireshark-dev] [PATCH] trivial: typo in a comment

Heh, I'm sure you'll find plenty of spelling errors in Lua test-script comments. :) But you don't have to cc this mailing list with those - just submit a bug in bugzilla, or (even better) submit a patch to gerrit/git. -hadriel On Mar 22, 2014, at 12:05 PM, Toralf Förster

Re: [Wireshark-dev] Clang code analysis buildbot

Right, understood. And if I'd actually carefully read the bug comments fuzzbot submits, I would have noticed the './tshark -nVxr' at the bottom of them. :) -hadriel On Mar 22, 2014, at 1:54 PM, Guy Harris g...@alum.mit.edu wrote: On Mar 22, 2014, at 8:41 AM, Hadriel Kaplan hadriel.kap

[Wireshark-dev] Clang code analysis buildbot

How long does the clang code analysis buldbot run usually take? I ask because it appears to have been running for a lng time. -hadriel ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:

[Wireshark-dev] Buildbot crash bugs

Howdy, What's the protocol (for lack of a better term) for how the Buildbot crash bugs get handled? Are there specific core developers who handle them, or is it whomever wants to fix it please do so? I ask because there've been a bunch of them lately which look like dups of bug 9909 (it

Re: [Wireshark-dev] Buildbot crash bugs

On Mar 20, 2014, at 8:02 PM, Guy Harris g...@alum.mit.edu wrote: It's in packet-ieee80211.c, which is impressively big. (25k lines!) So is IEEE Std 802.11-2012. (2k pages!) :-) To be fair, IEEE Std 802.3-2012 is 634+780+358+732+844+400 = 3748 pages, so it's about 1000 more pages (2k is

Re: [Wireshark-dev] [Wireshark-commits] master 04c39bb: Add Lua heuristic dissector support

On Mar 14, 2014, at 5:06 PM, Bill Meier wme...@newsguy.com wrote: Re; doc/README.heuristic | 10 +-- + * but ONLY do this if your heuristic sits directly on top of UDP or TCP (ie, you did heur_dissector + * otherwise you'll be overriding the dissector that

[Wireshark-dev] Is git-review safe?

So a funny thing happened while using 'git review' tonight. I was in a local branch named aruba_erm_radio, did my changes, did git commit, and then did git review. Inside my commit message, in the second paragraph, I mentioned that it resolves an enhancement bug 9880. For some reason,

Re: [Wireshark-dev] Regarding Plugin attachment

So why do a plugin? Just write a normal new dissector. Regardless, the doc to read is this: doc/README.dissector That explains a lot, in detail; and of course you should also look at some existing packet-* files in epan/dissectors. For UDP, packet-stun.c or packet-ntp.c are a relatively

[Wireshark-dev] GIT tutorials (was: Re: Fix bug in GSM MAP, have problems with GIT)

On Mar 11, 2014, at 1:18 PM, Christopher Maynard christopher.mayn...@gtech.com wrote: If possible, add some information/basic steps on a few more topics as well? For example: 1) How do you undo a commit, or undo part of a commit? You can reset the head, but I really think going there

[Wireshark-dev] Git-review (was: Re: Fix bug in GSM MAP, have problems with GIT)

On Mar 11, 2014, at 1:59 PM, Evan Huus eapa...@gmail.com wrote: http://wiki.wireshark.org/Development/SubmittingPatches as a very bare-bones tutorial. Hopefully others will expand it as necessary. I've tried to answer a few of these with a new revision of the page. I see you have the

Re: [Wireshark-dev] Git-review (was: Re: Fix bug in GSM MAP, have problems with GIT)

On Mar 11, 2014, at 3:01 PM, Guy Harris g...@alum.mit.edu wrote: On Mar 11, 2014, at 11:18 AM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: I see you have the 'pip install git-review' stuff on that page... fwiw, I've never gotten git-review to work on my Mac. I got it installed

Re: [Wireshark-dev] GIT tutorials (was: Re: Fix bug in GSM MAP, have problems with GIT)

On Mar 11, 2014, at 5:15 PM, Guy Harris g...@alum.mit.edu wrote: Perhaps we should have a page on some wireshark.org where a user can enter some identifier for an automated build and an SHA hash for a commit and find out whether that build has that commit, and perhaps also say take me to

Re: [Wireshark-dev] GIT tutorials (was: Re: Fix bug in GSM MAP, have problems with GIT)

On Mar 11, 2014, at 5:38 PM, Evan Huus eapa...@gmail.com wrote: On Tue, Mar 11, 2014 at 5:34 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: Googling around a bit for this issue - because other apps must have this same problem and their users - shows people either creating a ton

Re: [Wireshark-dev] GIT tutorials

On Mar 11, 2014, at 8:08 PM, Evan Huus eapa...@gmail.com wrote: On Tue, Mar 11, 2014 at 7:12 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: Any way we could have the v1.11.0-rc1-1917 portion automatically put into the gerrit review once it's been cherry-picked into master/master-x.x

Re: [Wireshark-dev] GIT tutorials

On Mar 11, 2014, at 6:42 PM, Gerald Combs ger...@wireshark.org wrote: Would `git describe` suit your needs? $ git describe v1.11.3-rc1-1917-gd3b8084 The current tag is v1.11.3-rc1. There are 1917 commits between v1.11.3-rc1 and gd3b8084. $ git describe --match v1.11.0-rc1

Re: [Wireshark-dev] Fix for Windows build.

Sorry about that - I uploaded that commit before I made it a habit to turn on extra compiler warnings on my Mac OSX. :( It's surprising, though, since the files which caused you and others issues are from a very-widely-used Lua library that's been around for years. You'd think they'd have

Re: [Wireshark-dev] [Wireshark-commits] master 579e7e1: Wireshark: Add option to choose format type of capture file

Actually it's more like the 'short_name' field in that file_type_subtybe struct, but not exactly - the open_info ones are captialized whereas the file_type_subtybe 'short_name' ones are lower-case. But in my opinion they should be not only the same exact name strings, but inside just one

Re: [Wireshark-dev] [Wireshark-commits] master 579e7e1: Wireshark: Add option to choose format type of capture file

BTW, is changing the wtap_register_open_info() function prototype/ABI again soon going to cause you problems? I ask because it changes again, with an additional argument, in here: https://code.wireshark.org/review/#/c/431/ The additional argument is for whether the wiretap reader being

[Wireshark-dev] Good book on Qt?

A bit off-topic, but since I'm asking because Wireshark uses it and I want to grok it for Wireshark... Can anyone recommend a good book on Qt GUI programming? A search on Amazon and stackoverflow and other usual sites came up with lots of hits, but mostly for outdated books. And the docs on

Re: [Wireshark-dev] Conversation handling for UDP

... move along... -hadriel On Mar 4, 2014, at 10:06 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: Howdy, I've been looking into bug 9835, which involves SIP+SDP setting up RTP conversations/flows. I've found 3 bugs so far in the relevant code areas, but the last one I'm stuck on looks

[Wireshark-dev] Conversation handling for UDP

Howdy, I've been looking into bug 9835, which involves SIP+SDP setting up RTP conversations/flows. I've found 3 bugs so far in the relevant code areas, but the last one I'm stuck on looks like it's by design. It looks like the UDP dissector creates a addr:port-specific conversation for new

Re: [Wireshark-dev] Gerrit Stuck?

Look at: https://code.wireshark.org/review/#/c/420/ It's saying it does NOT have the verified flag, even though there's a comment saying you set it. And it has a whole bunch of patches showing, even though I did not submit all of those. Weird. It may be fubar. -hadriel On Feb 27, 2014,

Re: [Wireshark-dev] Gerrit Stuck?

Gerrit-PatchSet: $patchSet.patchSetId Gerrit-Project: wireshark Gerrit-Branch: master Gerrit-Owner: Hadriel Kaplan hadri...@yahoo.com Gerrit-Reviewer: Evan Huus eapa...@gmail.com On Feb 27, 2014, at 12:58 PM, Evan Huus eapa...@gmail.com wrote: I marked the verified flag and it still didn't work. I

Re: [Wireshark-dev] Gerrit Stuck?

://gerrit-review.googlesource.com/#/c/53080/2 Hopefully it will be part of 2.8.2. On 2/27/14 10:06 AM, Hadriel Kaplan wrote: Look at: https://code.wireshark.org/review/#/c/420/ It's saying it does NOT have the verified flag, even though there's a comment saying you set it. And it has

Re: [Wireshark-dev] Gerrit Stuck?

changes 375 and 420? I'm not sure I can fix the problem on the server end. A fix for the problem has been merged in Gerrit: https://gerrit-review.googlesource.com/#/c/53080/2 Hopefully it will be part of 2.8.2. On 2/27/14 10:06 AM, Hadriel Kaplan wrote: Look at: https

Re: [Wireshark-dev] Gerrit Stuck?

Scratch that - looks like you did it already. Well that was exciting. :) -hadriel On Feb 27, 2014, at 3:35 PM, Hadriel Kaplan hadriel.kap...@oracle.com wrote: Actually shouldn't it be Evan who abandons them? I assumed the cherry-pick mode of gerrit meant he was cherry-picking my branch

  1   2   >