[Wireshark-dev] Defect in reassembling TCP stream. Bug and Patch are available on Bugzilla.

2014-03-28 Thread Pavel Karneliuk
Regards, Pavel Karneliuk Senior Software Engineer EPAM Systems Minsk office, Belarus ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe

Re: [Wireshark-dev] Defect in reassembling TCP stream. Bug and Patch are available on Bugzilla.

2014-03-28 Thread Pavel Karneliuk
of sequence numbers. There are some places in check_fragments() and reassemble_tcp() with a naive comparison of sequence numbers: 369: if( sequence seq[src_index] ) { I think, they should be replaced with macros from packet-tcp.h 51-55. At least to be uniformly. Best Regards, Pavel Karneliuk Senior

Re: [Wireshark-dev] Defect in reassembling TCP stream. Bug and Patch are available on Bugzilla.

2014-03-28 Thread Pavel Karneliuk
and Patch are available on Bugzilla. Le 28 mars 2014 16:52, Pavel Karneliuk pavel_karnel...@epam.commailto:pavel_karnel...@epam.com a écrit : Hi Pascal, thank you for answer. I saw your commits to follow.c and I hoped for your reply. 450:if( newseq seq[idx] ) { I think - Yes. It compares