Re: [Wireshark-dev] Using C++ for a test tool linking to wireshark

[Graham Bloice]

On 9 August 2017 at 20:21, Guy Harris  wrote:

> On Aug 9, 2017, at 12:01 PM, Sultan, Hassan  wrote:
>
> > Awesome :) so no concerns about C++ 11 then ?
>
> There's "concerns about C++" and there's "concerns about C++ 11".
>
> The Wireshark Developer's Guide:
>
> https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin3
> 2.html#ChSetupMSVC
>
> currently *recommends* Microsoft Visual Studio 2013 Community Edition, and
> notes that we use that version to build the releases, but also mentions VS
> 2010.  VS 2010 supports some, but not all, features in the C++11 core
> language specification:
>
>
2.4 and master are now built with VS2015, so we need some doc updates.
Master might well move to VS2017 this year.  Personally I wouldn't worry
about any VS pre 2013.



> https://msdn.microsoft.com/en-us/library/hh567368(v=vs.120).aspx
>
> GCC 4.8.1 is claimed to be feature-complete for C++ 11:
>
> https://gcc.gnu.org/projects/cxx-status.html#cxx11
>
> "Clang 3.3 and later implement all of the ISO C++ 2011 standard.":
>
> https://clang.llvm.org/cxx_status.html
>
> but "By default, Clang builds C++ code according to the C++98 standard,
> with many C++11 features accepted as extensions. You can use Clang in C++11
> mode with the -std=c++11 option."
>
> I don't know which versions of various vendor compilers for UN*X (Oracle
> Studio, IBM XLC++ or whatever they call it, HP C++) support what versions
> of the C++ standard; this page:
>
> http://en.cppreference.com/w/cpp/compiler_support
>
> "is maintained as best-effort and may lag behind most recent compiler
> releases" but might be worth checking.
>
> If we were to require C++ 11 support, we might need to change the autoconf
> script or the CMake files to ensure that we use flags such as -std=C++11
> when building C++ code.
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscr
> ibe
>



-- 
Graham Bloice
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Using C++ for a test tool linking to wireshark

[Guy Harris]

On Aug 9, 2017, at 12:01 PM, Sultan, Hassan  wrote:

> Awesome :) so no concerns about C++ 11 then ?

There's "concerns about C++" and there's "concerns about C++ 11".

The Wireshark Developer's Guide:


https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html#ChSetupMSVC

currently *recommends* Microsoft Visual Studio 2013 Community Edition, and 
notes that we use that version to build the releases, but also mentions VS 
2010.  VS 2010 supports some, but not all, features in the C++11 core language 
specification:

https://msdn.microsoft.com/en-us/library/hh567368(v=vs.120).aspx

GCC 4.8.1 is claimed to be feature-complete for C++ 11:

https://gcc.gnu.org/projects/cxx-status.html#cxx11

"Clang 3.3 and later implement all of the ISO C++ 2011 standard.":

https://clang.llvm.org/cxx_status.html

but "By default, Clang builds C++ code according to the C++98 standard, with 
many C++11 features accepted as extensions. You can use Clang in C++11 mode 
with the -std=c++11 option."

I don't know which versions of various vendor compilers for UN*X (Oracle 
Studio, IBM XLC++ or whatever they call it, HP C++) support what versions of 
the C++ standard; this page:

http://en.cppreference.com/w/cpp/compiler_support

"is maintained as best-effort and may lag behind most recent compiler releases" 
but might be worth checking.

If we were to require C++ 11 support, we might need to change the autoconf 
script or the CMake files to ensure that we use flags such as -std=C++11 when 
building C++ code.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Using C++ for a test tool linking to wireshark

[Guy Harris]

On Aug 9, 2017, at 11:48 AM, Sultan, Hassan via Wireshark-dev 
 wrote:

> I’ve noticed everything in Wireshark seems to be in C89

...except for the files in ui/qt and subdirectories thereof, and 
wireshark-qt.cpp in the top-level directory.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Using C++ for a test tool linking to wireshark

[Sultan, Hassan via Wireshark-dev]

Hi,

I've noticed everything in Wireshark seems to be in C89 , which I guess is 
understandable for portability reasons.

I'm curious whether you guys would be okay with having an external test tool be 
in C++ 11 though (think of something like tshark or rawshark but much 
smaller/simpler and for test purposes) , this would limit the platforms where 
that tool can be compiled, but would also make development for it a lot more 
comfortable.

I can rewrite it to be in C89 if needed, but if I can save myself some work, 
that would be nice :)

Thanks,

Hassan
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe