Re: [Wireshark-dev] [Wireshark-commits] master 7f3d97c: Include the gnm dissector.
Den 1 aug 2014 01:23 skrev Guy Harris g...@alum.mit.edu: On Jul 31, 2014, at 3:21 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: The commit message there says it was removed because it was never used. Never used in what sense? Nobody ever read a capture file that used it? I created the dissector while doing other ITU asn1 dissectors in the hope it would be useful, I have never seen a trace whit it or seen a bug report so I removed it from the makefile but left the files to give a grace period before removing it completely. The same reasoning goes for the asn1 plugin. If it were to be still used ideally it should be rewritten to use the ber accessors. But I think we now provide adequate tools to convert asn1 documents to c dissectors obsoleted the plugin. Regards Anders Or nothing will ever use the OIDs for which it registers? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master 7f3d97c: Include the gnm dissector.
On Jul 31, 2014, at 3:21 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: The commit message there says it was removed because it was never used. Never used in what sense? Nobody ever read a capture file that used it? Or nothing will ever use the OIDs for which it registers? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master 7f3d97c: Include the gnm dissector.
On 07/31/14 04:27, Wireshark code review wrote: URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7f3d97c669970538158d01d33ed5d494477d2378 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master Repository: wireshark Commits: 7f3d97c by Guy Harris (g...@alum.mit.edu): Include the gnm dissector. This reverts r54561/b22d9ab940489f615c3968678a0d01df589d3045 (and only partially: the dissector is still removed from cmake.) The commit message there says it was removed because it was never used. (I noticed this only because the release notes for 1.12.0 point out that the dissector was removed.) ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
