Re: [Wireshark-dev] Assigned reviewers
> > >> Do you mean assignee? I guess so, but I'd like to clear it, since the >> reviewer and assignee were separate in Gerrit. >> > > No I really meant reviewer as I was considering the assignee as the person > that will ultimately schedule the merge. You can have more than one > reviewer. But I'm open to any workflow we might define. > > Oh, I missed it. I always forget that gitlab.com runs gitlab EE, while I am more used to gitlab CE, which sometimes has less features. It was introduced in 13.5, enabled by default in 13.7: https://docs.gitlab.com/ee/user/project/merge_requests/getting_started#reviewer Good to know, I'll use it to ask for reviews, thanks. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Assigned reviewers
Le mer. 6 janv. 2021 à 11:26, Dario Lombardo a écrit : > > > On Wed, Jan 6, 2021 at 9:38 AM Pascal Quantin > wrote: > >> Hi Jonathan, >> >> Le mer. 6 janv. 2021 à 05:39, Jonathan Nieder a >> écrit : >> >>> Hi wiresharks, >>> >>> Context: >>> https://gitlab.com/wireshark/wireshark/-/merge_requests/1313#note_478706594 >>> >>> In Gerrit times, a person could add someone as a reviewer to a change >>> to request review, the reviewer could remove themselves if they were >>> unavailable, and so on. What is the equivalent in the GitLab world? >>> More concretely: >>> >>> - when a change is ready to review, how do I say so? >>> >> >> All opened threads are resolved and the submitter can add a comment to >> ping us. A reviewer can be explicitly added in the right column of the >> Gitlab GUI >> > > Do you mean assignee? I guess so, but I'd like to clear it, since the > reviewer and assignee were separate in Gerrit. > No I really meant reviewer as I was considering the assignee as the person that will ultimately schedule the merge. You can have more than one reviewer. But I'm open to any workflow we might define. > >> >> - if a review seems to be stalled, what's the best place to poke? >>> >> >> Writing a comment in the MR; we are almost all volunteers doing this on >> our spare time so sometimes real life collides and a given change can get >> out of the radar >> >> - if I would like to review a change, how should I signal interest? >>> >> >> Everybody is free to put comments in a MR >> >> - what happens when a change has been approved and it is time to merge >>> it? Where can I read about the bot that does that? >>> >> >> One of the core developer approves the change and schedules it for merge >> >> > The Core devels are able to rebase and merge a MR. However the race for > merge with other MRs could make the merge harder. That's why we can assign > the MR to the bot that automatically rebases the change until the merge > actually happens. But it's not a must. > As only core developers can do this operation, that's what I meant when saying "schedule for merge" but did not enter into the details. Thanks for clarifying it. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Assigned reviewers
On Wed, Jan 6, 2021 at 9:38 AM Pascal Quantin wrote: > Hi Jonathan, > > Le mer. 6 janv. 2021 à 05:39, Jonathan Nieder a > écrit : > >> Hi wiresharks, >> >> Context: >> https://gitlab.com/wireshark/wireshark/-/merge_requests/1313#note_478706594 >> >> In Gerrit times, a person could add someone as a reviewer to a change >> to request review, the reviewer could remove themselves if they were >> unavailable, and so on. What is the equivalent in the GitLab world? >> More concretely: >> >> - when a change is ready to review, how do I say so? >> > > All opened threads are resolved and the submitter can add a comment to > ping us. A reviewer can be explicitly added in the right column of the > Gitlab GUI > Do you mean assignee? I guess so, but I'd like to clear it, since the reviewer and assignee were separate in Gerrit. > > - if a review seems to be stalled, what's the best place to poke? >> > > Writing a comment in the MR; we are almost all volunteers doing this on > our spare time so sometimes real life collides and a given change can get > out of the radar > > - if I would like to review a change, how should I signal interest? >> > > Everybody is free to put comments in a MR > > - what happens when a change has been approved and it is time to merge >> it? Where can I read about the bot that does that? >> > > One of the core developer approves the change and schedules it for merge > > The Core devels are able to rebase and merge a MR. However the race for merge with other MRs could make the merge harder. That's why we can assign the MR to the bot that automatically rebases the change until the merge actually happens. But it's not a must. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Assigned reviewers
Hi Jonathan, Le mer. 6 janv. 2021 à 05:39, Jonathan Nieder a écrit : > Hi wiresharks, > > Context: > https://gitlab.com/wireshark/wireshark/-/merge_requests/1313#note_478706594 > > In Gerrit times, a person could add someone as a reviewer to a change > to request review, the reviewer could remove themselves if they were > unavailable, and so on. What is the equivalent in the GitLab world? > More concretely: > > - when a change is ready to review, how do I say so? > All opened threads are resolved and the submitter can add a comment to ping us. A reviewer can be explicitly added in the right column of the Gitlab GUI - if a review seems to be stalled, what's the best place to poke? > Writing a comment in the MR; we are almost all volunteers doing this on our spare time so sometimes real life collides and a given change can get out of the radar - if I would like to review a change, how should I signal interest? > Everybody is free to put comments in a MR - what happens when a change has been approved and it is time to merge > it? Where can I read about the bot that does that? > One of the core developer approves the change and schedules it for merge Best regards, Pascal. > I checked docbook/wsdg_src/WSDG_chapter_sources.adoc[1] as a first > guess of where to find these answers and didn't get a clear sense of > things. I'll be happy to contribute a summary of what I learn there. > > Thanks for your kind help in reviews while we've been guessing. :) > > Thanks, > Jonathan > > [1] https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Assigned reviewers
Hi wiresharks, Context: https://gitlab.com/wireshark/wireshark/-/merge_requests/1313#note_478706594 In Gerrit times, a person could add someone as a reviewer to a change to request review, the reviewer could remove themselves if they were unavailable, and so on. What is the equivalent in the GitLab world? More concretely: - when a change is ready to review, how do I say so? - if a review seems to be stalled, what's the best place to poke? - if I would like to review a change, how should I signal interest? - what happens when a change has been approved and it is time to merge it? Where can I read about the bot that does that? I checked docbook/wsdg_src/WSDG_chapter_sources.adoc[1] as a first guess of where to find these answers and didn't get a clear sense of things. I'll be happy to contribute a summary of what I learn there. Thanks for your kind help in reviews while we've been guessing. :) Thanks, Jonathan [1] https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
