Hi Pavel,
Can you use the revised workflow and submit the change to Gerrit. Any
discussion on the proposed change will take place in the Gerrit Review
process.
Workflow info can be found here:
http://wiki.wireshark.org/Development/Workflow
On 28 March 2014 15:06, Pavel Karneliuk
Hello,
At first, thank you all for Wireshark. It is amazing tool!
I found a defect and register Bug
9936https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9936 - epan/follow.c
- Incorrect comparing a sequence number of TCP fragment when its value wraps
over uint32_t limit
A capture file and
Hi Pascal,
thank you for answer. I saw your commits to follow.c and I hoped for your reply.
450:if( newseq seq[idx] ) {
I think - Yes. It compares sequence numbers.
459: if ( current-data_len new_pos ) {
I am sure, that - No. Because it compares length of data from fragment instead
of
2014-03-28 16:06 GMT+01:00 Pavel Karneliuk pavel_karnel...@epam.com:
Hello,
At first, thank you all for Wireshark. It is amazing tool!
I found a defect and register Bug
9936https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9936-
epan/follow.c - Incorrect comparing a sequence number
Yes, I am going to gerrit.
From: wireshark-dev-boun...@wireshark.org
[mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Pascal Quantin
Sent: Friday, March 28, 2014 6:57 PM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Defect in reassembling TCP stream. Bug and
Le 28 mars 2014 16:52, Pavel Karneliuk pavel_karnel...@epam.com a écrit
:
Hi Pascal,
thank you for answer. I saw your commits to follow.c and I hoped for your
reply.
450:if( newseq seq[idx] ) {
I think - Yes. It compares sequence numbers.
459: if ( current-data_len new_pos ) {
I am
