Thanks!
We could remove even this hack by linking editcap with libwireshark.
Is there still a strong reason for not doing so?
Cheers,
Balint
2013/3/7 Gerald Combs ger...@wireshark.org:
This didn't work because prior includes (wsgetopt.h in editcap.c and
privileges.h in capinfos.c) lock in the
I think the attached patches would make it be a bit less hack-ish.
Cheers,
Balint
2013/3/7 Gerald Combs ger...@wireshark.org:
-DENABLE_STATIC instead of -DWS_BUILD_DLL worked on my machine. Checked
in in r48158.
On 3/6/13 8:52 AM, Christopher Maynard wrote:
Pascal Quantin pascal.quantin@...
If no one objects I commit those tomorrow.
Cheers,
Balint
2013/3/7 Bálint Réczey bal...@balintreczey.hu:
I think the attached patches would make it be a bit less hack-ish.
Cheers,
Balint
2013/3/7 Gerald Combs ger...@wireshark.org:
-DENABLE_STATIC instead of -DWS_BUILD_DLL worked on my
2013/3/7 Gerald Combs ger...@wireshark.org
This didn't work because prior includes (wsgetopt.h in editcap.c and
privileges.h in capinfos.c) lock in the export behavior. I checked in
your changes in r48170 along with a workaround to reset the export
definitions. It's clunkier than I would like
This didn't work because prior includes (wsgetopt.h in editcap.c and
privileges.h in capinfos.c) lock in the export behavior. I checked in
your changes in r48170 along with a workaround to reset the export
definitions. It's clunkier than I would like but Visual C++ is happier now.
On 3/7/13 8:23
Pascal Quantin pascal.quantin@... writes:
Hi all,I added this workaround a few days ago in r48021 but Gerald reverted it
in r48072 as it was breaking getopt(). So we have to figure out how to solve
this properly.
OK, I missed that. How about something like this instead?
Index: Makefile.common
Recent Windows 7 and Windows XP Buildbot builds have been giving
locally defined symbol ... imported in ... warnings while linking
editcap:
(I get the same warnings on my system).
From the Window 7 Buildbot log:
Linking editcap.exe
link
Bill Meier wmeier@... writes:
Recent Windows 7 and Windows XP Buildbot builds have been giving
locally defined symbol ... imported in ... warnings while linking
editcap:
(I get the same warnings on my system).
Me too. Not sure if this is the right way to fix it, but this seems to work:
2013/3/6 Christopher Maynard christopher.mayn...@gtech.com
Bill Meier wmeier@... writes:
Recent Windows 7 and Windows XP Buildbot builds have been giving
locally defined symbol ... imported in ... warnings while linking
editcap:
(I get the same warnings on my system).
Me too. Not
