Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-24 Thread Bálint Réczey
2014-06-24 5:26 GMT+02:00 Joerg Mayer jma...@loplof.de: On Mon, Jun 23, 2014 at 09:17:32PM -0400, Evan Huus wrote: So perhaps what we should do is: not check generated code into Git; +1 put all generated code into the source tarballs. +2 How about releasing two

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-24 Thread Peter Wu
On Tuesday 24 June 2014 15:42:38 Bálint Réczey wrote: 2014-06-24 5:26 GMT+02:00 Joerg Mayer jma...@loplof.de: On Mon, Jun 23, 2014 at 09:17:32PM -0400, Evan Huus wrote: So perhaps what we should do is: not check generated code into Git; +1 +1 put all

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-24 Thread Anders Broman
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Peter Wu Sent: den 24 juni 2014 16:22 To: wireshark-dev@wireshark.org; bal...@balintreczey.hu Subject: Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was:

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-24 Thread Alexis La Goutte
Hi Joerg On Tue, Jun 24, 2014 at 5:26 AM, Joerg Mayer jma...@loplof.de wrote: On Mon, Jun 23, 2014 at 09:17:32PM -0400, Evan Huus wrote: So perhaps what we should do is: not check generated code into Git; put all generated code into the source tarballs. +2

[Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-23 Thread Anders Broman
-- Vidarebefordrat meddelande -- Från: Evan Huus eapa...@gmail.com Datum: 24 jun 2014 00:14 Ämne: Re: [Wireshark-dev] Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.] Till: Developer support list for Wireshark

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-23 Thread Evan Huus
On Mon, Jun 23, 2014 at 8:42 PM, Anders Broman a.broma...@gmail.com wrote: -- Vidarebefordrat meddelande -- Från: Evan Huus eapa...@gmail.com Datum: 24 jun 2014 00:14 Ämne: Re: [Wireshark-dev] Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-23 Thread Anders Broman
Den 24 jun 2014 03:18 skrev Evan Huus eapa...@gmail.com: On Mon, Jun 23, 2014 at 8:42 PM, Anders Broman a.broma...@gmail.com wrote: -- Vidarebefordrat meddelande -- Från: Evan Huus eapa...@gmail.com Datum: 24 jun 2014 00:14 Ämne: Re: [Wireshark-dev] Storing Generated Code

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-23 Thread Evan Huus
On Jun 23, 2014, at 23:03, Anders Broman a.broma...@gmail.com wrote: Den 24 jun 2014 03:18 skrev Evan Huus eapa...@gmail.com: On Mon, Jun 23, 2014 at 8:42 PM, Anders Broman a.broma...@gmail.com wrote: -- Vidarebefordrat meddelande -- Från: Evan Huus

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-23 Thread Joerg Mayer
On Mon, Jun 23, 2014 at 09:17:32PM -0400, Evan Huus wrote: So perhaps what we should do is: not check generated code into Git; put all generated code into the source tarballs. +2 Presumably we should rebuild all the DCERPC files as well at buildtime then? YEs,