[Wireshark-dev] Is git-review safe?

2014-03-13 Thread Hadriel Kaplan
So a funny thing happened while using 'git review' tonight. I was in a local branch named aruba_erm_radio, did my changes, did git commit, and then did git review. Inside my commit message, in the second paragraph, I mentioned that it resolves an enhancement bug 9880. For some reason,

Re: [Wireshark-dev] Is git-review safe?

2014-03-13 Thread Evan Huus
Apparently it tries to be smart and guess the appropriate topic. The relevant function is [1]. As far as safe goes, I think it is. This is only the Gerrit topic, not target branch, so the worst that happens is that pushing a new changeset will actually change the topic on you. You can always