Re: [Wireshark-dev] Is there a need for a 0, NULL element at the end of value strings

On Tue, Oct 16, 2018 at 10:21 AM Guy Harris wrote: > > On Oct 16, 2018, at 8:30 AM, Richard Sharpe > wrote: > > > OK, ignore me. When you call g_array_new with TRUE in the first > > argument you get a ZERO entry on the end. > > The fact that you had to ask this question - and probably had to

Re: [Wireshark-dev] Is there a need for a 0, NULL element at the end of value strings

On Oct 16, 2018, at 8:30 AM, Richard Sharpe wrote: > OK, ignore me. When you call g_array_new with TRUE in the first > argument you get a ZERO entry on the end. The fact that you had to ask this question - and probably had to look that up in the GLib documentation - suggests that there should

Re: [Wireshark-dev] Is there a need for a 0, NULL element at the end of value strings

On Tue, Oct 16, 2018 at 8:24 AM Richard Sharpe wrote: > > Hi folks, > > I have always put a {0, NULL} element on the end of value strings, but > it seems the lua code for constructing value strings when you use > ProtoField(..., some_value_string) does not terminate the list with an > empty

Re: [Wireshark-dev] Is there a need for a 0, NULL element at the end of value strings

Hi Richard, Le mar. 16 oct. 2018 à 17:26, Richard Sharpe a écrit : > Hi folks, > > I have always put a {0, NULL} element on the end of value strings, but > it seems the lua code for constructing value strings when you use > ProtoField(..., some_value_string) does not terminate the list with an

[Wireshark-dev] Is there a need for a 0, NULL element at the end of value strings

Hi folks, I have always put a {0, NULL} element on the end of value strings, but it seems the lua code for constructing value strings when you use ProtoField(..., some_value_string) does not terminate the list with an empty element, and my test did not cause a crash. Rather, I got an "unknown"