Re: [Wireshark-dev] New packet list - small fixes

2009-07-12 Thread Anders Broman
[mailto:wireshark-dev-boun...@wireshark.org] För Jakub Zawadzki Skickat: den 11 juli 2009 23:56 Till: wireshark-dev@wireshark.org Ämne: [Wireshark-dev] New packet list - small fixes Hi, This patch fix off-by-one error in packet_list_init() and makes new_packet_list_append() to use stack for row_data_t

Re: [Wireshark-dev] New packet list - small fixes

2009-07-12 Thread Jakub Zawadzki
On Sun, Jul 12, 2009 at 11:08:59AM +0200, Anders Broman wrote: Checked in Thanks :) together with some changes towards only storing the actually used columns. It crash at startup (newrecord-col_text[] not allocated), in attachment fix to restore old newrecord-col_text. Cheers. diff --git

Re: [Wireshark-dev] New packet list - small fixes

2009-07-12 Thread Jakub Zawadzki
On Sun, Jul 12, 2009 at 11:08:59AM +0200, Anders Broman wrote: I haven't figured out where packet_list_get_value():s column value comes from yet. It's set by gtk_tree_view_column_add_attribute(..., text, X) call Doc:

Re: [Wireshark-dev] New packet list - small fixes

2009-07-12 Thread Anders Broman
list for Wireshark Ämne: Re: [Wireshark-dev] New packet list - small fixes On Sun, Jul 12, 2009 at 11:08:59AM +0200, Anders Broman wrote: I haven't figured out where packet_list_get_value():s column value comes from yet. It's set by gtk_tree_view_column_add_attribute(..., text, X) call Doc: http

[Wireshark-dev] New packet list - small fixes

2009-07-11 Thread Jakub Zawadzki
Hi, This patch fix off-by-one error in packet_list_init() and makes new_packet_list_append() to use stack for row_data_t. Btw. There's new issue, when I load some capture into wireshark, and don't click any packet. I got SIGSEGV on closing capture (^W) on quiting (^Q) (gdb) bt #0