Re: [Wireshark-dev] Possible change to packet-ssl.c?

2014-04-10 Thread Peter Wu
On Wednesday 09 April 2014 16:49:43 Guy Harris wrote: Why is that treated as a this is encrypted indication rather than a somebody's trying to extract whatever's in the server's memory after the request payload indication? After the handshake, the record layer is encrypted, including

[Wireshark-dev] Possible change to packet-ssl.c?

2014-04-09 Thread Guy Harris
Should this chunk of code: if (tree) { if (type (payload_length = record_length - 16 - 3)) { proto_item_set_text(tree, %s Record Layer: Heartbeat %s, val_to_str_const(*conv_version, ssl_version_short_names,

Re: [Wireshark-dev] Possible change to packet-ssl.c?

2014-04-09 Thread Evan Huus
On Wed, Apr 9, 2014 at 7:49 PM, Guy Harris g...@alum.mit.edu wrote: Should this chunk of code: if (tree) { if (type (payload_length = record_length - 16 - 3)) { proto_item_set_text(tree, %s Record Layer: Heartbeat %s,