[Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Michael Lum
Is there a goal to remove g_iconv calls from Wireshark. I notice the GSM SMS dissector has been changed. I'm working on an ANSI SMS change but the replacement of g_iconv is not straight forward. I checked charsets.c/.h and there are two encodings that are not available that are used in the

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Pascal Quantin
Hi Michael, 2013/12/20 Michael Lum michael@starsolutions.com Is there a goal to remove g_iconv calls from Wireshark. I notice the GSM SMS dissector has been changed. I'm working on an ANSI SMS change but the replacement of g_iconv is not straight forward. I checked charsets.c/.h and

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Guy Harris
On Dec 20, 2013, at 10:46 AM, Michael Lum michael@starsolutions.com wrote: Is there a goal to remove g_iconv calls from Wireshark. I'd certainly like to do so to the maximum extent possible. I would like to have *all* code set handling done by using ENC_ arguments to

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Jakub Zawadzki
On Fri, Dec 20, 2013 at 10:46:29AM -0800, Michael Lum wrote: Is there a goal to remove g_iconv calls from Wireshark. Nope, it's not a goal (at least not for me). Goals are two: 1/ To support more encodings in epan, which will make it easier for people to use 2/ Thanks to 1/ more calls can be

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Guy Harris
On Dec 20, 2013, at 11:24 AM, Jakub Zawadzki darkjames...@darkjames.pl wrote: In euc-kr [1] you can see that it's using ksc5601_to_ucs4() which can be find in ksc5601.h [2]. ksc5601_to_ucs4() is using convertation tables: __ksc5601_hangul_to_ucs, __ksc5601_hanja_to_ucs,

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Michael Lum
: December 20, 2013 11:35 AM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Replacing g_iconv and different codesets On Dec 20, 2013, at 11:24 AM, Jakub Zawadzki darkjames...@darkjames.pl wrote: In euc-kr [1] you can see that it's using ksc5601_to_ucs4() which can

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Jakub Zawadzki
On Fri, Dec 20, 2013 at 11:59:20AM -0800, Michael Lum wrote: Okay, thanks for the responses. I started to make some changes but its probably more than I have time for. But in case I pick it up I had a question about the ENC_ values from proto.h. This is what I have from SVN: #define

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Michael Lum
Of Jakub Zawadzki Sent: December 20, 2013 12:11 PM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Replacing g_iconv and different codesets On Fri, Dec 20, 2013 at 11:59:20AM -0800, Michael Lum wrote: Okay, thanks for the responses. I started to make some changes