Re: [Wireshark-dev] Should we check value_strings for NULL termination while registering?

2006-09-22 Thread Ulf Lamping
ronnie sahlberg wrote: That would be an awful lot of work since we would need to modify (add registration of) all value_strings. I only thought of the registration of the hf_ arrays, so this would probably a single place to change. I think this would already catch the vast majority of

Re: [Wireshark-dev] Should we check value_strings for NULL termination while registering?

2006-09-21 Thread Ulf Lamping
Gilbert Ramirez wrote: I believe we do this in the build-bot testing, by doing: tshark -G values Since that operation iterates across all the value_string arrays, a non-terminated array will result in an error or at least it should. Is that enough testing? Unsure. It can drive

Re: [Wireshark-dev] Should we check value_strings for NULL termination while registering?

2006-09-20 Thread Gilbert Ramirez
I believe we do this in the build-bot testing, by doing: tshark -G values Since that operation iterates across all the value_string arrays, a non-terminated array will result in an error or at least it should. Is that enough testing? --gilbert On 9/20/06, Ulf Lamping [EMAIL PROTECTED]