Re: [Wireshark-dev] The ieee802.11 dissector is a steaming pile of ordure

Hi Richard (and Bill) It is historic... at the first, there is only limited fixed field and tagged field... and on last 802.11 spec, there is > 100 tagged field... If you have a solution to avoid a big switch... i have already think to put each case on separate function... but for some case,

Re: [Wireshark-dev] The ieee802.11 dissector is a steaming pile of ordure

On Thu, Sep 10, 2015 at 12:42 AM, Alexis La Goutte wrote: > Hi Richard (and Bill) > > It is historic... at the first, there is only limited fixed field and tagged > field... > and on last 802.11 spec, there is > 100 tagged field... > > If you have a solution to avoid a

[Wireshark-dev] The ieee802.11 dissector is a steaming pile of ordure

Take a look at epan/dissectors/packet-ieee80211.c! Specifically, add_tagged_field. That function is approximately 2,300 lines long and it consists of one big switch statement with every arm containing open-coded statements to add things to the proto tree. Who does that? -- Regards, Richard

Re: [Wireshark-dev] The ieee802.11 dissector is a steaming pile of ordure

On 9/9/2015 11:23 AM, Richard Sharpe wrote: Take a look at epan/dissectors/packet-ieee80211.c! Specifically, add_tagged_field. That function is approximately 2,300 lines long and it consists of one big switch statement with every arm containing open-coded statements to add things to the proto

Re: [Wireshark-dev] The ieee802.11 dissector is a steaming pile of ordure

On 9/9/2015 12:03 PM, Bill Meier wrote: On 9/9/2015 11:23 AM, Richard Sharpe wrote: Take a look at epan/dissectors/packet-ieee80211.c! Specifically, add_tagged_field. That function is approximately 2,300 lines long and it consists of one big switch statement with every arm containing