Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-14 Thread Dario Lombardo 
On Mon, Sep 13, 2021 at 7:39 PM Gerald Combs  wrote:

> How long does the GitHub action take to run?


According to the jobs history, it takes 25 to 30 minutes, which looks
comparable to the wireshark's builds for windows on gitlab.
It usually gets scheduled very quickly, which does not happen in all CI
free platforms.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Gerald Combs 

How long does the GitHub action take to run? The "Windows Build" job currently uses a 
dedicated runner, which is why it only gets run if a maintainer submits, rebases or otherwise 
"lays hands" the MR. We use a dedicated runner because installing all of our 
prerequisites, building Wireshark, and running tests on GitLab's shared Windows builders took a 
very long time. It might make sense to make another attempt at getting that working.

On 9/13/21 6:01 AM, Dario Lombardo wrote:

You can also leverage github actions: it has a windows build. Just push on a 
github fork of yours and you'll trigger a windows build.

https://github.com/wireshark/wireshark/actions/workflows/windows.yml 


On Mon, Sep 13, 2021 at 2:48 PM Ivan Nardi mailto:nardi.i...@gmail.com>> wrote:

Hi Roland
I thought that the present configuration was a trade-off between
flexibility and resource constraints.
Thank you very much for the suggestions, very appreciated! I will
definitely compile Wireshark with both gcc and clang from now on.

Thanks for your reply
Kind regards


Ivan

On Mon, 13 Sept 2021 at 11:24, Roland Knall mailto:rkn...@gmail.com>> wrote:
 >
 > Hi Ivan
 >
 > We have a limited number of machines for our build-jobs. Therefore only 
when we set the merge-request to a semi-done level, buildjobs are triggered. What 
you can do though, is run your own pipeline, and use our .gitlab-ci.yml file as a 
template.
 >
 > At this point we do not plan on making the builders available to 
everyone. But if you submit your changes, we can trigger it for you.
 >
 > Btw, as a Mac & Linux user myself, I keep a virtualbox around just for 
that purpose. To be able to build Wireshark. It is not required, but certainly helps. 
Also, building Wireshark on your local Linux machine with a clang compiler instead of 
gcc, will also identify most issues with the Microsoft VS compilers (as was my 
experience in the past)
 >
 > kind regards
 > Roland
 >
 > Am Mo., 13. Sept. 2021 um 11:17 Uhr schrieb Ivan Nardi mailto:nardi.i...@gmail.com>>:
 >>
 >> Hi
 >>
 >> If I am not wrong, the "Windows Build" job is triggered only after a
 >> maintainer picks up the MR and assigns it to the "Wireshark GitLab
 >> Utility".
 >> Is there any way I can trigger it myself?
 >>
 >> Some background.
 >> I don't have a Windows machine to build Wireshark myself.
 >> My last MR (https://gitlab.com/wireshark/wireshark/-/merge_requests/3628 
)
 >> triggers a warning only in the Windows build.
 >> I **think** to have a fix for it. I could push it, wait for a
 >> maintainer to pick it up again and cross my fingers...
 >> But if I could trigger the Windows test myself it should be less a
 >> bother to anyone.
 >> Can I do that somehow?
 >>
 >> I hope I made myself clear
 >> Thanks
 >>
 >> Ivan
 >> 
___
 >> Sent via:    Wireshark-dev mailing list mailto:wireshark-dev@wireshark.org>>
 >> Archives: https://www.wireshark.org/lists/wireshark-dev 

 >> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev 

 >>              mailto:wireshark-dev-requ...@wireshark.org 
?subject=unsubscribe
 >
 > 
___
 > Sent via:    Wireshark-dev mailing list mailto:wireshark-dev@wireshark.org>>
 > Archives: https://www.wireshark.org/lists/wireshark-dev 

 > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev 

 >              mailto:wireshark-dev-requ...@wireshark.org 
?subject=unsubscribe
___
Sent via:    Wireshark-dev mailing list mailto:wireshark-dev@wireshark.org>>
Archives: https://www.wireshark.org/lists/wireshark-dev 

Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev 

              mailto:wireshark-dev-requ...@wireshark.org 
?subject=unsubscribe



--

Naima is online.


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Dario Lombardo 
You can also leverage github actions: it has a windows build. Just push on
a github fork of yours and you'll trigger a windows build.

https://github.com/wireshark/wireshark/actions/workflows/windows.yml

On Mon, Sep 13, 2021 at 2:48 PM Ivan Nardi  wrote:

> Hi Roland
> I thought that the present configuration was a trade-off between
> flexibility and resource constraints.
> Thank you very much for the suggestions, very appreciated! I will
> definitely compile Wireshark with both gcc and clang from now on.
>
> Thanks for your reply
> Kind regards
>
>
> Ivan
>
> On Mon, 13 Sept 2021 at 11:24, Roland Knall  wrote:
> >
> > Hi Ivan
> >
> > We have a limited number of machines for our build-jobs. Therefore only
> when we set the merge-request to a semi-done level, buildjobs are
> triggered. What you can do though, is run your own pipeline, and use our
> .gitlab-ci.yml file as a template.
> >
> > At this point we do not plan on making the builders available to
> everyone. But if you submit your changes, we can trigger it for you.
> >
> > Btw, as a Mac & Linux user myself, I keep a virtualbox around just for
> that purpose. To be able to build Wireshark. It is not required, but
> certainly helps. Also, building Wireshark on your local Linux machine with
> a clang compiler instead of gcc, will also identify most issues with the
> Microsoft VS compilers (as was my experience in the past)
> >
> > kind regards
> > Roland
> >
> > Am Mo., 13. Sept. 2021 um 11:17 Uhr schrieb Ivan Nardi <
> nardi.i...@gmail.com>:
> >>
> >> Hi
> >>
> >> If I am not wrong, the "Windows Build" job is triggered only after a
> >> maintainer picks up the MR and assigns it to the "Wireshark GitLab
> >> Utility".
> >> Is there any way I can trigger it myself?
> >>
> >> Some background.
> >> I don't have a Windows machine to build Wireshark myself.
> >> My last MR (
> https://gitlab.com/wireshark/wireshark/-/merge_requests/3628)
> >> triggers a warning only in the Windows build.
> >> I **think** to have a fix for it. I could push it, wait for a
> >> maintainer to pick it up again and cross my fingers...
> >> But if I could trigger the Windows test myself it should be less a
> >> bother to anyone.
> >> Can I do that somehow?
> >>
> >> I hope I made myself clear
> >> Thanks
> >>
> >> Ivan
> >>
> ___
> >> Sent via:Wireshark-dev mailing list 
> >> Archives:https://www.wireshark.org/lists/wireshark-dev
> >> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
> >
> >
> ___
> > Sent via:Wireshark-dev mailing list 
> > Archives:https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>


-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Ivan Nardi 
Hi Roland
I thought that the present configuration was a trade-off between
flexibility and resource constraints.
Thank you very much for the suggestions, very appreciated! I will
definitely compile Wireshark with both gcc and clang from now on.

Thanks for your reply
Kind regards


Ivan

On Mon, 13 Sept 2021 at 11:24, Roland Knall  wrote:
>
> Hi Ivan
>
> We have a limited number of machines for our build-jobs. Therefore only when 
> we set the merge-request to a semi-done level, buildjobs are triggered. What 
> you can do though, is run your own pipeline, and use our .gitlab-ci.yml file 
> as a template.
>
> At this point we do not plan on making the builders available to everyone. 
> But if you submit your changes, we can trigger it for you.
>
> Btw, as a Mac & Linux user myself, I keep a virtualbox around just for that 
> purpose. To be able to build Wireshark. It is not required, but certainly 
> helps. Also, building Wireshark on your local Linux machine with a clang 
> compiler instead of gcc, will also identify most issues with the Microsoft VS 
> compilers (as was my experience in the past)
>
> kind regards
> Roland
>
> Am Mo., 13. Sept. 2021 um 11:17 Uhr schrieb Ivan Nardi :
>>
>> Hi
>>
>> If I am not wrong, the "Windows Build" job is triggered only after a
>> maintainer picks up the MR and assigns it to the "Wireshark GitLab
>> Utility".
>> Is there any way I can trigger it myself?
>>
>> Some background.
>> I don't have a Windows machine to build Wireshark myself.
>> My last MR (https://gitlab.com/wireshark/wireshark/-/merge_requests/3628)
>> triggers a warning only in the Windows build.
>> I **think** to have a fix for it. I could push it, wait for a
>> maintainer to pick it up again and cross my fingers...
>> But if I could trigger the Windows test myself it should be less a
>> bother to anyone.
>> Can I do that somehow?
>>
>> I hope I made myself clear
>> Thanks
>>
>> Ivan
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Roland Knall 
Hi Ivan

We have a limited number of machines for our build-jobs. Therefore only
when we set the merge-request to a semi-done level, buildjobs are
triggered. What you can do though, is run your own pipeline, and use our
.gitlab-ci.yml file as a template.

At this point we do not plan on making the builders available to everyone.
But if you submit your changes, we can trigger it for you.

Btw, as a Mac & Linux user myself, I keep a virtualbox around just for that
purpose. To be able to build Wireshark. It is not required, but certainly
helps. Also, building Wireshark on your local Linux machine with a clang
compiler instead of gcc, will also identify most issues with the Microsoft
VS compilers (as was my experience in the past)

kind regards
Roland

Am Mo., 13. Sept. 2021 um 11:17 Uhr schrieb Ivan Nardi :

> Hi
>
> If I am not wrong, the "Windows Build" job is triggered only after a
> maintainer picks up the MR and assigns it to the "Wireshark GitLab
> Utility".
> Is there any way I can trigger it myself?
>
> Some background.
> I don't have a Windows machine to build Wireshark myself.
> My last MR (https://gitlab.com/wireshark/wireshark/-/merge_requests/3628)
> triggers a warning only in the Windows build.
> I **think** to have a fix for it. I could push it, wait for a
> maintainer to pick it up again and cross my fingers...
> But if I could trigger the Windows test myself it should be less a
> bother to anyone.
> Can I do that somehow?
>
> I hope I made myself clear
> Thanks
>
> Ivan
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Triggering "Windows Build" job

2021-09-13 Thread Ivan Nardi 
Hi

If I am not wrong, the "Windows Build" job is triggered only after a
maintainer picks up the MR and assigns it to the "Wireshark GitLab
Utility".
Is there any way I can trigger it myself?

Some background.
I don't have a Windows machine to build Wireshark myself.
My last MR (https://gitlab.com/wireshark/wireshark/-/merge_requests/3628)
triggers a warning only in the Windows build.
I **think** to have a fix for it. I could push it, wait for a
maintainer to pick it up again and cross my fingers...
But if I could trigger the Windows test myself it should be less a
bother to anyone.
Can I do that somehow?

I hope I made myself clear
Thanks

Ivan
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe