Re: [Wireshark-dev] Use of variadic macros

2015-10-05 Thread Guy Harris
> On Oct 4, 2015, at 7:41 AM, Peter Wu wrote: > > On Thu, Oct 01, 2015 at 10:15:12AM -0700, Guy Harris wrote: >> >> On Oct 1, 2015, at 9:53 AM, Alexis La Goutte >> wrote: >> >>> Yes, there is a "warning" with GCC from some month... >>> >>> ../../epan/proto.h:2740:54: warning: anonymous vari

Re: [Wireshark-dev] Use of variadic macros

2015-10-04 Thread Peter Wu
On Thu, Oct 01, 2015 at 10:15:12AM -0700, Guy Harris wrote: > > On Oct 1, 2015, at 9:53 AM, Alexis La Goutte > wrote: > > > Yes, there is a "warning" with GCC from some month... > > > > ../../epan/proto.h:2740:54: warning: anonymous variadic macros were > > introduced in C99 [-Wvariadic-macro

Re: [Wireshark-dev] Use of variadic macros

2015-10-01 Thread Guy Harris
On Oct 1, 2015, at 9:53 AM, Alexis La Goutte wrote: > Yes, there is a "warning" with GCC from some month... > > ../../epan/proto.h:2740:54: warning: anonymous variadic macros were > introduced in C99 [-Wvariadic-macros] Perhaps we need to turn on the "use C99" flag for some compilers, includi

Re: [Wireshark-dev] Use of variadic macros

2015-10-01 Thread Alexis La Goutte
Yes, there is a "warning" with GCC from some month... ../../epan/proto.h:2740:54: warning: anonymous variadic macros were introduced in C99 [-Wvariadic-macros] Not problem for me, to allow variadic macro ! Regards, On Thu, Oct 1, 2015 at 6:31 PM, Graham Bloice wrote: > > On 1 October 2015 a

Re: [Wireshark-dev] Use of variadic macros

2015-10-01 Thread Graham Bloice
On 1 October 2015 at 17:25, Peter Wu wrote: > #include > #define FOO(fmt, ...) printf(fmt, #__VA_ARGS__, __VA_ARGS__) > int main() { > return FOO("%s test %d\n", 1); > } > VS2013 appears to be happy, compiling the file with a .c extension: c:\temp>cl var.c Microsoft (R) C/C++

[Wireshark-dev] Use of variadic macros

2015-10-01 Thread Peter Wu
Hi, Use of variadic macros has been discussed in the past (https://www.wireshark.org/lists/wireshark-dev/201209/msg00142.html), but at that time it was dropped because it was deemed not supported well enough across compilers. Now apparently commit v1.11.3-rc1-2203-geee21a6 added proto_tree_add_fl

Re: [Wireshark-dev] Use of variadic macros

2012-09-23 Thread Evan Huus
On Sun, Sep 23, 2012 at 6:10 PM, Guy Harris wrote: > > On Sep 23, 2012, at 1:59 PM, Evan Huus wrote: > >> Variadic macros are forbidden in doc/README.developer since apparently >> not all compilers support them. >> >> However, I just stumbled across a variadic macro that has apparently >> been pa

Re: [Wireshark-dev] Use of variadic macros

2012-09-23 Thread Guy Harris
On Sep 23, 2012, at 1:59 PM, Evan Huus wrote: > Variadic macros are forbidden in doc/README.developer since apparently > not all compilers support them. > > However, I just stumbled across a variadic macro that has apparently > been part of the regular build since around 2009 > (packet-dcerpc-n

[Wireshark-dev] Use of variadic macros

2012-09-23 Thread Evan Huus
Variadic macros are forbidden in doc/README.developer since apparently not all compilers support them. However, I just stumbled across a variadic macro that has apparently been part of the regular build since around 2009 (packet-dcerpc-netlogon.c:65). Since nobody (to my knowledge) has complained