Re: [Wireshark-dev] Version of Qt required?
On Tue, Jul 7, 2020 at 4:08 PM John Thacker wrote: > On Tue, Jul 7, 2020, 1:11 PM Pascal Quantin wrote: > >> Hi John, >> >> Le mar. 7 juil. 2020 à 19:09, John Thacker a >> écrit : >> >>> On Tue, Jul 7, 2020 at 10:48 AM Graham Bloice < >>> graham.blo...@trihedral.com> wrote: >>> The table of Qt versions shows which versions have been used in Wireshark installers for Windows and macOS. Determining the versions available on specific Linux distributions is a bit more of an artform but can be gleaned from the tables further down. >>> >>> Ah, I see, yes I misread the table and interpreted the bold versions as >>> minimum requirements. I just took a look and updated the RHEL/CentOS and >>> SLES information. Looking at the rest of the tables, Debian Jesse just went >>> end of support, so Ubuntu xenial (16.04LTS, end of support April 2021) >>> being at 5.5.x is I think the oldest QT in a still officially supported >>> distribution on that page. After that there's several at 5.6.x. >>> >>> I reckon that QT 5.9 is fine for every distro's most recent LTS release, >>> and 5.6 is fine for every distro's N-1 LTS release. Personally I'd be fine >>> with moving master to 5.9 (which also settles requiring C+11), but I could >>> understand 5.6. >>> >> >> Can't this code be made conditional to the Qt version used for compiling? >> > > It can be, but I think I would just as well rewrite it to use code from QT > 5.3 and earlier. In this case I don't think there's from later than 5.3 > that's absolutely necessary for the functionality, more just syntactic > sugar that can be done a different way. > Well, I guess foreach was officially deprecated in QT 5.7, so I suppose I could check and do the loop with foreach for QT_VERSION < 5.7 and the qAsConst way with 5.7 and higher. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Version of Qt required?
On Tue, Jul 7, 2020, 1:11 PM Pascal Quantin wrote: > Hi John, > > Le mar. 7 juil. 2020 à 19:09, John Thacker a > écrit : > >> On Tue, Jul 7, 2020 at 10:48 AM Graham Bloice < >> graham.blo...@trihedral.com> wrote: >> >>> >>> The table of Qt versions shows which versions have been used in >>> Wireshark installers for Windows and macOS. Determining the versions >>> available on specific Linux distributions is a bit more of an artform but >>> can be gleaned from the tables further down. >>> >> >> Ah, I see, yes I misread the table and interpreted the bold versions as >> minimum requirements. I just took a look and updated the RHEL/CentOS and >> SLES information. Looking at the rest of the tables, Debian Jesse just went >> end of support, so Ubuntu xenial (16.04LTS, end of support April 2021) >> being at 5.5.x is I think the oldest QT in a still officially supported >> distribution on that page. After that there's several at 5.6.x. >> >> I reckon that QT 5.9 is fine for every distro's most recent LTS release, >> and 5.6 is fine for every distro's N-1 LTS release. Personally I'd be fine >> with moving master to 5.9 (which also settles requiring C+11), but I could >> understand 5.6. >> > > Can't this code be made conditional to the Qt version used for compiling? > It can be, but I think I would just as well rewrite it to use code from QT 5.3 and earlier. In this case I don't think there's from later than 5.3 that's absolutely necessary for the functionality, more just syntactic sugar that can be done a different way. John ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Version of Qt required?
Hi John, Le mar. 7 juil. 2020 à 19:09, John Thacker a écrit : > On Tue, Jul 7, 2020 at 10:48 AM Graham Bloice > wrote: > >> >> The table of Qt versions shows which versions have been used in Wireshark >> installers for Windows and macOS. Determining the versions available on >> specific Linux distributions is a bit more of an artform but can be gleaned >> from the tables further down. >> > > Ah, I see, yes I misread the table and interpreted the bold versions as > minimum requirements. I just took a look and updated the RHEL/CentOS and > SLES information. Looking at the rest of the tables, Debian Jesse just went > end of support, so Ubuntu xenial (16.04LTS, end of support April 2021) > being at 5.5.x is I think the oldest QT in a still officially supported > distribution on that page. After that there's several at 5.6.x. > > I reckon that QT 5.9 is fine for every distro's most recent LTS release, > and 5.6 is fine for every distro's N-1 LTS release. Personally I'd be fine > with moving master to 5.9 (which also settles requiring C+11), but I could > understand 5.6. > Can't this code be made conditional to the Qt version used for compiling? Best regards, Pascal. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Version of Qt required?
On Tue, Jul 7, 2020 at 10:48 AM Graham Bloice wrote: > > The table of Qt versions shows which versions have been used in Wireshark > installers for Windows and macOS. Determining the versions available on > specific Linux distributions is a bit more of an artform but can be gleaned > from the tables further down. > Ah, I see, yes I misread the table and interpreted the bold versions as minimum requirements. I just took a look and updated the RHEL/CentOS and SLES information. Looking at the rest of the tables, Debian Jesse just went end of support, so Ubuntu xenial (16.04LTS, end of support April 2021) being at 5.5.x is I think the oldest QT in a still officially supported distribution on that page. After that there's several at 5.6.x. I reckon that QT 5.9 is fine for every distro's most recent LTS release, and 5.6 is fine for every distro's N-1 LTS release. Personally I'd be fine with moving master to 5.9 (which also settles requiring C+11), but I could understand 5.6. John Thacker ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Version of Qt required?
On Tue, 7 Jul 2020 at 15:30, John Thacker wrote:
> Ah, sorry, that is the result of my recent change. I had checked here
>
> https://wiki.wireshark.org/Development/Support_library_version_tracking
>
> which says that 5.9 and 5.12 had already been required by Wireshark 3.0
> and 3.2 so I went ahead and used it.
>
>
The table of Qt versions shows which versions have been used in Wireshark
installers for Windows and macOS. Determining the versions available on
specific Linux distributions is a bit more of an artform but can be gleaned
from the tables further down.
> Does it actually compile and work on 5.6 except for that change?
>
> QT 5.6 is a long term support release and there are some distributions
> stuck on it. I can change my recent commit if we don't want to bump the
> required version.
>
> John
>
> On Tue, Jul 7, 2020, 9:15 AM Martin Mathieson via Wireshark-dev <
> wireshark-dev@wireshark.org> wrote:
>
>> In a VM where I build Wireshark, I am getting this error on master:
>>
>> /home/martin/wireshark/ui/qt/follow_stream_dialog.cpp: In member function
>> ‘void FollowStreamDialog::addCodecs(const QMap&)’:
>> /home/martin/wireshark/ui/qt/follow_stream_dialog.cpp:164:47: error:
>> ‘qAsConst’ was not declared in this scope
>> for (const auto : qAsConst(codecMap)) {
>>^
>> ui/qt/CMakeFiles/qtui.dir/build.make:1015: recipe for target
>> 'ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o' failed
>> make[2]: *** [ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o] Error
>> 1
>> make[2]: *** Waiting for unfinished jobs
>>
>> My installed version of Qt appears to be 5.6.2.
>>
>> Looking at CMakeLists.txt, there are various checks for Qt5Widgets, but
>> the earliest supported version looks like 5.3?
>>
>> I think https://doc.qt.io/qt-5/qtglobal.html#qAsConst was introduced
>> in 5.7.
>> Do we want to bump the minimum versions?
>>
>> Martin
>>
>>
>>
>>
--
Graham Bloice
___
Sent via:Wireshark-dev mailing list
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Version of Qt required?
My tailing-edge Leap 42.3 VM seems to be stuck on 5.6
The main check in CMakeLists.txt appears to be this:
if (Qt5Widgets_VERSION VERSION_LESS 5.3)
message(FATAL_ERROR "Qt 5.3 or later is required.")
endif()
if (Qt5Widgets_VERSION VERSION_GREATER 5.6
AND (CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES
"Clang"))
# Qt 5.7 and later require C++ 11.
set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
endif()
There are some other platform-specific checks (Mac).
I don't know what else goes into the decision to move the Qt version
required onwards - if it moves forward I will create a new VM.
Martin
On Tue, Jul 7, 2020 at 3:30 PM John Thacker wrote:
> Ah, sorry, that is the result of my recent change. I had checked here
>
> https://wiki.wireshark.org/Development/Support_library_version_tracking
>
> which says that 5.9 and 5.12 had already been required by Wireshark 3.0
> and 3.2 so I went ahead and used it.
>
> Does it actually compile and work on 5.6 except for that change?
>
> QT 5.6 is a long term support release and there are some distributions
> stuck on it. I can change my recent commit if we don't want to bump the
> required version.
>
> John
>
> On Tue, Jul 7, 2020, 9:15 AM Martin Mathieson via Wireshark-dev <
> wireshark-dev@wireshark.org> wrote:
>
>> In a VM where I build Wireshark, I am getting this error on master:
>>
>> /home/martin/wireshark/ui/qt/follow_stream_dialog.cpp: In member function
>> ‘void FollowStreamDialog::addCodecs(const QMap&)’:
>> /home/martin/wireshark/ui/qt/follow_stream_dialog.cpp:164:47: error:
>> ‘qAsConst’ was not declared in this scope
>> for (const auto : qAsConst(codecMap)) {
>>^
>> ui/qt/CMakeFiles/qtui.dir/build.make:1015: recipe for target
>> 'ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o' failed
>> make[2]: *** [ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o] Error
>> 1
>> make[2]: *** Waiting for unfinished jobs
>>
>> My installed version of Qt appears to be 5.6.2.
>>
>> Looking at CMakeLists.txt, there are various checks for Qt5Widgets, but
>> the earliest supported version looks like 5.3?
>>
>> I think https://doc.qt.io/qt-5/qtglobal.html#qAsConst was introduced
>> in 5.7.
>> Do we want to bump the minimum versions?
>>
>> Martin
>>
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>> mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
> ___
> Sent via:Wireshark-dev mailing list
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Version of Qt required?
Ah, sorry, that is the result of my recent change. I had checked here
https://wiki.wireshark.org/Development/Support_library_version_tracking
which says that 5.9 and 5.12 had already been required by Wireshark 3.0 and
3.2 so I went ahead and used it.
Does it actually compile and work on 5.6 except for that change?
QT 5.6 is a long term support release and there are some distributions
stuck on it. I can change my recent commit if we don't want to bump the
required version.
John
On Tue, Jul 7, 2020, 9:15 AM Martin Mathieson via Wireshark-dev <
wireshark-dev@wireshark.org> wrote:
> In a VM where I build Wireshark, I am getting this error on master:
>
> /home/martin/wireshark/ui/qt/follow_stream_dialog.cpp: In member function
> ‘void FollowStreamDialog::addCodecs(const QMap&)’:
> /home/martin/wireshark/ui/qt/follow_stream_dialog.cpp:164:47: error:
> ‘qAsConst’ was not declared in this scope
> for (const auto : qAsConst(codecMap)) {
>^
> ui/qt/CMakeFiles/qtui.dir/build.make:1015: recipe for target
> 'ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o' failed
> make[2]: *** [ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o] Error 1
> make[2]: *** Waiting for unfinished jobs
>
> My installed version of Qt appears to be 5.6.2.
>
> Looking at CMakeLists.txt, there are various checks for Qt5Widgets, but
> the earliest supported version looks like 5.3?
>
> I think https://doc.qt.io/qt-5/qtglobal.html#qAsConst was introduced in
> 5.7.
> Do we want to bump the minimum versions?
>
> Martin
>
>
> ___
> Sent via:Wireshark-dev mailing list
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Version of Qt required?
In a VM where I build Wireshark, I am getting this error on master:
/home/martin/wireshark/ui/qt/follow_stream_dialog.cpp: In member function
‘void FollowStreamDialog::addCodecs(const QMap&)’:
/home/martin/wireshark/ui/qt/follow_stream_dialog.cpp:164:47: error:
‘qAsConst’ was not declared in this scope
for (const auto : qAsConst(codecMap)) {
^
ui/qt/CMakeFiles/qtui.dir/build.make:1015: recipe for target
'ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o' failed
make[2]: *** [ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs
My installed version of Qt appears to be 5.6.2.
Looking at CMakeLists.txt, there are various checks for Qt5Widgets, but the
earliest supported version looks like 5.3?
I think https://doc.qt.io/qt-5/qtglobal.html#qAsConst was introduced in
5.7.
Do we want to bump the minimum versions?
Martin
___
Sent via:Wireshark-dev mailing list
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
