On 3/24/14 9:03 AM, Evan Huus wrote:
On Mon, Mar 24, 2014 at 11:26 AM, Bill Meier wme...@newsguy.com wrote:
On 3/24/2014 9:21 AM, Evan Huus wrote:
In summary: the diff is computed locally in javascript, and seems to
be worse than O(n) on the size of the underlying file; viewing the
diff for
I can't consistently view the code of patches submitted to Gerrit (the
Side-by-Side or Unified links). I've tried on IE8 and 9 as well as Firefox v28
(all on Windows) and get the same consistently inconsistent results (some
patches work, some don't. Some files within a particular patch are
On Mon, Mar 24, 2014 at 8:55 AM, mman...@netscape.net wrote:
I can't consistently view the code of patches submitted to Gerrit (the
Side-by-Side or Unified links). I've tried on IE8 and 9 as well as Firefox
v28 (all on Windows) and get the same consistently inconsistent results
(some patches
On Mar 24, 2014, at 9:21 AM, Evan Huus eapa...@gmail.com wrote:
On Mon, Mar 24, 2014 at 8:55 AM, mman...@netscape.net wrote:
I can't consistently view the code of patches submitted to Gerrit (the
Side-by-Side or Unified links). I've tried on IE8 and 9 as well as Firefox
v28 (all on
On 3/24/2014 9:21 AM, Evan Huus wrote:
In summary: the diff is computed locally in javascript, and seems to
be worse than O(n) on the size of the underlying file; viewing the
diff for any file 1k lines may be slow, but if you just let it run it
will finish eventually. Avoid
On Mon, Mar 24, 2014 at 11:26 AM, Bill Meier wme...@newsguy.com wrote:
On 3/24/2014 9:21 AM, Evan Huus wrote:
In summary: the diff is computed locally in javascript, and seems to
be worse than O(n) on the size of the underlying file; viewing the
diff for any file 1k lines may be slow, but if
On 3/24/2014 12:03 PM, Evan Huus wrote:
IOW: The 2 versions being diff'd are downloaded in total before doing a
local compare ?
It seems so; however it doesn't appear to be the bandwidth that's the
problem, but the actual diff algorithm. The bottleneck is definitely
CPU.
For those of us
On Mar 24, 2014, at 11:26 AM, Bill Meier wme...@newsguy.com wrote:
On 3/24/2014 9:21 AM, Evan Huus wrote:
In summary: the diff is computed locally in javascript, and seems to
be worse than O(n) on the size of the underlying file; viewing the
diff for any file 1k lines may be slow, but if
