Re: [Wireshark-dev] dissect_sip_tcp_heur()

2013/8/10 Martin Kaiser li...@kaiser.cx I came across this while browsing through the coverity defects. gboolean first = TRUE; is never changed Does the following change make sense to those who are familiar with SIP? diff --git a/epan/dissectors/packet-sip.c b/epan/dissectors/packet-sip.c

Re: [Wireshark-dev] dissect_sip_tcp_heur()

I'm not really familiar with SIP over TCP (in all my use cases, SIP is over UDP) but your proposal makes sense. Thanks Pascal, that explains why nobody spotted this so far. I committed the change in r51313 and I'll schedule it for backporting to 1.10 and 1.8 if nobody complains. Best

Re: [Wireshark-dev] dissect_sip_tcp_heur()

On Aug 12, 2013, at 6:22 AM, Martin Kaiser li...@kaiser.cx wrote: I'm not really familiar with SIP over TCP (in all my use cases, SIP is over UDP) but your proposal makes sense. Thanks Pascal, that explains why nobody spotted this so far. I think it's more because it's only the

[Wireshark-dev] dissect_sip_tcp_heur()

I came across this while browsing through the coverity defects. gboolean first = TRUE; is never changed Does the following change make sense to those who are familiar with SIP? diff --git a/epan/dissectors/packet-sip.c b/epan/dissectors/packet-sip.c index fa317c8..c04a0c8 100644 ---