Re: [Wireshark-dev] happy birthday, bug 5531!

2012-01-14 Thread Joerg Mayer
On Thu, Jan 05, 2012 at 08:03:26PM -0500, Ed Beroset wrote: Joerg Mayer wrote: I have a few small questions that came up during looking at the patch (not all of them relevant to this patch!): - why is eax.[ch] in epan instead of epan/crypt/? - why do we have files named crypt/crypt-aes.c

Re: [Wireshark-dev] happy birthday, bug 5531!

2012-01-05 Thread Ed Beroset
Joerg Mayer wrote: I have a few small questions that came up during looking at the patch (not all of them relevant to this patch!): - why is eax.[ch] in epan instead of epan/crypt/? - why do we have files named crypt/crypt-aes.c instead of crypt/aes.c? - is eax.c added to CMakeLists.txt as

Re: [Wireshark-dev] happy birthday, bug 5531!

2011-12-30 Thread Joerg Mayer
On Thu, Dec 29, 2011 at 02:25:43PM -0500, Ed Beroset wrote: Chris Maynard wrote: Ed Berosetberoset@... writes: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5531 It's been a year since it was originally submitted. As always, if there's anything I can do to help get this into the

Re: [Wireshark-dev] happy birthday, bug 5531!

2011-12-30 Thread Ed Beroset
Joerg Mayer wrote: I looked at this patch a bit but as I don't know anything about BER I can't comment on much. I have a few small questions that came up during looking at the patch (not all of them relevant to this patch!): - why is eax.[ch] in epan instead of epan/crypt/? It could be moved

Re: [Wireshark-dev] happy birthday, bug 5531!

2011-12-29 Thread Chris Maynard
Ed Beroset beroset@... writes: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5531 It's been a year since it was originally submitted. As always, if there's anything I can do to help get this into the main code, please let me know. I know a number of people that are waiting for it.

Re: [Wireshark-dev] happy birthday, bug 5531!

2011-12-29 Thread Ed Beroset
Chris Maynard wrote: Ed Berosetberoset@... writes: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5531 It's been a year since it was originally submitted. As always, if there's anything I can do to help get this into the main code, please let me know. I know a number of people that

[Wireshark-dev] happy birthday, bug 5531!

2011-12-28 Thread Ed Beroset
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5531 It's been a year since it was originally submitted. As always, if there's anything I can do to help get this into the main code, please let me know. I know a number of people that are waiting for it. And thanks again for a mighty