Re: [Wireshark-dev] modelines

2011-09-28 Thread Stephen Fisher
On Wed, Sep 28, 2011 at 01:51:05AM +, Chris Maynard wrote: however, I am wondering if 8 is simply used more than 4 because that's what the Wireshark modeline generation tool happens to default to, I believe the GNU standard is for an 8 space tabstop, but now I can't find a reference to

Re: [Wireshark-dev] modelines

2011-09-28 Thread Ed Beroset
Stephen Fisher wrote: Can modelines be at the top of a file? Yes, for vim (and I assume others). That's where I usually put them. The boiler plate copyright notice from doc/README.developer might be a good place to put it. I think that's a good approach. It may also be useful to think

Re: [Wireshark-dev] modelines

2011-09-28 Thread Jeff Morriss
Chris Maynard wrote: Stephen Fisher steve@... writes: Since I started coding for Wireshark in 2006, the convention wisdom (as I understood it) has always been to stick with the formatting method that the file already has, whatever that may be. Right, but what if there's a file already

Re: [Wireshark-dev] modelines

2011-09-28 Thread Bill Meier
On 9/28/2011 4:57 PM, Jeff Morriss wrote: I'll argue that *tab*stops should be 8 until someone shows me how to tell all the various terminal programs I end up using that the file I'm currently looking at (in 'less' or 'grep' or plain old 'cat') that the file in question is using an alternative

Re: [Wireshark-dev] modelines

2011-09-28 Thread Guy Harris
On Sep 28, 2011, at 2:21 PM, Bill Meier wrote: On 9/28/2011 4:57 PM, Jeff Morriss wrote: I'll argue that *tab*stops should be 8 until someone shows me how to tell all the various terminal programs I end up using that the file I'm currently looking at (in 'less' or 'grep' or plain old

Re: [Wireshark-dev] modelines

2011-09-28 Thread Chris Maynard
Guy Harris guy@... writes: On Sep 28, 2011, at 2:21 PM, Bill Meier wrote: On 9/28/2011 4:57 PM, Jeff Morriss wrote: I'll argue that *tab*stops should be 8 until someone shows me how to tell all the various terminal programs I end up using that the file I'm currently looking at (in

Re: [Wireshark-dev] modelines

2011-09-28 Thread Guy Harris
On Sep 28, 2011, at 6:14 PM, Chris Maynard wrote: Gerald has a table of official coding standards posted at http://www.wireshark.org/tools/modelines.html, and it looks like in the Microsoft world, 4 is the standard. ...but I think it can be changed to the UN*X standard in a global setting

[Wireshark-dev] modelines

2011-09-27 Thread Chris Maynard
A couple of questions/thoughts on modelines[1]: 1) Should emacs (and other) modelines be added to the generated modelines at [1], e.g., setq as mentioned by Zawinski[2]? 2) In the absence of any other user preference, what is the Wireshark recommendation on modeline settings, if any? The

Re: [Wireshark-dev] modelines

2011-09-27 Thread Stephen Fisher
On Tue, Sep 27, 2011 at 06:57:15PM +, Chris Maynard wrote: 2) In the absence of any other user preference, what is the Wireshark recommendation on modeline settings, if any? The following seems to be the default settings generated at [1], so am I right to assume that would be the

Re: [Wireshark-dev] modelines

2011-09-27 Thread Chris Maynard
Stephen Fisher steve@... writes: Since I started coding for Wireshark in 2006, the convention wisdom (as I understood it) has always been to stick with the formatting method that the file already has, whatever that may be. Right, but what if there's a file already consistently using tabs