Re: [Wireshark-dev] Source code for ACN (ANSI BSR E1.17) Dissector

2006-10-25 Thread ronnie sahlberg
Since it wont go into the next release on monday anyway (already branched off) It produces a lot of compiler warnings when compiling with gcc : packet-acn.c: In function `dissect_acn_heur': packet-acn.c:734: warning: implicit declaration of function `memcmp' packet-acn.c: In function

Re: [Wireshark-dev] Source code for ACN (ANSI BSR E1.17) Dissector

2006-10-25 Thread ronnie sahlberg
warnings for unused parameters are fixed easily by adding a _U_ to the function arguments. I.e. foo(..., int not_used _U_ , ...){ On 10/25/06, ronnie sahlberg [EMAIL PROTECTED] wrote: Since it wont go into the next release on monday anyway (already branched off) It produces a lot of

Re: [Wireshark-dev] Source code for ACN (ANSI BSR E1.17) Dissector

2006-10-25 Thread Jeff Morriss
We do suffer in wireshark from port collissions due to the number of protocols we support. So a port number is not really enough for us to identify a protocol. Can you make dissect_acn() do some heuristics and return FALSE if it didnt really look like ACN in the first place? This would

Re: [Wireshark-dev] Please remove: mate.config warning

2006-10-25 Thread Ulf Lamping
LEGO wrote: That means that mate was installed with 0.99.3 and it was not installed with 0.99.4. I thought I was sure that I didn't installed it with the 0.99.3 either - but I seem to be wrong on this. I tried the whole procedure once again and don't see the problem any longer. What we

Re: [Wireshark-dev] [Patch] packet-gsm_a.c: fix CLIR IEs for CC-SETUP

2006-10-25 Thread Anders Broman
Checked in. Brg Anders -Ursprungligt meddelande- Från: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] För Reinhard Speyerer Skickat: den 24 oktober 2006 22:52 Till: wireshark-dev@wireshark.org Ämne: [Wireshark-dev] [Patch] packet-gsm_a.c: fix CLIR IEs for CC-SETUP The attached patch fixes

Re: [Wireshark-dev] [Patch] Fix for bug #1170

2006-10-25 Thread Jaap Keuter
Hi, Checked in. Thanx, Jaap On Tue, 24 Oct 2006, Stephen Fisher wrote: Attached is a patch to fix bug #1170: Wireshark interpretation of WBXML does not comply with Spec. This has been verified with the sample capture the user provided. Steve

Re: [Wireshark-dev] Source code for ACN (ANSI BSR E1.17) Dissector

2006-10-25 Thread Stephen Fisher
On Wed, Oct 25, 2006 at 09:29:39AM +, ronnie sahlberg wrote: We do suffer in wireshark from port collissions due to the number of protocols we support. So a port number is not really enough for us to identify a protocol. I believe the sample dissector in doc/README.developer is an

Re: [Wireshark-dev] [Wireshark-commits] rev 19684: /trunk/ /trunk/epan/dissectors/: packet-h248.c packet-h248.h /trunk/asn1/h248/: packet-h248-template.c

2006-10-25 Thread LEGO
You beat me by few seconds (not kidding)... There's an issue here: The h248v3 asn hasn't yet been tested... I believe it would be better to revert the changes to the generated dissector and make them by hand. Then let the v3 asn for the next release. Anders, what do you think? On 10/25/06,

[Wireshark-dev] D-Bus support

2006-10-25 Thread frederic heem
Hi, D-Bus support has been adding to wireshark. For those who are interested to know more about this feature, a README.dbus has been written. Any comments will be appreciated Cheers, Frederic Heem __ --- NOTICE ---

[Wireshark-dev] Bug #1040 fix: imap packet: not all infos are displayed

2006-10-25 Thread Stephen Fisher
Attached is a patch to fix bug #1040: imap packet: not all infos are displayed. It has been tested against the capture file the user provided as well as my own capture of an imap session. Thanks, Steve bug1040-fix.patch.gz Description: Binary data

Re: [Wireshark-dev] Bug 1088 question: SNMP Object Names not displayed in the info column

2006-10-25 Thread Jaap Keuter
Hi, I've been playing with some changes to the conformance and template file of the SNMP dissector, but haven't achieved this goal yet. Since I'm new to this asn2wrs stuff, it will take some more time to come up with the best solution. Thanx, Jaap On Wed, 25 Oct 2006, Stephen Fisher wrote:

Re: [Wireshark-dev] D-Bus support

2006-10-25 Thread Ulf Lamping
frederic heem wrote: Hi, D-Bus support has been adding to wireshark. For those who are interested to know more about this feature, a README.dbus has been written. Any comments will be appreciated Cheers, Frederic Heem Mentioning the bugzilla entry 1179 would be a good idea - not

[Wireshark-dev] Why am I getting a BoundsError?

2006-10-25 Thread Andrew Schweitzer
I'm writing a dissector for a proprietary protocol and using tcp_dissect_pdus. Our packets can be 2k, and sometimes I seem to get incorrectly parsed messages in the gui. I see the text in the gui Packet size limited during capture. I found this in packet-frame.c, and apparently I'm getting a

Re: [Wireshark-dev] Why am I getting a BoundsError?

2006-10-25 Thread Guy Harris
Andrew Schweitzer wrote: I'm writing a dissector for a proprietary protocol and using tcp_dissect_pdus. Our packets can be 2k, and sometimes I seem to get incorrectly parsed messages in the gui. I see the text in the gui Packet size limited during capture. I found this in packet-frame.c,

Re: [Wireshark-dev] Why am I getting a BoundsError?

2006-10-25 Thread Ulf Lamping
Andrew Schweitzer wrote: I'm writing a dissector for a proprietary protocol and using tcp_dissect_pdus. Our packets can be 2k, and sometimes I seem to get incorrectly parsed messages in the gui. I see the text in the gui Packet size limited during capture. I found this in packet-frame.c,

Re: [Wireshark-dev] Why am I getting a BoundsError?

2006-10-25 Thread Andrew Schweitzer
Guy Harris wrote: Andrew Schweitzer wrote: Thanks. In a packet that gets a BoundsError, what are the captured length and (actual) length in the Frame section of the packet detail pane? hm it seemed like it captured a full ethernet packet. 1514, if I understand you: Frame 1

Re: [Wireshark-dev] D-Bus support

2006-10-25 Thread ronnie sahlberg
Remotely (potentially across a network) starting and stopping a capture, i.e. doing remote captures would be very very useful and often requested feature.However, this should probably not be implemented in wireshark and friends but rather in the libpcap/wiretap layer. For any remote capture

Re: [Wireshark-dev] Why am I getting a BoundsError?

2006-10-25 Thread Andrew Schweitzer
Maybe I don't understand tcp_dissect_pdus. If a user message overruns an ethernet frame, tcp_dissect_pdus is supposed to allocate enough space to hold the entire user message, and only call the user's dissector when the entire message has been received... right? So if we get a frame with user

Re: [Wireshark-dev] new style dissectors (Was: Source code for ACN (ANSI BSR E1.17) Dissector)

2006-10-25 Thread Jeff Morriss
Joerg Mayer wrote: On Wed, Oct 25, 2006 at 06:00:00PM +0800, Jeff Morriss wrote: I did this once a while ago and found figuring out how to actually make a dissector into a new style dissector wasn't all that easy, mainly because I couldn't find which (of the hundreds) of dissectors did it

[Wireshark-dev] Bug #1138 fix: 'Follow TP streams gets stream direction wrong...

2006-10-25 Thread Stephen Fisher
Attached is a patch to fix bug #1138: Follow TCP Streams gets stream direction wrong if started from a server-client frame. THE PROBLEM: The drop-down list of which direction's flow you want to see is based on the source port of the currently selected packet. The actual text is based on a

Re: [Wireshark-dev] [patch] YMSG dissector update

2006-10-25 Thread Gennady Feldman
Here is an updated patch. Should be pretty safe. Just added a couple of constants and changed some strings to be cleaner and easier to read. Gena01On 9/18/06, Jaap Keuter [EMAIL PROTECTED] wrote: Hi,Checked in, with the additional change in the version numberThanx,JaapOn Mon, 18 Sep 2006, Gena01