Re: [Wireshark-dev] I need wmem_alloc advice please

2016-09-17 Thread Paul Offord
I moved the space allocation from inti_globals function to proto_register_transum and changed the scope to epan like this: sub_packet = (PKT_INFO *)wmem_alloc(wmem_epan_scope(), (MAX_SUBPKTS_PER_PACKET * sizeof(PKT_INFO))); I still get the same problem where another structure is being overw

Re: [Wireshark-dev] I need wmem_alloc advice please

2016-09-17 Thread Paul Offord
OK – another embarrassing mistake on my part. Although I had changed the global definition for sub_packet from a static array to a pointer to a dynamically allocated space I hadn’t changed a corresponding extern statement in decoders.c. Thanks to all for your help with this. Best regards…Paul

[Wireshark-dev] smb2.msg_id defined as signed 64-bit integer - bug?

2016-09-17 Thread Paul Offord
In packet-smb2.h and packet-smb2.c the SMB2 MessageId is defined as a signed 64-bit integer. packet-smb2.h -- typedef struct _smb2_info_t { guint16 opcode; guint32 ioctl_function; guint32 status; guint32 tid;

Re: [Wireshark-dev] TRANSUM Program Logic Notes

2016-09-17 Thread Graham Bloice
On 16 September 2016 at 22:14, Paul Offord wrote: > Hi, > > > > I’d like to create some notes for the TRANSUM post-dissector. I think the > best place would be on the Wireshark wiki. > > > > ·Is that the best place for the notes? > > ·How do I get contributor rights on the wiki?

Re: [Wireshark-dev] smb2.msg_id defined as signed 64-bit integer - bug?

2016-09-17 Thread Graham Bloice
On 17 September 2016 at 15:12, Paul Offord wrote: > In packet-smb2.h and packet-smb2.c the SMB2 MessageId is defined as a > signed 64-bit integer. > > > > packet-smb2.h > > -- > > typedef struct _smb2_info_t { > >guint16 opcode; > >guint32 ioctl_fun

Re: [Wireshark-dev] smb2.msg_id defined as signed 64-bit integer - bug?

2016-09-17 Thread Richard Sharpe
On Sat, Sep 17, 2016 at 7:12 AM, Paul Offord wrote: > In packet-smb2.h and packet-smb2.c the SMB2 MessageId is defined as a signed > 64-bit integer. > As Graham alreay said, sure create a bug or submit a change directly. However, even at 1 SMB message per microsecond, that is still around 10^43

Re: [Wireshark-dev] smb2.msg_id defined as signed 64-bit integer - bug?

2016-09-17 Thread Paul Offord
Yeh - sure I accept that. I raised it because I've written a post-dissector that uses the smb2.msg_id value. I assumed it was a 64-bit unsigned integer and it caused my code to crash. I tracked it down to an assertion failure due to smb2.msg_id being a gint64 and me using fvalue_get_uinteger6

[Wireshark-dev] Application for a wiki account

2016-09-17 Thread Paul Offord
Hi, I'd like to add information to the Wireshark wiki for a dissector called TRANSUM. My preferred account ID is PaulOfford but I'm not too bothered what it is. Thanks and regards...Paul Paul Offord FBCS CITP Chief Technical Officer Advance7 Phone: 01279 211 668 Mobile: 07764 931 431 Email

Re: [Wireshark-dev] Application for a wiki account

2016-09-17 Thread Pascal Quantin
Done with PaulOfford. Pascal. 2016-09-17 19:34 GMT+02:00 Paul Offord : > Hi, > > > > I’d like to add information to the Wireshark wiki for a dissector called > TRANSUM. My preferred account ID is PaulOfford but I’m not too bothered > what it is. > > > > Thanks and regards…Paul > > > > Paul Offo