Re: [Wireshark-dev] payload_proto_id in SCPT dissector

2019-08-15 Thread Anders Broman
Hi, It is the SCTP PPI which is defined by IANA Payload protocol identifier: M3UA (3) { _data_chunk_payload_proto_id, { "Payload protocol identifier","sctp.data_payload_proto_id", FT_UINT32, BASE_DEC, VALS(sctp_payload_proto_id_values), 0x0,

[Wireshark-dev] payload_proto_id in SCPT dissector

2019-08-15 Thread Dario Lombardo
Hi, I'm working on fixing a bug reported by oss-fuzz, and I got stuck. The payload is TLS over SCPT. In the sctp dissector the variable payload_proto_id is read from the tlv in dissect_data_chunk. What is it supposed to contain? Which proto_id? Following the stack trace, this value is passed to

[Wireshark-dev] Wireshark Windows libraries

2019-08-15 Thread Jaap Keuter
Hi, In order to prevent a missed update (like last time with Npcap 0.996) it might be a good idea to already prepare for the following: Npcap 0.996 -> 0.9982 USBPcap 1.5.2.0 -> 1.5.3.0 Thanks, Jaap ___ Sent via:

Re: [Wireshark-dev] Wireshark Windows libraries

2019-08-15 Thread Pascal Quantin
Hi Jaap, Le jeu. 15 août 2019 à 08:34, Jaap Keuter a écrit : > Hi, > > In order to prevent a missed update (like last time with Npcap 0.996) it > might be a good idea to already prepare for the following: > Npcap 0.996 -> 0.9982 > USBPcap 1.5.2.0 -> 1.5.3.0 > I planned to perform the update

Re: [Wireshark-dev] Wireshark Windows libraries

2019-08-15 Thread Pascal Quantin
Le jeu. 15 août 2019 à 18:55, Gerald Combs a écrit : > On 8/14/19 11:33 PM, Jaap Keuter wrote: > > Hi, > > > > In order to prevent a missed update (like last time with Npcap 0.996) it > might be a good idea to already prepare for the following: > > Npcap 0.996 -> 0.9982 > > USBPcap 1.5.2.0 ->

Re: [Wireshark-dev] Wireshark Windows libraries

2019-08-15 Thread Gerald Combs
On 8/14/19 11:33 PM, Jaap Keuter wrote: > Hi, > > In order to prevent a missed update (like last time with Npcap 0.996) it > might be a good idea to already prepare for the following: > Npcap 0.996 -> 0.9982 > USBPcap 1.5.2.0 -> 1.5.3.0 We also need to update nghttp2, which I'm hoping to do

Re: [Wireshark-dev] payload_proto_id in SCPT dissector

2019-08-15 Thread Peter Wu
The problem was introduced with v3.1.1rc0-144-gede7be3440 ("TLS: allow dissectors to set the appdata protocol via the data param"). Since that commit, the "data" parameter of TCP is interpreted as a string. The problem is that the SCTP dissector can also call the TLS dissector with a non-NULL

Re: [Wireshark-dev] Wireshark Windows libraries

2019-08-15 Thread Jaap Keuter
> On 15 Aug 2019, at 18:54, Gerald Combs wrote: > > On 8/14/19 11:33 PM, Jaap Keuter wrote: >> Hi, >> >> In order to prevent a missed update (like last time with Npcap 0.996) it >> might be a good idea to already prepare for the following: >> Npcap 0.996 -> 0.9982 >> USBPcap 1.5.2.0 ->