Re: [Wireshark-dev] Compilation failure on Fedora 20 - GTK3 issues

2013-12-20 Thread Peter Wu
Hi Kaul, On Friday 20 December 2013 13:20:37 Kaul wrote: Doesn't happen on a fully updated Fedora 19, just on my Fedora 20: CC libgtkui_a-addr_resolution_dlg.o In file included from /usr/include/gtk-3.0/gtk/gtkapplication.h:27:0, from

Re: [Wireshark-dev] cmake giving options the compiler does not understand

2014-01-02 Thread Peter Wu
Hi, On Thursday 02 January 2014 16:02:08 Jeff Morriss wrote: It took me a while to get my cmake build going again today; one of the reasons was that the builds would immediately fail with: cc: error: unrecognized command line option -Wshorten-64-to-32 As far as I can tell the problem

Re: [Wireshark-dev] do we continue to reference revision numbers?

2014-01-31 Thread Peter Wu
On Friday 31 January 2014 11:46:34 Hadriel Kaplan wrote: Any specific leading character(s) we should use, so that bugzilla can someday parse it and insert the appropriate url? Like ‘c[commit_id_sha1]' I propose the regex /\bcommit [0-9a-f]{4,40}\b/i (or /[Cc]ommit .../ without i modifier).

Re: [Wireshark-dev] How to set up the display filter?

2014-03-03 Thread Peter Wu
On Monday 03 March 2014 16:25:06 我想不无聊 wrote: I just captured WLAN packets with wireshark, I want to display the packets whose source address is 10.0.1.128 ,what is the display filter expression?thanks. The manual page of wireshark-filter(4) has an example for this. Adapter for your case:

Re: [Wireshark-dev] Wireshark 1.10.6 is now available

2014-03-08 Thread Peter Wu
On Saturday 08 March 2014 10:12:48 Edwin Groothuis wrote: On 8/03/14 06:49 , Gerald Combs wrote: I'm proud to announce the release of Wireshark 1.10.6. In the past I was able to get the source of this release via svn checkout http://anonsvn.wireshark.org/releases/xxx; and incorporate it

Re: [Wireshark-dev] Regarding Plugin attachment

2014-03-11 Thread Peter Wu
On Tuesday 11 March 2014 23:12:34 Nilesh Nayak wrote: Is it necessary to uninstall the wireshark each time you try to add a new plugin for your customised protocol? No, a plugin can be enabled and disabled without reinstalling WS. Or can we have 2 instances of wireshark running on the same

Re: [Wireshark-dev] how to use wireshark source code?

2014-03-27 Thread Peter Wu
Hi, On Thursday 27 March 2014 17:05:08 我想不无聊 wrote: I add a file named peformance.h under wireshark main directory, peformance.h spelling error here (and below), it should be performance. #include glib.h typedef struct peformance_s { gfloat time[100]; gfloat

Re: [Wireshark-dev] 回复: how to use wireshark source code?

2014-03-27 Thread Peter Wu
(re-adding list in reply) Please do not top-post. On Thursday 27 March 2014 17:34:38 我想不无聊 wrote: it still occurs to me this error: packet-ieee80211.c:131: error: expected '=', ',', ';', 'asm' or '__attribute__' before '-' token what is going on? You really need to show more details,

Re: [Wireshark-dev] how to include a head file

2014-03-28 Thread Peter Wu
On Friday 28 March 2014 13:10:09 我想不无聊 wrote: then I add the file to /gtk/main.c file , #include peformance.h //somebody told me not to use ../peformance.h because there is subdir to search Well, I was that somebody and refused to reply on the last private mail because you provided *no*

Re: [Wireshark-dev] how to use the wireshark source code to develop application?

2014-03-30 Thread Peter Wu
On Sunday 30 March 2014 14:57:59 我想不无聊 wrote: //performance.h #include glib.h typedef struct performance_s { gfloat time[100]; gfloat delay[100]; guint32 packetSize[100]; guint32 payload; guint32 index; guint32 temp_size; gfloat

Re: [Wireshark-dev] WARNING aclocal

2014-04-06 Thread Peter Wu
Hi, On Sunday 06 April 2014 12:52:32 khemis haythem wrote: i m trying to build envirenement 1- ./autogen.sh you should update your 'aclocal.m4' by running aclocal what to do ?? i m blocked here for 2 days who can help me ? Posting the same question a day later won't speed up getting

Re: [Wireshark-dev] WARNING aclocal

2014-04-06 Thread Peter Wu
On Sunday 06 April 2014 13:15:07 khemis haythem wrote: really i haven't tried using cmake instead of autofoo but when i can use cmake ? and about the the full output, is like these picture : after $aclocal i get : aclocal.png and after ./autogen.sh i get : autogen_sh.png Are you

Re: [Wireshark-dev] Possible change to packet-ssl.c?

2014-04-10 Thread Peter Wu
On Wednesday 09 April 2014 16:49:43 Guy Harris wrote: Why is that treated as a this is encrypted indication rather than a somebody's trying to extract whatever's in the server's memory after the request payload indication? After the handshake, the record layer is encrypted, including

Re: [Wireshark-dev] build wireshark

2014-04-11 Thread Peter Wu
On Friday 11 April 2014 21:54:28 khemis haythem wrote: how i know that wireshark is corectly builded on ubuntu 12.04 ? there's any methode to know this ?? Yes, run it. If you build it correctly, you have binaries in the run/ directory. run/wireshark, run/tshark, etc. I see you have a Yahoo

Re: [Wireshark-dev] git history of files moved in SVN

2014-04-14 Thread Peter Wu
On Monday 14 April 2014 17:07:48 Jeff Morriss wrote: (That change doesn't show up in the history of epan/dissectors/packet-tcp.c in the Git repository, probably because the SVN-to-Git converter couldn't handle moves/renames in SVN, perhaps because SVN, while handling them better than CVS,

Re: [Wireshark-dev] [Wireshark-commits] master fc5d8db: Create the HTTP tree after we're assured it's HTTP. Otherwise a bogus tree is created when HTTP2 traffic is found.

2014-04-24 Thread Peter Wu
On Thursday 24 April 2014 16:41:02 mman...@netscape.net wrote: After looking at this, I'd have to say the DTLS decryption test is flawed. It sets up a key to decifer traffic as HTTP, but it's not really HTTP, it's just a bunch of ASCII strings. I can change it to any of the valid dissectors

Re: [Wireshark-dev] GIT vs SVN

2014-04-25 Thread Peter Wu
On Friday 25 April 2014 11:27:35 Jeff Morriss wrote: Basically: 1) Create a branch off master (git checkout -b myprivatebranch master) 2) Make your changes 3) Check in your changes (git commit -a) 3.a) Make sure you never git push from this branch :-). If someone knows a way to make it

Re: [Wireshark-dev] Failed for master-1.10: [Automatic manuf, services and enterprise-numbers update for 2014-04-27]

2014-04-28 Thread Peter Wu
On Monday 28 April 2014 22:36:46 Jaap Keuter wrote: I noticed that master and master-1.8 got their weekly updates, but master-1.10 missed it? Can we find out why? It probably has something to do with IANA changes, see https://code.wireshark.org/review/c/1385/ Peter

[Wireshark-dev] ASAN bug in wiretap/pcapng; just remove the code?

2014-05-15 Thread Peter Wu
Hi Anders, I found an ASAN bug in wiretap (stack-based buffer overrun) for which an initial patch was submitted to https://code.wireshark.org/review/1628/ (patchset 1 or 2). After a more thorough look, it seems that the pcapng_dump_t type and related code are unused. It was first added in

[Wireshark-dev] Gerrit usability and git web interface

2014-06-23 Thread Peter Wu
Hi, First, a request: could the gitweb commit messages also be post- processed such that things like Bug: XXX and URLs become clickable? An arbitrary example that shows the expected and actual messages: https://code.wireshark.org/review/999/

Re: [Wireshark-dev] Fwd: Re: Storing Generated Code in Git [Was: master 9079e3a: Cheat and try to fix the generated file manually.]

2014-06-24 Thread Peter Wu
On Tuesday 24 June 2014 15:42:38 Bálint Réczey wrote: 2014-06-24 5:26 GMT+02:00 Joerg Mayer jma...@loplof.de: On Mon, Jun 23, 2014 at 09:17:32PM -0400, Evan Huus wrote: So perhaps what we should do is: not check generated code into Git; +1 +1 put all

[Wireshark-dev] Return value of a new-style dissector

2014-06-25 Thread Peter Wu
Hi, Since Pascal's change (TCP: do desegmentation sanity checks for all sub dissectors types), the whois dissector was starting to throw: Dissector bug, protocol TCP, in packet 6: epan/dissectors/packet-tcp.c:3953: failed assertion save_desegment_offset == pinfo-desegment_offset

Re: [Wireshark-dev] Return value of a new-style dissector

2014-06-25 Thread Peter Wu
On Wednesday 25 June 2014 18:32:44 Peter Wu wrote: Hi, Since Pascal's change (TCP: do desegmentation sanity checks for all sub dissectors types), the whois dissector was starting to throw: Dissector bug, protocol TCP, in packet 6: epan/dissectors/packet-tcp.c:3953: failed assertion

Re: [Wireshark-dev] Return value of a new-style dissector

2014-06-25 Thread Peter Wu
On Wednesday 25 June 2014 12:56:21 Evan Huus wrote: On Wed, Jun 25, 2014 at 12:54 PM, Evan Huus eapa...@gmail.com wrote: On Wed, Jun 25, 2014 at 12:32 PM, Peter Wu pe...@lekensteyn.nl wrote: Hi, Since Pascal's change (TCP: do desegmentation sanity checks for all sub dissectors types

[Wireshark-dev] Collection of captures for each supported dissector?

2014-06-30 Thread Peter Wu
Hi, Is there an accessible list of capture files for each supported dissector? I would like to make some changes w.r.t. reassembly, but want to be sure not to introduce regressions. SampleCaptures contains a list of captures, but these are not complete and are not grouped per dissector. What I

Re: [Wireshark-dev] Collection of captures for each supported dissector?

2014-06-30 Thread Peter Wu
On Monday 30 June 2014 07:12:56 Evan Huus wrote: The menagerie is our collection of capture files that the fuzz-bot uses to test with. It contains a substantial number of files across as many protocols as we have been able to accumulate. However, I am not sure it is entirely publicly

Re: [Wireshark-dev] Collection of captures for each supported dissector?

2014-06-30 Thread Peter Wu
(adding back the list, adding Gerald) On Monday 30 June 2014 09:33:29 Evan Huus wrote: On Mon, Jun 30, 2014 at 9:05 AM, Peter Wu pe...@lekensteyn.nl wrote: On Monday 30 June 2014 07:12:56 Evan Huus wrote: The menagerie is our collection of capture files that the fuzz-bot uses to test

Re: [Wireshark-dev] Backport to 1.1 Change in wireshark[master-1.12]: ssl: add SslSession structure

2014-07-03 Thread Peter Wu
(Alexis, no need to cc me on my gmail, Google has already enough data ;)) On Thursday 03 July 2014 18:26:29 Graham Bloice wrote: On 3 July 2014 18:20, Alexis La Goutte alexis.lagou...@gmail.com wrote: Hi, I'm OK to backport this serie of patch to 1.12 Other core ? I want also

[Wireshark-dev] Should dissect_tcp_pdus be used as much as possible?

2014-07-04 Thread Peter Wu
Hi, Should reassembly be enabled in as many TCP protocols as possible? That is, is it desirable that TCP-based protocols use dissect_tcp_pdus with reassembly set to true? I am asking because I was fixing an error in the return value of the Plan 9 dissector[1]. While at it, I converted it to use

[Wireshark-dev] Backport request for proto_tree_add_subtree[_format]

2014-07-10 Thread Peter Wu
Hi all, I would like to have the proto_tree_add_subtree and proto_tree_add_subtree_format functions backported to master-1.12. Any objects to that? It is only a new addition to the API, so it should be pretty safe. It should make backporting changes easier. (read: backport a refactoring (WIP)

Re: [Wireshark-dev] Backport request for proto_tree_add_subtree[_format]

2014-07-11 Thread Peter Wu
On Thursday 10 July 2014 23:54:59 mman...@netscape.net wrote: The proto_tree_add_subtree[_format] code refactoring was very intentionally post-1.12 and I don't see much point to just having the API there without it. Further refactoring of specific dissectors like SSL and DTLS probably won't

[Wireshark-dev] Bug in expert_add_info_format with a NULL pi parameter

2014-07-18 Thread Peter Wu
Hi, While working on refactoring the SSL dissector[1], I noticed that expert_add_info_format(pinfo, NULL, ...) does not add an expert item to the tree view. In the case of the SSL dissector, the NULL should be replaced by the proto item to which the message is related, but with pi = NULL, an

Re: [Wireshark-dev] Bug in expert_add_info_format with a NULL pi parameter

2014-07-18 Thread Peter Wu
On Saturday 19 July 2014 00:33:26 Peter Wu wrote: Hi, While working on refactoring the SSL dissector[1], I noticed that expert_add_info_format(pinfo, NULL, ...) does not add an expert item to the tree view. In the case of the SSL dissector, the NULL should be replaced by the proto item

Re: [Wireshark-dev] Help Regarding AIRPDCAP_DEBUG_PRINT_LINE

2014-07-30 Thread Peter Wu
On Wednesday 30 July 2014 17:11:30 Ashok Kumar wrote: I am interested in getting prints AIRPDCAP_DEBUG_PRINT_LINE. Can anyone help me in enabling this prints and where we can see this print outputs. $ grep -rwn AIRPDCAP_DEBUG_PRINT_LINE . ... epan/crypt/airpdcap_debug.h:44:#define

Re: [Wireshark-dev] [Wireshark-announce] Wireshark 1.12.0rc3 is now available

2014-07-31 Thread Peter Wu
On Wednesday 30 July 2014 14:35:06 Gerald Combs wrote: After comparing the tarballs generated by make dist and git-export-release.sh I have to agree. Both have issues but the dist tarball will build according to our documentation on Linux, Windows, and OS X. make dist is missing: - Quite

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-07-31 Thread Peter Wu
On Thursday 31 July 2014 17:11:59 Evan Huus wrote: This issue has been bugging me for a while, but I also haven't been able to come up with a satisfactory solution. Oh my, that filesystem.c code is really ugly and relying on a lot of assumptions. Why does it need to distinguish build dirs from

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Peter Wu
On Thursday 31 July 2014 16:40:53 Guy Harris wrote: On Jul 31, 2014, at 3:11 PM, Peter Wu pe...@lekensteyn.nl wrote: [..] Oh my, that filesystem.c code is really ugly and relying on a lot of assumptions. Why does it need to distinguish build dirs from other dirs in the first place? So

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Peter Wu
On Thursday 31 July 2014 20:04:52 Evan Huus wrote: FWIW this issue also makes it impossible to run parts of the test suite from an out-of-tree build, which can be problematic. Which part exactly? I can run most of the test-suite with an OOT build using: WS_BIN_PATH=/tmp/wsbuild/run ./test.sh

Re: [Wireshark-dev] Changes to packet-erf dissector

2014-08-14 Thread Peter Wu
On Thursday 14 August 2014 15:59:41 Wasim Abu Moch wrote: My name is Wasim and I'm a SW engineer at Mellanox Technologies. As I understood from my old boss that in order to do some changes to ERF dissector I should contact/consult Stephen Donnelly from Endace (Emulex now), my question is: Is

Re: [Wireshark-dev] help with pushing to Gerrit

2014-08-17 Thread Peter Wu
On Sunday 17 August 2014 09:31:16 Wasim Abu Moch wrote: Can anyone tell how I can push my changes for review, the documentation on the website says: $ git push ssh://my.usern...@code.wireshark.org:29418/wireshark HEAD:refs/for/master/snowcone-machine But I don't know which

Re: [Wireshark-dev] Building Wireshark on MAC

2014-09-30 Thread Peter Wu
GMT+02:00 Peter Wu pe...@lekensteyn.nl: On Monday 29 September 2014 21:09:22 Anders Broman wrote: Well for a cmake newbie it would help with an example of which parameters to use... Typically you have a build directory separate from your code. Minimal example: mkdir build cd

Re: [Wireshark-dev] CapturePrivileges not working

2014-10-13 Thread Peter Wu
On Monday 13 October 2014 11:07:43 Roland Knall wrote: No, it's a cmake out-of-tree build. There simply does not seem to be a way to set dumpcap correctly. Fun part is, that even dumpcap is set suid, it still does not bring any output run by my user with dumpcap -D. Well, if the owner of

[Wireshark-dev] Gerrit StartSSL OpenID provider

2014-10-19 Thread Peter Wu
Hi, Has anyone tried to link a StartSSL identity in Gerrit? I just tried to do so, but get a 401 Unauthorized back in Gerrit. Although not available in the UI, you can chose your own OpenID provider by hitting one of the provider buttons (e.g. StartSSL), then cancel by hitting Esc (Stop). Use

Re: [Wireshark-dev] QT with cmake

2014-10-21 Thread Peter Wu
On Tuesday 21 October 2014 11:20:54 Dario Lombardo wrote: I tried to compile the master of wireshark using cmake. mkdir build cd build cmake .. make In run/ I can find wireshark-gtk but not qt. Any specific command to pass to cmake to have it? I am able to obtain qt executable using

Re: [Wireshark-dev] QT with cmake

2014-10-21 Thread Peter Wu
On Tuesday 21 October 2014 13:12:18 Dario Lombardo wrote: Well... after installing some other qt5 packages I get CMake Error at ui/qt/CMakeLists.txt:306 (QT5_ADD_TRANSLATION): Unknown CMake command QT5_ADD_TRANSLATION. On Arch Linux, the package qt5-tools provides the following file which

Re: [Wireshark-dev] QT with cmake

2014-10-21 Thread Peter Wu
On Tuesday 21 October 2014 14:11:25 Dario Lombardo wrote: On Tue, Oct 21, 2014 at 1:20 PM, Peter Wu pe...@lekensteyn.nl wrote: What distro are you using? For Debian/Ubuntu you need to install qttools5-dev. It is exactly what I'm using (ubuntu 14.04). I've installed qttools5-dev

Re: [Wireshark-dev] Wireshark dissector development - Reassembly tcp frames

2014-11-05 Thread Peter Wu
On Tuesday 04 November 2014 11:48:03 Guillaume Ribière wrote: I read the readme.dissector and try using two methods: First method: tcp_dissect_pdus(tvb, pinfo, tree, dns_desegment, 2, get_dns_pdu_len, dissect_dns_tcp_pdu, data); return

Re: [Wireshark-dev] On which platforms is there a need for Wireshark to have a Language preference?

2014-11-24 Thread Peter Wu
On Monday 24 November 2014 23:45:11 Andreas Sikkema wrote: Here's an example, a forum that I use quite frequently. When I set Firefox to Dutch, The links for Login and Registration get translated to Aanmelden and Registreren. In my mind, Aanmelden and Registreren both mean Registration. So now

Re: [Wireshark-dev] On which platforms is there a need for Wireshark to have a Language preference?

2014-11-25 Thread Peter Wu
*sigh* this was supposed to be off-list. On Tuesday 25 November 2014 00:36:13 Peter Wu wrote: On Monday 24 November 2014 23:45:11 Andreas Sikkema wrote: Here's an example, a forum that I use quite frequently. When I set Firefox to Dutch, The links for Login and Registration get translated

Re: [Wireshark-dev] Petri Dish update

2014-11-25 Thread Peter Wu
On Tuesday 25 November 2014 23:37:26 Pascal Quantin wrote: 2014-11-25 18:59 GMT+01:00 Alexis La Goutte alexis.lagou...@gmail.com: For information, I have add the check of last commit the Ubuntu Petri Dish buildbot launch a ./tools/pre-commit HEAD^1 (launch check[APIs|hf|filenames] on

[Wireshark-dev] Crash in capture dialog, monitor changed callback (bug 10685)

2014-11-28 Thread Peter Wu
Hi, I came across a duplicated piece of code by grepping for the string DLT n which I originally found in ui/gtk/capture_dlg.c. Two questions: - Can somebody reduce the duplication (two occurrences in ui/gtk/capture_dlg.c, one in ui/qt/manage_interfaces_dialog.cpp)? - Why is the callback

[Wireshark-dev] PSA: QString.toUtf8().constData() pattern is unsafe

2014-11-28 Thread Peter Wu
Hi all, I mostly use Wireshark GTK, but just tried the Qt UI again. A recurring problem was an ASAN crash on shutdown. It turns out that there are many users of this pattern: recent_add_cfilter(NULL, currentText().toUtf8().constData()); This is unsafe as currentText().toUtf8() returns a new

Re: [Wireshark-dev] PSA: QString.toUtf8().constData() pattern is unsafe

2014-11-28 Thread Peter Wu
text_utf8 that stays allocated until the scope is left, then its distructor is called. Maybe you are confused with the new keyword which would require you to add delete to destruct an object? Peter On Fri, Nov 28, 2014 at 2:13 PM, Peter Wu pe...@lekensteyn.nl wrote: Hi all, I mostly use Wireshark

Re: [Wireshark-dev] PSA: QString.toUtf8().constData() pattern is unsafe

2014-11-29 Thread Peter Wu
On Saturday 29 November 2014 00:38:34 John Sullivan wrote: On Friday, November 28, 2014, 7:13:26 PM, Peter Wu wrote: Hi all, I mostly use Wireshark GTK, but just tried the Qt UI again. A recurring problem was an ASAN crash on shutdown. It turns out that there are many users

Re: [Wireshark-dev] TCP reassembly and Return value of a new-style dissector

2014-12-10 Thread Peter Wu
On Tuesday 09 December 2014 21:01:37 Anders Broman wrote: Hi, I have recently come across some problems with reassembly of SIP messages over TCP. One problem seems to be related to when a segment contains one full PDU and a segment of the next (following) PDU (in this case the first SIP

[Wireshark-dev] Getting involved with Wireshark (was: Re: What Wireshark base version to use for customization)

2014-12-10 Thread Peter Wu
Hi, (This is kind of off-topic, start a new thread for such questions.) On Wednesday 10 December 2014 15:29:03 pogiako wrote: I'm looking for something something to work on for my thesis. I'm a Free Software guy and I thought of contributing to Wireshark is great idea. I'm doing an

Re: [Wireshark-dev] nflog in qt and gtk

2014-12-19 Thread Peter Wu
On Friday 19 December 2014 11:08:01 Dario Lombardo wrote: On Thu, Dec 18, 2014 at 4:29 PM, Peter Wu pe...@lekensteyn.nl wrote: You should not run Wireshark with sudo, instead set the appropriate privileges on the dumpcap binary as described at http://wiki.wireshark.org/CaptureSetup

Re: [Wireshark-dev] nflog in qt and gtk

2014-12-19 Thread Peter Wu
On Friday 19 December 2014 11:55:47 Dario Lombardo wrote: On Fri, Dec 19, 2014 at 11:44 AM, Peter Wu pe...@lekensteyn.nl wrote: Nope, it won't work at the moment. The problem is that NFLOG can only be opened by one user which is a kernel limitation. From net/netfilter/nfnetlink_log.c

Re: [Wireshark-dev] nflog in qt and gtk

2014-12-19 Thread Peter Wu
On Friday 19 December 2014 17:07:20 Dario Lombardo wrote: On Fri, Dec 19, 2014 at 12:35 PM, Peter Wu pe...@lekensteyn.nl wrote: The Capture - Options dialog is another place where these stats are visible. Is it visible during capture? No, it is not visible during capture. The options

Re: [Wireshark-dev] Our Git URLs: https vs ssh

2015-01-02 Thread Peter Wu
Hi Stephen, On Friday 02 January 2015 15:34:46 Stephen Fisher wrote: I've seen two URLs for getting Wireshark via Git: https://code.wireshark.org/review/wireshark and ssh://my.usern...@code.wireshark.org:29418/wireshark The first one is mentioned in the

Re: [Wireshark-dev] Copying of filters from the filter tool bar with ctrl-c is broken

2015-02-04 Thread Peter Wu
a look at it after finishing the STARTTLS patches. -- Kind regards, Peter Wu https://lekensteyn.nl/ ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark

Re: [Wireshark-dev] Two Descrypted SSL data sections in one frame

2015-02-08 Thread Peter Wu
, or is there a preceding STARTTLS-like handshake? In the latter case, see https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9515 and the related patches. -- Kind regards, Peter Wu https://lekensteyn.nl/ [1]: https://en.wikipedia.org/wiki/Transport_Layer_Security#BEAST_attack

[Wireshark-dev] What is the data parameter of call_dissector_with_data?

2015-01-30 Thread Peter Wu
it at all for example besides marking it as unused. -- Kind regards, Peter Wu https://lekensteyn.nl/ ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark

[Wireshark-dev] Supported Python versions?

2015-03-22 Thread Peter Wu
regards, Peter Wu https://lekensteyn.nl [1]: https://code.wireshark.org/review/7779 [2]: https://code.wireshark.org/review/#/q/status:open+project:wireshark+branch:master+topic:python3,n,z ___ Sent via:Wireshark-dev mailing

[Wireshark-dev] Qt: Convert ProtoTree from QTreeWidget to Model/View

2015-03-09 Thread Peter Wu
Model/View, I would like to solicit for some feedback. Was the QTreeWidget choice done consciously? Do you foresee issues with sharing field items via the same model? Is someone already working on this? -- Kind regards, Peter Wu https://lekensteyn.nl

Re: [Wireshark-dev] Qt: Convert ProtoTree from QTreeWidget to Model/View

2015-03-09 Thread Peter Wu
On Mon, Mar 09, 2015 at 11:44:21AM -0700, Gerald Combs wrote: On 3/9/15 7:56 AM, Peter Wu wrote: Hi, I have recently discovered that the Qt UI gets in an inconsistent state (leading to crashes) whenever a packet dialog is open and packets are re-dissected. This is reported at https

Re: [Wireshark-dev] Qt: Convert ProtoTree from QTreeWidget to Model/View

2015-03-09 Thread Peter Wu
On Mon, Mar 09, 2015 at 02:19:20PM -0700, Gerald Combs wrote: On 3/9/15 1:32 PM, Peter Wu wrote: On Mon, Mar 09, 2015 at 11:44:21AM -0700, Gerald Combs wrote: On 3/9/15 7:56 AM, Peter Wu wrote: Hi, I have recently discovered that the Qt UI gets in an inconsistent state (leading

Re: [Wireshark-dev] Qt: Convert ProtoTree from QTreeWidget to Model/View

2015-03-09 Thread Peter Wu
On Mon, Mar 09, 2015 at 02:39:20PM -0700, Guy Harris wrote: On Mar 9, 2015, at 1:32 PM, Peter Wu pe...@lekensteyn.nl wrote: As far as I know, you can only have one open capture file. Correct me if I am wrong. That's currently the case, but let's not wire that assumption in; a proper

Re: [Wireshark-dev] Qt: Convert ProtoTree from QTreeWidget to Model/View

2015-03-10 Thread Peter Wu
On Mon, Mar 09, 2015 at 05:25:10PM -0700, Gerald Combs wrote: On 3/9/15 4:14 PM, Peter Wu wrote: On Mon, Mar 09, 2015 at 02:19:20PM -0700, Gerald Combs wrote: On 3/9/15 1:32 PM, Peter Wu wrote: On Mon, Mar 09, 2015 at 11:44:21AM -0700, Gerald Combs wrote: On 3/9/15 7:56 AM, Peter Wu wrote

Re: [Wireshark-dev] Make CMake reuse Makefile.common?

2015-03-06 Thread Peter Wu
on an out-of-tree cmake build failed because it couldn't find the right init.lua file. This likely happened because of the build dir is not correctly used in cmake builds. See https://code.wireshark.org/review/7453 -- Kind regards, Peter Wu https://lekensteyn.nl

Re: [Wireshark-dev] Make CMake reuse Makefile.common?

2015-03-06 Thread Peter Wu
On Tue, Mar 03, 2015 at 05:50:10PM +0100, Alexis La Goutte wrote: On Mon, Mar 2, 2015 at 1:16 PM, Peter Wu pe...@lekensteyn.nl wrote: Hi, Recently there have been two issues due to separate copies between CMake and autofoo (missing ATH dissector, missing field registrations

Re: [Wireshark-dev] WS runtime error

2015-03-06 Thread Peter Wu
missing. I'll cook a patch for this. -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe

Re: [Wireshark-dev] My recent build of Wireshark from the master branch consumes 99-100% of the CPU

2015-03-11 Thread Peter Wu
there is a known issue with the Qt auto-scroll feature that is being investigated. OK, thanks. It is probably this bug: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11035 -- Kind regards, Peter Wu https://lekensteyn.nl

[Wireshark-dev] Dropping tcp.pdu.size? (was: Re: Buildbot test failures - wslua)

2015-03-11 Thread Peter Wu
in tshark? So, what about removing tcp.pdu.size? Are there any objections? Most users seem to encounter it, but not use it (see bug report). -- Kind regards, Peter Wu https://lekensteyn.nl [1]: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11007 [2]: https://www.wireshark.org/lists

Re: [Wireshark-dev] Supported Python versions?

2015-03-24 Thread Peter Wu
On Sun, Mar 22, 2015 at 04:58:14PM +0100, Pascal Quantin wrote: 2015-03-22 16:48 GMT+01:00 Peter Wu pe...@lekensteyn.nl: Hi, Triggered by a build error due to html2text.py, I have recently started with adding Python 3 support to various Python scripts[1][2]. The change to html2text.py

[Wireshark-dev] Make CMake reuse Makefile.common?

2015-03-02 Thread Peter Wu
, and (as an experimental option) cmake. See this transformation macro[0] and its use[1] for an example. -- Kind regards, Peter Wu https://lekensteyn.nl [0]: https://github.com/bagder/curl/blob/master/CMakeLists.txt#L986 [1]: https://github.com/bagder/curl/blob/master/tests/libtest/CMakeLists.txt#L31

Re: [Wireshark-dev] SSL/DTLS: allow setting of app data dissector when using keylog file

2015-02-23 Thread Peter Wu
for older Wireshark versions (and other implementations using this file, if they exist). -- Kind regards, Peter Wu https://lekensteyn.nl pgpBCbqhm04ke.pgp Description: PGP signature ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] SSL/DTLS: allow setting of app data dissector when using keylog file

2015-02-23 Thread Peter Wu
On Mon, Feb 23, 2015 at 10:49:55PM +0100, Peter Wu wrote: On Mon, Feb 23, 2015 at 03:32:48PM +0100, Gianrico wrote: I propose to make one or more of these changes: - Call the heuristics dissector only for the first data frame. I forgot to mention the 1/n-1 splitting which is nowadays

Re: [Wireshark-dev] Use of tcp_dissect_pdus() with a protocol which has a variable length PDU length field

2015-02-20 Thread Peter Wu
Hi, While looking at improving the Websocket dissector, I found the need to support variable length fields in tcp_dissect_pdus. Here is Bills original mail (which had no replies). On Fri, May 09, 2014 at 11:02:45AM -0400, Bill Meier wrote: To: TCP re-assembly experts: The MQTT protocol

Re: [Wireshark-dev] Can we put android phone device connected over USB to Win 7 PC in promiscous mode?

2015-02-26 Thread Peter Wu
On Wed, Feb 25, 2015 at 07:52:03AM +0100, Michal Labedzki wrote: On 24 February 2015 at 23:03, Peter Wu pe...@lekensteyn.nl wrote: Before you attempt to use the output of `adb shell` in a pipe, keep in mind that adb mangles newlines (LF - CRLF) and is therefore unsuitable for binary data

Re: [Wireshark-dev] Can we put android phone device connected over USB to Win 7 PC in promiscous mode?

2015-02-24 Thread Peter Wu
that Glib was missing. If you just want to debug an app on the phone, it is much easier to setup a VPN/proxy and start tapping at the VPN or proxy server. -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev

Re: [Wireshark-dev] Wireshark messages I don't want to see

2015-07-14 Thread Peter Wu
is needed to get rid of the first 3 messages in particular. A stacktrace would be helpful :-) -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives

Re: [Wireshark-dev] CMake: Disable building with QT ?

2015-11-12 Thread Peter Wu
Try cmake -DBUILD_wireshark=0 (case is significant). These options are defined in CMakeOptions.txt which you can also find via invocation of cmake-gui. Kind regards, Peter https://lekensteyn.nl (pardon my brevity, top-posting and formatting, sent from my phone) On 12 November 2015 19:13:07

Re: [Wireshark-dev] Supported GnuTLS/glib/libgcrypt versions?

2015-10-15 Thread Peter Wu
On Thu, Oct 15, 2015 at 12:03:41PM -0700, Guy Harris wrote: > > On Oct 14, 2015, at 11:25 AM, Peter Wu <pe...@lekensteyn.nl> wrote: > > > Looks like GnuTLS is only needed if you have to supply a RSA private > > key. > > How much of it doe we use? > > If

Re: [Wireshark-dev] Supported GnuTLS/glib/libgcrypt versions?

2015-10-15 Thread Peter Wu
On Thu, Oct 15, 2015 at 08:44:56PM +0200, Anders Broman wrote: > Den 15 okt 2015 19:43 skrev "Jeff Morriss" <jeff.morriss...@gmail.com>: > > > > On 10/14/15 14:25, Peter Wu wrote: > >> > >> On Mon, Oct 12, 2015 at 02:02:18PM -0400, Jeff Morriss wr

Re: [Wireshark-dev] Supported GnuTLS/glib/libgcrypt versions?

2015-10-14 Thread Peter Wu
On Mon, Oct 12, 2015 at 02:02:18PM -0400, Jeff Morriss wrote: > On 10/11/15 17:32, Peter Wu wrote: > >Hi, > > > >Michal reported to me that a recent change in the SSL dissector was not > >compatible with older GnuTLS versions[1]. > > > >The

[Wireshark-dev] Supported GnuTLS/glib/libgcrypt versions?

2015-10-11 Thread Peter Wu
/Support_library_version_tracking -- Kind regards, Peter Wu https://lekensteyn.nl [2]: https://code.wireshark.org/review/#/c/10766/6/epan/dissectors/packet-ssl-utils.c@52 ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] FILETIME to nstime_t conversions gives a warning

2015-10-07 Thread Peter Wu
Hi Guy, Thank you for your detailed reply. On Mon, Oct 05, 2015 at 08:11:55AM -0700, Guy Harris wrote: > > On Oct 4, 2015, at 6:09 AM, Peter Wu <pe...@lekensteyn.nl> wrote: > > > I am getting these compile warnings using Clang 3.7.0: > > > >wsutil/n

[Wireshark-dev] Minimum supported library versions?

2015-07-10 Thread Peter Wu
am wrong). Shall we use bump the library requirements for the 2.0 release too? (glib2, gcrypt, ...)? Is there a list of the real requirements, including versions? (wiki? configure.ac is a bit harder to provide an overview.) -- Kind regards, Peter Wu https://lekensteyn.nl [1]: http

Re: [Wireshark-dev] asn2wrs documentation?

2015-09-16 Thread Peter Wu
IMPORT_TAG is used for (it is only used in one place)? Thanks, Peter > Best regards, >Tomas > > > On 15.9.2015 13:46, Peter Wu wrote: > > Hi, > > > > I am working on improving dissection support of the subjectPublicKey > > field in X.509 Certificates[1]. Righ

[Wireshark-dev] asn2wrs documentation?

2015-09-15 Thread Peter Wu
e familiar with the asn2wrs script, is it possible to update the wiki? Are there other documentation resources available? -- Kind regards, Peter Wu https://lekensteyn.nl [1]: https://git.lekensteyn.nl/peter/wireshark/commit/?h=lkn/x509-subjectpublickey-v2 [2]: https://wiki.wireshark.org/Asn2wr

[Wireshark-dev] Use of variadic macros

2015-10-01 Thread Peter Wu
? -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org

[Wireshark-dev] Improving the SSL keys dialog, how to handle migrations?

2015-10-03 Thread Peter Wu
es not already exist (but this makes the code more ugly). Suggestions are welcome! -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives:

Re: [Wireshark-dev] Improving the SSL keys dialog, how to handle migrations?

2015-10-03 Thread Peter Wu
On Sat, Oct 03, 2015 at 07:05:50PM +0200, Pascal Quantin wrote: > Hi Peter, > > Some general comments in-line. I'm not a user of SSL/DTLS dissectors so I > do not have any real suggestion for your proposals. > > Le 3 oct. 2015 6:53 PM, "Peter Wu" <pe...@leke

[Wireshark-dev] FILETIME to nstime_t conversions gives a warning

2015-10-04 Thread Peter Wu
MAX) { *nt = 0x7fffLL; return; } if (t == 0) { *nt = 0; return; } t2 = t; t2 += TIME_FIXUP_CONSTANT_INT; t2 *= 1000*1000*10; *nt = t2; } Shouldn't we do the same then? (Guy?) --

Re: [Wireshark-dev] Use of variadic macros

2015-10-04 Thread Peter Wu
orted even in c90 mode on gcc 5.2.0 and clang 3.7.0. After reading the gcc manual page, I've decided to settle with -Wno-variadic-macros. Patch is at https://code.wireshark.org/review/10781 -- Kind regards, Peter Wu https://lekensteyn.nl

Re: [Wireshark-dev] Wireshark 2.01 packages in Ubuntu ppa

2016-01-09 Thread Peter Wu
ry to reproduce the issue with a clean configuration? Example: HOME=/tmp/wshome wireshark -- Kind regards, Peter Wu https://lekensteyn.nl ___ Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives:

[Wireshark-dev] Automated Windows build setup? (Chocolatey?)

2015-11-25 Thread Peter Wu
see about a script is from 2013 (https://www.wireshark.org/lists/wireshark-dev/201312/msg00041.html). -- Kind regards, Peter Wu https://lekensteyn.nl @echo off Z: :: 2015-11-04 :: https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html ::chocolatey feature enable -n allowGlobalCo

Re: [Wireshark-dev] Automated RPM-based-Linux build setup? (was Re: Automated Windows build setup? (Chocolatey?))

2015-11-26 Thread Peter Wu
On Wed, Nov 25, 2015 at 02:51:18PM -0800, Guy Harris wrote: > > On Nov 25, 2015, at 2:44 PM, Guy Harris <g...@alum.mit.edu> wrote: > > > On Nov 25, 2015, at 11:01 AM, Peter Wu <pe...@lekensteyn.nl> wrote: > > > >> Has there been any progress/work on a

Re: [Wireshark-dev] Wireshark 2.01 packages in Ubuntu ppa

2016-01-12 Thread Peter Wu
On Sun, Jan 10, 2016 at 11:52:39AM +0100, Bálint Réczey wrote: > Hi, > > 2016-01-09 16:40 GMT+01:00 Peter Wu <pe...@lekensteyn.nl>: > > Hi Bernard, > > > > On Thu, Jan 07, 2016 at 12:31:12PM -0500, bernard ck Wong wrote: > >> I have installed wireshark

  1   2   3   >