Re: [Wireshark-dev] [Wireshark-commits] master d347091: Qt: Fix MacOSX menu entries
There is general support for dropping autotools on master (after fixing the rpm build). But I'll rewrite the patches for 2.4 and 2.6 to add a compile switch, so that the patch only applies if it is build with cmake. Adding Objective-C builds to auto tools seems pointless at this point, to me at least. regards Roland On Tue, Apr 10, 2018 at 3:49 AM, Guy Harriswrote: > On Apr 9, 2018, at 8:44 AM, Wireshark code review < > code-review-do-not-re...@wireshark.org> wrote: > > > URL: https://code.wireshark.org/review/gitweb?p=wireshark.git; > a=commit;h=d347091da962a3bb095c62339fc6faa07d189a9f > > Submitter: Roland Knall (rkn...@gmail.com) > > Changed: branch: master > > Repository: wireshark > > > > Commits: > > > > d347091 by Roland Knall (rkn...@gmail.com): > > > >Qt: Fix MacOSX menu entries > > This doesn't built with autotools. > > Autotools already has problems with Qt on macOS, and I think there was > some talk about abandoning autotools support in 3.0; is it time to get rid > of autotools support, at least in the master branch, in general, or even > just on macOS (there's no Windows autotools support to get rid of)? > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject= > unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master d347091: Qt: Fix MacOSX menu entries
Den tis 10 apr. 2018 03:50Guy Harrisskrev: > On Apr 9, 2018, at 8:44 AM, Wireshark code review < > code-review-do-not-re...@wireshark.org> wrote: > > > URL: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d347091da962a3bb095c62339fc6faa07d189a9f > > Submitter: Roland Knall (rkn...@gmail.com) > > Changed: branch: master > > Repository: wireshark > > > > Commits: > > > > d347091 by Roland Knall (rkn...@gmail.com): > > > >Qt: Fix MacOSX menu entries > > This doesn't built with autotools. > > Autotools already has problems with Qt on macOS, and I think there was > some talk about abandoning autotools support in 3.0; is it time to get rid > of autotools support, at least in the master branch, in general, or even > just on macOS (there's no Windows autotools support to get rid of)? > I have problems generating rpm on SuSE 12.2 which I consider blocking removal of autotools. Regards Anders > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master d347091: Qt: Fix MacOSX menu entries
On Apr 9, 2018, at 8:44 AM, Wireshark code reviewwrote: > URL: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d347091da962a3bb095c62339fc6faa07d189a9f > Submitter: Roland Knall (rkn...@gmail.com) > Changed: branch: master > Repository: wireshark > > Commits: > > d347091 by Roland Knall (rkn...@gmail.com): > >Qt: Fix MacOSX menu entries This doesn't built with autotools. Autotools already has problems with Qt on macOS, and I think there was some talk about abandoning autotools support in 3.0; is it time to get rid of autotools support, at least in the master branch, in general, or even just on macOS (there's no Windows autotools support to get rid of)? ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe