Re: [Wireshark-dev] Patch submission via e-mail/mailing list

2024-06-04 Thread Jaap Keuter 
Hi Bruno,

Indeed GitLab is currently the preferred way of working, so this is going in 
the right direction.

Good luck,
Jaap

> On 4 Jun 2024, at 17:29, Bruno Mauricio  
> wrote:
> 
> Alexis started pointing out some typos there, so I fixed them promptly.
> 
> Noone said anything but I guess it's better to finish up via gitlab.
> 
> Thank you very much for your support guys :)
> 
> Best regards,
> 
> Bruno Mauricio
> 
> On 6/4/24 4:14 PM, chuck c wrote:
>> https://gitlab.com/wireshark/wireshark/-/merge_requests/15850
>> 
>> Looks like there is work being done via the standard process?
>> 
>> On Tue, Jun 4, 2024 at 8:28 AM Bruno Mauricio via Wireshark-dev 
>> mailto:wireshark-dev@wireshark.org>> wrote:
>>> Hello again,
>>> 
>>> Just as I sent my previous e-mail, I got a confirmation from gitlab 
>>> about false flagging my account, which got reinstated and my Merge 
>>> Request reappeared.
>>> 
>>> Should we proceed via e-mails and I close the MR, or via the normal 
>>> procedure?
>>> 
>>> Apologies for the noise/spam,
>>> 
>>> Bruno Mauricio
>>> 
>>> 
>>> On 6/4/24 2:22 PM, Bruno Mauricio via Wireshark-dev wrote:
>>> > Thank you very much for your reply,
>>> >
>>> >
>>> > I have attached the patch for Zigbee NCP dissector update in wireshark.
>>> >
>>> > I also attached a pcap which contains the added packets.
>>> >
>>> > Running wireshark (without the patch) shows a bunch of "Unknown Call 
>>> > ID" for packets which are now present with the patch.
>>> >
>>> > In case there is any issue please feel free to contact me directly, if 
>>> > you prefer not to spam this mailing list with those messages.
>>> >
>>> >
>>> > Best regards,
>>> >
>>> > Bruno Mauricio
>>> >
>>> >
>>> > On 6/4/24 2:03 PM, Jaap Keuter wrote:
>>> >> Hi,
>>> >>
>>> >> First of all, sorry that GitLab gives you grief. Please do follow up 
>>> >> on the ticket, they usually seem to be open to address such issues 
>>> >> AFIACT.
>>> >>
>>> >> As for the patch, this used to be the channel through which these 
>>> >> were collected, before GitLab^WGerrit^WBugzilla.
>>> >> So please go ahead and attach one here, and we’ll see what we can do.
>>> >>
>>> >> Thanks,
>>> >> Jaap
>>> >>
>>> >>
>>> >>> On 4 Jun 2024, at 12:48, Bruno Mauricio via Wireshark-dev 
>>> >>> mailto:wireshark-dev@wireshark.org>> 
>>> >>> wrote:
>>> >>>
>>> >>> Hello,
>>> >>>
>>> >>>
>>> >>> I created a Gitlab account just to send a patch for wireshark but it 
>>> >>> was banned a few minutes after I created the Merge Request.
>>> >>>
>>> >>> I tried creating a different account using gmail (and not this work 
>>> >>> e-mail, thought that might be the issue) but as soon as I input my 
>>> >>> phone number, it got banned as well. My number must have been 
>>> >>> flagged for some reason.
>>> >>>
>>> >>> I already opened a ticket but assume it will be some time until I 
>>> >>> get an answer back.
>>> >>>
>>> >>> In the meantime, what would be the better approach to submitting a 
>>> >>> patch without a gitlab account?
>>> >>>
>>> >>> Is this mailing list, or perhaps the Wireshark-commits mailing list 
>>> >>> appropriate for uploading a patch for review?
>>> >>>
>>> >>> Or should I sent it directly to a maintainer and if so to which 
>>> >>> e-mail address?
>>> >>>
>>> >>>
>>> >>> Thank you for your attention.
>>> >>>
>>> >>> Best regards,
>>> >>>
>>> >>> Bruno Mauricio
>>> >
>>> > ___
>>> > Sent via:Wireshark-dev mailing list >> > >
>>> > Archives:https://www.wireshark.org/lists/wireshark-dev
>>> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>> >   mailto:wireshark-dev-requ...@wireshark.org 
>>> > ?subject=unsubscribe
>>> ___
>>> Sent via:Wireshark-dev mailing list >> >
>>> Archives:https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>  mailto:wireshark-dev-requ...@wireshark.org 
>>> ?subject=unsubscribe
>> 
>> 
>> ___
>> Sent via:Wireshark-dev mailing list  
>> 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Patch submission via e-mail/mailing list

2024-06-04 Thread Bruno Mauricio via Wireshark-dev 

Alexis started pointing out some typos there, so I fixed them promptly.

Noone said anything but I guess it's better to finish up via gitlab.

Thank you very much for your support guys :)

Best regards,

Bruno Mauricio

On 6/4/24 4:14 PM, chuck c wrote:

https://gitlab.com/wireshark/wireshark/-/merge_requests/15850

Looks like there is work being done via the standard process?

On Tue, Jun 4, 2024 at 8:28 AM Bruno Mauricio via Wireshark-dev 
 wrote:


Hello again,

Just as I sent my previous e-mail, I got a confirmation from gitlab
about false flagging my account, which got reinstated and my Merge
Request reappeared.

Should we proceed via e-mails and I close the MR, or via the normal
procedure?

Apologies for the noise/spam,

Bruno Mauricio


On 6/4/24 2:22 PM, Bruno Mauricio via Wireshark-dev wrote:
> Thank you very much for your reply,
>
>
> I have attached the patch for Zigbee NCP dissector update in
wireshark.
>
> I also attached a pcap which contains the added packets.
>
> Running wireshark (without the patch) shows a bunch of "Unknown
Call
> ID" for packets which are now present with the patch.
>
> In case there is any issue please feel free to contact me
directly, if
> you prefer not to spam this mailing list with those messages.
>
>
> Best regards,
>
> Bruno Mauricio
>
>
> On 6/4/24 2:03 PM, Jaap Keuter wrote:
>> Hi,
>>
>> First of all, sorry that GitLab gives you grief. Please do
follow up
>> on the ticket, they usually seem to be open to address such issues
>> AFIACT.
>>
>> As for the patch, this used to be the channel through which these
>> were collected, before GitLab^WGerrit^WBugzilla.
>> So please go ahead and attach one here, and we’ll see what we
can do.
>>
>> Thanks,
>> Jaap
>>
>>
>>> On 4 Jun 2024, at 12:48, Bruno Mauricio via Wireshark-dev
>>>  wrote:
>>>
>>> Hello,
>>>
>>>
>>> I created a Gitlab account just to send a patch for wireshark
but it
>>> was banned a few minutes after I created the Merge Request.
>>>
>>> I tried creating a different account using gmail (and not this
work
>>> e-mail, thought that might be the issue) but as soon as I
input my
>>> phone number, it got banned as well. My number must have been
>>> flagged for some reason.
>>>
>>> I already opened a ticket but assume it will be some time until I
>>> get an answer back.
>>>
>>> In the meantime, what would be the better approach to
submitting a
>>> patch without a gitlab account?
>>>
>>> Is this mailing list, or perhaps the Wireshark-commits mailing
list
>>> appropriate for uploading a patch for review?
>>>
>>> Or should I sent it directly to a maintainer and if so to which
>>> e-mail address?
>>>
>>>
>>> Thank you for your attention.
>>>
>>> Best regards,
>>>
>>> Bruno Mauricio
>
>
___
> Sent via:    Wireshark-dev mailing list

> Archives: https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>             
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:    Wireshark-dev mailing list 
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
           
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


___
Sent via:Wireshark-dev mailing list
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe:https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Patch submission via e-mail/mailing list

2024-06-04 Thread chuck c 
https://gitlab.com/wireshark/wireshark/-/merge_requests/15850

Looks like there is work being done via the standard process?

On Tue, Jun 4, 2024 at 8:28 AM Bruno Mauricio via Wireshark-dev <
wireshark-dev@wireshark.org> wrote:

> Hello again,
>
> Just as I sent my previous e-mail, I got a confirmation from gitlab
> about false flagging my account, which got reinstated and my Merge
> Request reappeared.
>
> Should we proceed via e-mails and I close the MR, or via the normal
> procedure?
>
> Apologies for the noise/spam,
>
> Bruno Mauricio
>
>
> On 6/4/24 2:22 PM, Bruno Mauricio via Wireshark-dev wrote:
> > Thank you very much for your reply,
> >
> >
> > I have attached the patch for Zigbee NCP dissector update in wireshark.
> >
> > I also attached a pcap which contains the added packets.
> >
> > Running wireshark (without the patch) shows a bunch of "Unknown Call
> > ID" for packets which are now present with the patch.
> >
> > In case there is any issue please feel free to contact me directly, if
> > you prefer not to spam this mailing list with those messages.
> >
> >
> > Best regards,
> >
> > Bruno Mauricio
> >
> >
> > On 6/4/24 2:03 PM, Jaap Keuter wrote:
> >> Hi,
> >>
> >> First of all, sorry that GitLab gives you grief. Please do follow up
> >> on the ticket, they usually seem to be open to address such issues
> >> AFIACT.
> >>
> >> As for the patch, this used to be the channel through which these
> >> were collected, before GitLab^WGerrit^WBugzilla.
> >> So please go ahead and attach one here, and we’ll see what we can do.
> >>
> >> Thanks,
> >> Jaap
> >>
> >>
> >>> On 4 Jun 2024, at 12:48, Bruno Mauricio via Wireshark-dev
> >>>  wrote:
> >>>
> >>> Hello,
> >>>
> >>>
> >>> I created a Gitlab account just to send a patch for wireshark but it
> >>> was banned a few minutes after I created the Merge Request.
> >>>
> >>> I tried creating a different account using gmail (and not this work
> >>> e-mail, thought that might be the issue) but as soon as I input my
> >>> phone number, it got banned as well. My number must have been
> >>> flagged for some reason.
> >>>
> >>> I already opened a ticket but assume it will be some time until I
> >>> get an answer back.
> >>>
> >>> In the meantime, what would be the better approach to submitting a
> >>> patch without a gitlab account?
> >>>
> >>> Is this mailing list, or perhaps the Wireshark-commits mailing list
> >>> appropriate for uploading a patch for review?
> >>>
> >>> Or should I sent it directly to a maintainer and if so to which
> >>> e-mail address?
> >>>
> >>>
> >>> Thank you for your attention.
> >>>
> >>> Best regards,
> >>>
> >>> Bruno Mauricio
> >
> >
> ___
> > Sent via:Wireshark-dev mailing list 
> > Archives:https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >   mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Patch submission via e-mail/mailing list

2024-06-04 Thread Bruno Mauricio via Wireshark-dev 

Hello again,

Just as I sent my previous e-mail, I got a confirmation from gitlab 
about false flagging my account, which got reinstated and my Merge 
Request reappeared.


Should we proceed via e-mails and I close the MR, or via the normal 
procedure?


Apologies for the noise/spam,

Bruno Mauricio


On 6/4/24 2:22 PM, Bruno Mauricio via Wireshark-dev wrote:

Thank you very much for your reply,


I have attached the patch for Zigbee NCP dissector update in wireshark.

I also attached a pcap which contains the added packets.

Running wireshark (without the patch) shows a bunch of "Unknown Call 
ID" for packets which are now present with the patch.


In case there is any issue please feel free to contact me directly, if 
you prefer not to spam this mailing list with those messages.



Best regards,

Bruno Mauricio


On 6/4/24 2:03 PM, Jaap Keuter wrote:

Hi,

First of all, sorry that GitLab gives you grief. Please do follow up 
on the ticket, they usually seem to be open to address such issues 
AFIACT.


As for the patch, this used to be the channel through which these 
were collected, before GitLab^WGerrit^WBugzilla.

So please go ahead and attach one here, and we’ll see what we can do.

Thanks,
Jaap


On 4 Jun 2024, at 12:48, Bruno Mauricio via Wireshark-dev 
 wrote:


Hello,


I created a Gitlab account just to send a patch for wireshark but it 
was banned a few minutes after I created the Merge Request.


I tried creating a different account using gmail (and not this work 
e-mail, thought that might be the issue) but as soon as I input my 
phone number, it got banned as well. My number must have been 
flagged for some reason.


I already opened a ticket but assume it will be some time until I 
get an answer back.


In the meantime, what would be the better approach to submitting a 
patch without a gitlab account?


Is this mailing list, or perhaps the Wireshark-commits mailing list 
appropriate for uploading a patch for review?


Or should I sent it directly to a maintainer and if so to which 
e-mail address?



Thank you for your attention.

Best regards,

Bruno Mauricio


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Patch submission via e-mail/mailing list

2024-06-04 Thread Bruno Mauricio via Wireshark-dev 

Thank you very much for your reply,


I have attached the patch for Zigbee NCP dissector update in wireshark.

I also attached a pcap which contains the added packets.

Running wireshark (without the patch) shows a bunch of "Unknown Call ID" 
for packets which are now present with the patch.


In case there is any issue please feel free to contact me directly, if 
you prefer not to spam this mailing list with those messages.



Best regards,

Bruno Mauricio


On 6/4/24 2:03 PM, Jaap Keuter wrote:

Hi,

First of all, sorry that GitLab gives you grief. Please do follow up on the 
ticket, they usually seem to be open to address such issues AFIACT.

As for the patch, this used to be the channel through which these were 
collected, before GitLab^WGerrit^WBugzilla.
So please go ahead and attach one here, and we’ll see what we can do.

Thanks,
Jaap



On 4 Jun 2024, at 12:48, Bruno Mauricio via Wireshark-dev 
 wrote:

Hello,


I created a Gitlab account just to send a patch for wireshark but it was banned 
a few minutes after I created the Merge Request.

I tried creating a different account using gmail (and not this work e-mail, 
thought that might be the issue) but as soon as I input my phone number, it got 
banned as well. My number must have been flagged for some reason.

I already opened a ticket but assume it will be some time until I get an answer 
back.

In the meantime, what would be the better approach to submitting a patch 
without a gitlab account?

Is this mailing list, or perhaps the Wireshark-commits mailing list appropriate 
for uploading a patch for review?

Or should I sent it directly to a maintainer and if so to which e-mail address?


Thank you for your attention.

Best regards,

Bruno Mauricio

ncp.pcap
Description: application/vnd.tcpdump.pcap
From 71fc091400ea4e16db5f946f0268a339d4c6da09 Mon Sep 17 00:00:00 2001
From: Bruno Mauricio 
Date: Tue, 4 Jun 2024 10:38:52 +0100
Subject: [PATCH] zb-ncp: Add r23 packets to dissector

Signed-off-by: Bruno Mauricio 
---
 epan/dissectors/packet-zbncp.c | 540 -
 epan/dissectors/packet-zbncp.h |  30 +-
 2 files changed, 560 insertions(+), 10 deletions(-)

diff --git a/epan/dissectors/packet-zbncp.c b/epan/dissectors/packet-zbncp.c
index 0f72d64efb7c..2ee575ed6bc4 100644
--- a/epan/dissectors/packet-zbncp.c
+++ b/epan/dissectors/packet-zbncp.c
@@ -44,6 +44,15 @@ extern void dissect_zbee_aps_status_code(tvbuff_t *tvb, packet_info *pinfo, prot
 #define ZBNCP_DUMP_HOST_INT_DUMP_MASK  0x02U
 #define ZBNCP_DUMP_POTENTIAL_TX_RX_ERROR_MASK  0x04U
 
+/*  Bit Masks for Configuration Parameters Field   */
+#define CONF_PARAMS_RESERVED0x07
+#define CONF_PARAMS_DIS_PANID_CHANGE0x08
+#define CONF_PARAMS_DIS_CHAN_CHANGE 0x10
+#define CONF_PARAMS_LEAVE_REQ_ALLOW 0x20
+#define CONF_PARAMS_REQ_TCLK0x40
+#define CONF_PARAMS_RESTRICT_MODE_EN0x80
+
+
 /* decryption helpers */
 static guint dissect_zbncp_ll_hdr(tvbuff_t *, packet_info *, proto_tree *, guint, guint8 *);
 static void dissect_zbncp_body(tvbuff_t *, packet_info *, proto_tree *, guint, guint16 *);
@@ -120,6 +129,36 @@ static int hf_zbncp_data_trace_reserved;
 static int hf_zbncp_data_trace_ncp_ll_proto;
 static int hf_zbncp_data_trace_host_int_line;
 static int hf_zbncp_data_trace_sleep_awake;
+static int hf_zbncp_data_trace_input_output;
+static int hf_zbncp_data_trace_timestamp;
+static int hf_zbncp_data_trace;
+static int hf_zbncp_data_key_neg_method;
+static int hf_zbncp_data_psk_secrets;
+static int hf_zbncp_data_r22_join_usage;
+static int hf_zbncp_data_nwk_conf_preset;
+static int hf_zbncp_data_short_address;
+static int hf_zbncp_data_raw_data;
+static int hf_zbncp_data_conf_params;
+static int hf_zbncp_data_channel_page_count;
+static int hf_zbncp_data_config_mask;
+static int hf_zbncp_data_dest_short_address;
+static int hf_zbncp_data_current_parents_short_address;
+static int hf_zbncp_data_current_parents_lqi;
+static int hf_zbncp_data_potential_parent_count;
+static int hf_zbncp_data_classification_mask;
+static int hf_zbncp_data_total_beacons_surveyed;
+static int hf_zbncp_data_current_pan_id_beacons;
+static int hf_zbncp_data_current_nwk_potential_parents;
+static int hf_zbncp_data_other_zigbee_beacons;
+static int hf_zbncp_data_pan_id_conflict_tlv;
+static int hf_zbncp_data_eui64_count;
+static int hf_zbncp_data_eui64;
+static int hf_zbncp_data_target_ieee_addr;
+static int hf_zbncp_data_initial_join_auth;
+static int hf_zbncp_data_key_update_method;
+static int hf_zbncp_data_next_pan_id_change;
+static int hf_zbncp_data_next_channel_change;
+static in

Re: [Wireshark-dev] Patch submission via e-mail/mailing list

2024-06-04 Thread Jaap Keuter 
Hi,

First of all, sorry that GitLab gives you grief. Please do follow up on the 
ticket, they usually seem to be open to address such issues AFIACT.

As for the patch, this used to be the channel through which these were 
collected, before GitLab^WGerrit^WBugzilla.
So please go ahead and attach one here, and we’ll see what we can do.

Thanks,
Jaap


> On 4 Jun 2024, at 12:48, Bruno Mauricio via Wireshark-dev 
>  wrote:
> 
> Hello,
> 
> 
> I created a Gitlab account just to send a patch for wireshark but it was 
> banned a few minutes after I created the Merge Request.
> 
> I tried creating a different account using gmail (and not this work e-mail, 
> thought that might be the issue) but as soon as I input my phone number, it 
> got banned as well. My number must have been flagged for some reason.
> 
> I already opened a ticket but assume it will be some time until I get an 
> answer back.
> 
> In the meantime, what would be the better approach to submitting a patch 
> without a gitlab account?
> 
> Is this mailing list, or perhaps the Wireshark-commits mailing list 
> appropriate for uploading a patch for review?
> 
> Or should I sent it directly to a maintainer and if so to which e-mail 
> address?
> 
> 
> Thank you for your attention.
> 
> Best regards,
> 
> Bruno Mauricio

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe