Re: [WiX-devs] RFC: Binder Variable PublicKeyToken

2013-04-19 Thread Bob Arnson
On 17-Apr-13 15:52, jhennessey wrote: > "bind.assemblyPublicKeyToken" -> "bind.assemblyPublicKeyTokenPreservedCase" > "bind.assemblyFullName" -> "bind.assemblyFullNamePreservedCase" > > Agree? No objections. -- sig://boB http://joyofsetup.com/ --

Re: [WiX-devs] RFC: Binder Variable PublicKeyToken

2013-04-17 Thread jhennessey
Ok, based on the feedback we'll keep the current values the same and add some new ones (I'll be sure to update the documentation as this will be a little confusing). Here's my suggestion for the new variables (again the original will not be removed): "bind.assemblyPublicKeyToken" -> "bind.assembly

Re: [WiX-devs] RFC: Binder Variable PublicKeyToken

2013-04-17 Thread Rob Mensching
IIRC, the uppercasing addresses a bug in Fusion. If we don't do that, some GAC'ing will start failing. Plus, patching will go screwy if we change our mind mid-backwards compatible releases. On Tue, Apr 16, 2013 at 5:48 PM, Bob Arnson wrote: > On 12-Apr-13 15:56, jhennessey wrote: > > That all

Re: [WiX-devs] RFC: Binder Variable PublicKeyToken

2013-04-16 Thread Bob Arnson
On 12-Apr-13 15:56, jhennessey wrote: > That all being said, my gut tells me I should just introduce new binder > variables (without the conversion). I could also just remove the call > "ToUpperInvariant()" but have to believe there is some reason it exists. Agreed, there's probably a reason. :) A

Re: [WiX-devs] RFC: Binder Variable PublicKeyToken

2013-04-12 Thread jhennessey
Another option...fix the binder variables so they contain the correct values and keep the upper invariant for the MsiAssembly table just in case. (Note that the WiX documentation examples actually show the values with lowercase letters as you would expect.) -- View this message in context: htt

[WiX-devs] RFC: Binder Variable PublicKeyToken

2013-04-12 Thread jhennessey
In the past I have tried to use some of the assembly binder variables but couldn't because PublicKeyToken is converted to the upper invariant in the binder (which makes it useless when adding the full assembly name into say a config file). I am going to fix this but want to make sure I don't caus