Re: [WiX-devs] WIP 4149 and 4552

2014-10-13 Thread Heath Stewart
you append methods/data onto the end (vtbl for interfaces) safely. Heath Stewart Software Design Engineer Visual Studio, Microsoft http://blogs.msdn.com/heaths From: r...@firegiant.com To: wix-devs@lists.sourceforge.net Date: Mon, 13 Oct 2014 08:44:25 + Subject: Re: [WiX-devs] WIP 414

Re: [WiX-devs] WIP 4149 and 4552

2014-10-13 Thread Rob Mensching
, 2014 6:27 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] WIP 4149 and 4552 I'll go with callbacks then. I still prefer an interface, but maybe that's just my managed code bias showing. On Sat, Oct 11, 2014 at 7:42 PM, Rob Mensching mailto:r...@firegiant.com>

Re: [WiX-devs] WIP 4149 and 4552

2014-10-12 Thread Sean Hall
ng conditions. > > > > ___ > > FireGiant | Dedicated support for the WiX toolset | > http://www.firegiant.com/ > > > > *From:* Sean Hall [mailto:r.sean.h...@gmail.com] > *Sent:* Saturday, October 11, 2014 9:23 AM > *To:* WiX toolset developer mailin

Re: [WiX-devs] WIP 4149 and 4552

2014-10-11 Thread Rob Mensching
, 2014 9:23 AM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] WIP 4149 and 4552 The motivation for all this work is for thmutil/thmviewer. I'm proposing that thmutil gets access to variables/conditions through the new interface, since it needs the same restricted access. T

Re: [WiX-devs] WIP 4149 and 4552

2014-10-11 Thread Sean Hall
> > FireGiant | Dedicated support for the WiX toolset | > http://www.firegiant.com/ > > > > *From:* Sean Hall [mailto:r.sean.h...@gmail.com] > *Sent:* Friday, October 10, 2014 7:17 PM > *To:* WiX toolset developer mailing list > *Subject:* Re: [WiX-devs] WIP 4149 and 4552 > >

Re: [WiX-devs] WIP 4149 and 4552

2014-10-10 Thread Rob Mensching
? ___ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ From: Sean Hall [mailto:r.sean.h...@gmail.com] Sent: Friday, October 10, 2014 7:17 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] WIP 4149 and 4552 I

Re: [WiX-devs] WIP 4149 and 4552

2014-10-10 Thread Sean Hall
___ > > FireGiant | Dedicated support for the WiX toolset | > http://www.firegiant.com/ > > > > *From:* Sean Hall [mailto:r.sean.h...@gmail.com] > *Sent:* Friday, October 10, 2014 11:16 AM > *To:* WiX

Re: [WiX-devs] WIP 4149 and 4552

2014-10-10 Thread Rob Mensching
). ___ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ From: Sean Hall [mailto:r.sean.h...@gmail.com] Sent: Friday, October 10, 2014 11:16 AM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] WIP 4149 and 4552 Some quick

Re: [WiX-devs] WIP 4149 and 4552

2014-10-10 Thread Sean Hall
Some quick thoughts: Part of the work I did for secure variables was making Burn go through the variable methods instead of accessing the variants directly. I was trying to hide the variants with the IVariableStore interface, I can't remember if that's going to be possible if we keep variable.h.

Re: [WiX-devs] WIP 4149 and 4552

2014-10-10 Thread Rob Mensching
Cool. I definitely like the proposal to pull variables and conditions to dutil. We probably should have done that when first creating Burn. 1. However, I don’t think we should change the variable (or conditions) “API” to be an interface pattern. I think we should stick with the most com