[PATCH 09/10] wmifinfo: Add valid timeval.

Patch by Julien BLACHE from Debian: http://sources.debian.net/src/wmifinfo/0.09-7/debian/patches/wmifinfo-timeval_fix.patch/ For more information, see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503416 --- wmifinfo/wmifinfo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH 10/10] wmifinfo: Bump to version 0.10.

--- wmifinfo/Changelog | 9 + wmifinfo/Makefile | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/wmifinfo/Changelog b/wmifinfo/Changelog index 0184cf3..cae7518 100644 --- a/wmifinfo/Changelog +++ b/wmifinfo/Changelog @@ -54,3 +54,12 @@ - the '-i' flag (init

[PATCH 08/10] wmifinfo: Fix -Wformat compiler warnings.

--- wmifinfo/nwn.c | 2 +- wmifinfo/wmifinfo.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/wmifinfo/nwn.c b/wmifinfo/nwn.c index 0602b27..281b665 100644 --- a/wmifinfo/nwn.c +++ b/wmifinfo/nwn.c @@ -65,7 +65,7 @@ int nwn_get_link(char *ifname)

[PATCH 02/10] wmifinfo: Add manpage.

Adapted from Debian manpage: http://sources.debian.net/src/wmifinfo/0.09-7/debian/wmifinfo.1/ --- wmifinfo/Makefile | 3 +++ wmifinfo/wmifinfo.1 | 37 + 2 files changed, 40 insertions(+) create mode 100644 wmifinfo/wmifinfo.1 diff --git a/wmifinfo/Makefile

[PATCH 05/10] wmifinfo: Fix -Wunused-result compiler warnings.

--- wmifinfo/wmifinfo.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/wmifinfo/wmifinfo.c b/wmifinfo/wmifinfo.c index cc6ee99..3ddf026 100644 --- a/wmifinfo/wmifinfo.c +++ b/wmifinfo/wmifinfo.c @@ -355,7 +355,10 @@ void exec_cmd(char *cmd) pid=fork();

[PATCH 06/10] wmifinfo: Remove C++ style comments.

--- wmifinfo/wmifinfo.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/wmifinfo/wmifinfo.c b/wmifinfo/wmifinfo.c index 3ddf026..adb323d 100644 --- a/wmifinfo/wmifinfo.c +++ b/wmifinfo/wmifinfo.c @@ -189,7 +189,7 @@ int main(int argc, char *argv[])

[PATCH 07/10] wmifinfo: Fix -Wpedantic compiler warning.

--- wmifinfo/wmifinfo.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/wmifinfo/wmifinfo.c b/wmifinfo/wmifinfo.c index adb323d..827afec 100644 --- a/wmifinfo/wmifinfo.c +++ b/wmifinfo/wmifinfo.c @@ -656,6 +656,12 @@ void getifnames(void) int pifaces;

[PATCH 04/10] wmifinfo: Fix -Wunused-but-set-variable compiler warning.

--- wmifinfo/wmifinfo.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/wmifinfo/wmifinfo.c b/wmifinfo/wmifinfo.c index 51e0dc3..cc6ee99 100644 --- a/wmifinfo/wmifinfo.c +++ b/wmifinfo/wmifinfo.c @@ -406,7 +406,6 @@ char *strupper(char *str) int getifinfo(char *ifname,

[PATCH 03/10] wmifinfo: Fix -Wpointer-sign compiler warnings.

--- wmifinfo/wmifinfo.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/wmifinfo/wmifinfo.c b/wmifinfo/wmifinfo.c index c8d7871..51e0dc3 100644 --- a/wmifinfo/wmifinfo.c +++ b/wmifinfo/wmifinfo.c @@ -58,7 +58,7 @@ struct ifinfo_t { char id[16];

[PATCH 01/10] wmifinfo: Update Makefile.

In particular, add support for common user-defined variables CFLAGS, CPPFLAGS, LDFLAGS, DESTDIR, and PREFIX. Also remove reference to deprecated X11R6 directory and use install instead of cp for install target. Inspired by the Debian patches: http://sources.debian.net/src/wmifinfo/0.09-7/debian/p

[PATCH 00/10] wmifinfo patches

Here are a few wmifinfo patches, mostly Debian patches and compiler warning fixes. Carlos, could you tag the last patch wmifinfo-0.10? Thanks! Doug Torrance (10): wmifinfo: Update Makefile. wmifinfo: Add manpage. wmifinfo: Fix -Wpointer-sign compiler warnings. wmifinfo: Fix -Wunused-but-

[PATCH 23/23] util: remove local constants GLOBAL_DEFAULTS_SUBDIR that are not used

As pointed by gcc, this macro is not used anywhere in the 2 files. Because the code also suggests that they should be inherited from any other place anyway, remove them from the file to prevent them from being used in the future. Signed-off-by: Christophe CURIS --- util/getstyle.c | 3 --- util/

[PATCH 21/23] wmaker: comment out definition of wm-spec constant that we do not use

Include a comment to explain what their aim is, and why WindowMaker is not making use of them. They are not simply removed because it is informative for future contributors that we know about them and we purposedly decided to not use them. Signed-off-by: Christophe CURIS --- src/wmspec.c | 17 ++

[PATCH 22/23] WPrefs: remove unused constants ICON_TITLE_*FONT

Apparently, there was a time when it was though to add a label below (?) the icons of the list of panels, but this has never been finished and the unfinished code to do this was even removed in commit 0e01e6920572b3d3a7a8df2872513144225440a8 So, as it is unlikely that the "feature" will return,

[PATCH 20/23] wmaker: remove parameter 'which' from local function 'restoreMenu'

This parameter is given always the same value, so there is not reason to keep it. The code is updated to take this value into account, and the related constants are removed. Signed-off-by: Christophe CURIS --- src/menu.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff

[PATCH 16/23] wmaker: removed unused macro DBLCLICK_TIME

As pointed by gcc, this macro is not used anywhere, that is probably because the code have been relying on the function "IsDoubleClick" for a very long time now. Signed-off-by: Christophe CURIS --- src/framewin.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/framewin.c b/src/framewin.

[PATCH 17/23] wmaker: removed unused constant SCROLL_STEPS in the switchpanel code

As pointed by gcc, this constant is not used anywhere in the code. It seems to have been prepared for a scroll animation when the switchpanel would be too big to fit the screen, but the code looks like to never have been activated, and was cleaned away in commit 6d08aa22d824d6abe5edb4c4892bbf9eae

[PATCH 19/23] wmaker: remove constants HORIZONTAL and VERTICAL from moveres.c

These 2 constants have been defined at the beginning of the project, but where never used later. As the use of the associated constants suggests that they are not bringing anything useful, this patch simply removes them. Signed-off-by: Christophe CURIS --- src/moveres.c | 4 1 file changed,

[PATCH 15/23] replaced all local definitions of PI by a single one

For code maintainability, it is better to have a single definition of the constant than many ones dispatched in many places. In addition, we try to count on the constant M_PI that can be defined by the header if possible because it may have the best accuracy for the platform. Signed-off-by: Chris

[PATCH 14/23] remove unused macros defining corner positions

As pointed by gcc, the 4 constant the define the corner positions are not used anywhere in the code, and it looks like it has always been like this. As it is a cost for maintainability, get rid of them. Signed-off-by: Christophe CURIS --- WINGs/wballoon.c | 5 - src/balloon.c| 5 - 2

[PATCH 18/23] wmaker: add code to explicitly ignore Motif-WM flags we don't want to handle

The goal is to explain the reason why we don't do anything about them, so people looking at the code in the future will know why it is this way. The expected side effect is also to silent warnings [-Wunused-macros] from gcc. Signed-off-by: Christophe CURIS --- src/motif.c | 31 ++

[PATCH 13/23] remove a few unused constant for size of buffers

As pointed by gcc, a few constants which contain sizes for buffers are not used anywhere in the code. This is probably due to code cleanup, where these buffers have been removed or where size is automatically calculated by using 'sizeof' instead to reduce risk of bugs. Signed-off-by: Christophe CU

[PATCH 10/23] WINGs: remove macro ABS_SHIFT from the wcolorpanel code

This macro was define a *very* long time ago, in commit d98f1fa645be332b35e8f8d1c2b7ce8ab1231be0 but was not used at that time, and have never been used anywhere since then. As the macro does not look like a good idea for performance anyway, get rid of it before anyone could get tempted to use i

[PATCH 12/23] WINGs: reuse GNUstep header instead of duplicating stuff in wwindow.c

There is a header that defines the stucts and constants to support GNUstep specific things, and it is already used somewhere else in WINGs, so instead of duplicating locally the stuff we re-use the header, it makes code easier to maintain. Signed-off-by: Christophe CURIS --- WINGs/wwindow.c | 28

[PATCH 11/23] WINGs: remove internal XDND macros that are not used

The group of XDND_* macro do not bring a lot in term of clarity, so it is probable that they will get away someday, but at current time as 2 of them are not used anywhere they get removed to prevent their use in the future. Signed-off-by: Christophe CURIS --- WINGs/dragdestination.c | 2 -- 1 fi

[PATCH 07/23] WINGs: remove unused constant DEFAULT_BORDER_WIDTH in wcolorwell

As pointed by gcc, this constant is not used anywhere, and it looks like it have always been the case. As there's no reason to specifically add a border to this widget, remove the constant. Signed-off-by: Christophe CURIS --- WINGs/wcolorwell.c | 1 - 1 file changed, 1 deletion(-) diff --git a/

[PATCH 06/23] WINGs: remove constants used for default width+height for the widget

As pointed by gcc, the height is never used and the code make use of the SCROLLER_WIDTH constant anyway, so this patch updates the code to directly use that constant instead of intermediate values that just adds noise for code maintainability. Signed-off-by: Christophe CURIS --- WINGs/wscroller.

[PATCH 09/23] WINGs: remove dead code from 'loadPixmaps'

It seems the code had the possibility to load a default icon, probably to be used on the windows if the main program does not provide any. This code however have never been enabled, probably because it is better to not provide an icon and let the window manager use its own. This patch then remove

[PATCH 01/23] configure: rewrote the detection for -Wunused-macro

This flag is always detected as unsupported because every time autoconf is generating a test program for any feature, it puts at the beginning of the test source all the '#define' that have been detected so far, which is what we expect normally. But for this option, as we cannot reasonably make a

[PATCH 08/23] WINGs: remove unused macro NFONT in wbutton

As pointed by gcc, this macro is never used in the code; when no font is defined by user the 'paintButton' code already falls back to the 'normalFont' of the screen, and this code could not need the macro anyway. Signed-off-by: Christophe CURIS --- WINGs/wbutton.c | 1 - 1 file changed, 1 deleti

[PATCH 05/23] WINGs: remove the macro DEFAULT_TITLE because it is not used

As pointed by gcc, the macro is not used, that is probably because it is totally ok to never provide a title from X point of view, so there is now reason to fall back to that empty constant. Signed-off-by: Christophe CURIS --- WINGs/wwindow.c | 1 - 1 file changed, 1 deletion(-) diff --git a/WI

[PATCH 03/23] configure: add a few warning flags for gcc and clang to help catch bugs

They concern topics like: - portability; - dangerous constructs; - clearer code for maintainability Signed-off-by: Christophe CURIS --- configure.ac | 31 +++ 1 file changed, 31 insertions(+) diff --git a/configure.ac b/configure.ac index d46923e..8fc3bd0 100644 -

[PATCH 02/23] configure: add macro to check compiler flag '-Wstrict-prototype'

Strict prototype are better for portability and to avoid bugs because it makes sure the compiler has the information to properly validate the arguments given when a function is called. This flag however need special care when checking for it, because the declaration for 'main' generated by autocon

[PATCH 04/23] configure: make the gcc check for trampolines stronger

Because the use of trampolines can be a lot of problems, this patch changes the use of the flag to: - make it an error if possible, so coders are forced to not use them; - always enable them, not just for debug, so we increase the probability to get them caught. Signed-off-by: Christophe CURIS

[PATCH 00/23] Enable a few more warnings from gcc/clang

Hello, This series of patches adds some warnings for gcc and some for clang which help to make safer code: - patch 1 fixes the detection for 'unused-macro' which did not work; - patch 2 and 3 add more flags; - patch 4 turns the trampoline warning into an error if possible; - patch 5 to 23 fix

Re: Question about nopolling variable

"Carlos R. Mafra" escribió: On Mon, 8 Dec 2014 at 17:46:25 +, Rodolfo García Peñas (kix) wrote: "Carlos R. Mafra" escribió: >On Mon, 8 Dec 2014 at 16:28:14 +0100, Rodolfo García Peñas wrote: >>On Mon, 08 Dec 2014, Carlos R. Mafra escribió: >> >>> On Mon, 8 Dec 2014 at 13:36:25 +0100

Re: Question about nopolling variable

On Mon, 8 Dec 2014 at 17:46:25 +, Rodolfo García Peñas (kix) wrote: > > "Carlos R. Mafra" escribió: > > >On Mon, 8 Dec 2014 at 16:28:14 +0100, Rodolfo García Peñas wrote: > >>On Mon, 08 Dec 2014, Carlos R. Mafra escribió: > >> > >>> On Mon, 8 Dec 2014 at 13:36:25 +0100, Rodolfo García Peñ

Re: Question about nopolling variable

"Carlos R. Mafra" escribió: On Mon, 8 Dec 2014 at 16:28:14 +0100, Rodolfo García Peñas wrote: On Mon, 08 Dec 2014, Carlos R. Mafra escribió: > On Mon, 8 Dec 2014 at 13:36:25 +0100, Rodolfo García Peñas wrote: > > Hi, > > > > I have a question about the variable "nopolling". Is used? Coul

Re: Question about nopolling variable

On Mon, 8 Dec 2014 at 16:28:14 +0100, Rodolfo García Peñas wrote: > On Mon, 08 Dec 2014, Carlos R. Mafra escribió: > > > On Mon, 8 Dec 2014 at 13:36:25 +0100, Rodolfo García Peñas wrote: > > > Hi, > > > > > > I have a question about the variable "nopolling". Is used? Could we > > > remove it?

Re: Question about nopolling variable

On Mon, 08 Dec 2014, Carlos R. Mafra escribió: > On Mon, 8 Dec 2014 at 13:36:25 +0100, Rodolfo García Peñas wrote: > > Hi, > > > > I have a question about the variable "nopolling". Is used? Could we remove > > it? > > > > I found it in src/startup.c, but the variable is never set. I am missing

[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.6-138-g1e6740b3

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project wmaker-crm.git. The branch, next has been updated via 1e6740b34467cf9de4f7fb41b939bc3f0316e229 (commit) from b190ab4b5ea9e3e3c

Re: Question about nopolling variable

On Mon, 8 Dec 2014 at 13:36:25 +0100, Rodolfo García Peñas wrote: > Hi, > > I have a question about the variable "nopolling". Is used? Could we remove it? > > I found it in src/startup.c, but the variable is never set. I am missing > something? > > Thanks, > kix > > kix@debian:~/src/wmaker/aw

Re: [PATCH 1/4] WINGs: add functions to set widget background image

On Fri, Dec 05, 2014 at 10:13:34AM +0800, David Maciejak wrote: > -WINGS_CURRENT=3 > +WINGS_CURRENT=4 > WINGS_REVISION=0 > WINGS_AGE=0 I should read more docs, before suggesting. WINGS_AGE should also be increased according to info libtool... -- Regards,-- Sir Raorn. --- https://plus.goo

Re: [PATCH 1/4] WINGs: add functions to set widget background image

On Sun, Dec 07, 2014 at 10:01:17AM +0800, David Maciejak wrote: > I agree with you Rodolfo that it should be better to increase the minor > version number instead. This is not just "numbers after .so.". And was a bit wrong, AGE should also be increased. From info libtool: So, libtool library

Question about nopolling variable

Hi, I have a question about the variable "nopolling". Is used? Could we remove it? I found it in src/startup.c, but the variable is never set. I am missing something? Thanks, kix kix@debian:~/src/wmaker/awmaker$ rgrep nopolling * NEWS:Running Window Maker with one of -nopolling or --no-polling