[PATCH] WPrefs: remove unfinished background tab from appearances panel code

2014-05-16 Thread Doug Torrance
WPrefs.app/Appearances.c contained code for an unfinished feature in the appearances panel of WPrefs, a tab for setting the background. Since this feature has now been implemented as part of the texture tab (see commit c2aca1a), there is no reason to keep this code. --- WPrefs.app/Appearance.c |

Re: [PATCH] WPrefs: remove unfinished background tab from appearances panel code

2014-05-16 Thread Carlos R. Mafra
On Fri, 16 May 2014 at 9:39:57 -0500, Doug Torrance wrote: Since this feature has now been implemented as part of the texture tab (see commit c2aca1a), there is no reason to keep this code. Just a minor comment. Unless the patch is already in the master branch (which is not the case here)

Re: [PATCH] WPrefs: remove unfinished background tab from appearances panel code

2014-05-16 Thread Torrance, Douglas
On 05/16/2014 12:19 PM, Carlos R. Mafra wrote: Just a minor comment. Unless the patch is already in the master branch (which is not the case here) the commit sha1 is not a perennial reference. So I'd like to suggest that everybody referring to some commit to also write its description line.