Re: [PATCH 01/14] wmkeys compilation bugs

2015-08-16 Thread Carlos R. Mafra
On Sun, 16 Aug 2015 at 0:22:49 +0200, Rodolfo García Peñas (kix) wrote: Thank you Rodolfo, the diffstat of this series is simply awesome! 88 files changed, 51 insertions(+), 11084 deletions(-) -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

Re: [PATCH 01/14] wmkeys compilation bugs

2015-08-16 Thread Carlos R. Mafra
On Sat, 15 Aug 2015 at 23:15:11 +, Rodolfo García Peñas (kix) wrote: Doug Torrance dtorra...@piedmont.edu escribió: On 08/15/2015 06:29 PM, Rodolfo García Peñas (kix) wrote: I modified all other dockapps. Thanks for doing this! The wmbiff dockapp includes a different wmgeneral

Re: [PATCH 01/14] wmkeys compilation bugs

2015-08-16 Thread Rodolfo García Peñas (kix)
Carlos R. Mafra crma...@gmail.com escribió: On Sat, 15 Aug 2015 at 23:15:11 +, Rodolfo García Peñas (kix) wrote: Doug Torrance dtorra...@piedmont.edu escribió: On 08/15/2015 06:29 PM, Rodolfo García Peñas (kix) wrote: I modified all other dockapps. Thanks for doing this! The wmbiff

Re: [PATCH 01/14] wmkeys compilation bugs

2015-08-16 Thread Rodolfo García Peñas (kix)
Carlos R. Mafra crma...@gmail.com escribió: On Sun, 16 Aug 2015 at 0:22:49 +0200, Rodolfo García Peñas (kix) wrote: Thank you Rodolfo, the diffstat of this series is simply awesome! 88 files changed, 51 insertions(+), 11084 deletions(-) Thanks Carlos. Rodolfo García Peñas (kix)

Re: [PATCH 01/14] wmkeys compilation bugs

2015-08-16 Thread Carlos R. Mafra
On Sun, 16 Aug 2015 at 10:08:56 +, Rodolfo García Peñas (kix) wrote: Carlos R. Mafra crma...@gmail.com escribió: On Sat, 15 Aug 2015 at 23:15:11 +, Rodolfo García Peñas (kix) wrote: Doug Torrance dtorra...@piedmont.edu escribió: On 08/15/2015 06:29 PM, Rodolfo García Peñas

Re: [PATCH 01/14] wmkeys compilation bugs

2015-08-15 Thread Doug Torrance
On 08/15/2015 06:29 PM, Rodolfo García Peñas (kix) wrote: I modified all other dockapps. Thanks for doing this! The wmbiff dockapp includes a different wmgeneral library. This dockapp doesn't compile. I don't include this new code in libdockapps because include code of application that

[PATCH 01/14] wmkeys compilation bugs

2015-08-15 Thread kix
This patch solves a bug and a warning: - The dockapp wmkeys uses the getline function, that is the same function provided by stdio.h. This patch changes the function name to getline_wmkeys. - The main function returns void, and should return integer. This patch includes the return 0 at the

Re: [PATCH 01/14] wmkeys compilation bugs

2015-08-15 Thread Rodolfo García Peñas (kix)
Hi, I modified all other dockapps. The wmbiff dockapp includes a different wmgeneral library. This dockapp doesn't compile. I don't include this new code in libdockapps because include code of application that doesn't compile IMO is not a good idea. Probably we should try to compile the