Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-03-10 Thread Tom Haddon
Review: Approve One minor comment, other than that looks good, thanks. Diff comments: > diff --git a/tests/unit/test_plugin_hander.py > b/tests/unit/test_plugin_hander.py > new file mode 100644 > index 000..82c0fec > --- /dev/null > +++ b/tests/unit/test_plugin_hander.py > @@ -0,0 +1,32 @@

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-03-10 Thread Stuart Bishop
Review: Approve Discussions indicate it doesn't matter if the script times out or not, as a failure will not escalate the pod to a failed state or inform Juju. Something else needs to happen to catch the case where wordpress comes up but the configuration script fails. --