Change successfully merged at revision 3c8a108a8d425035a7eeb07e943bdaf2e24ef6a3
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385482
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list:
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385482
--
Your
Review: Approve
LGTM
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385482
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385482
--
This merge proposal is being monitored by mergebot. Change the status to
Approved to merge.
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385482
Your team Wordpress Charmers is requested to review the proposed merge of
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Commit message changed to:
ingress annotations to support large WordPress imports
For more details, see:
Thomas Cuthbert has proposed merging
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master.
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see:
Change successfully merged at revision 96755116e7292f84c33539dfdef110fb85eb6388
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/385456
Your team Wordpress Charmers is requested to review the proposed merge of
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Approved => Merged
For more details, see:
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Change successfully merged at revision d0935a56f210a06a10ab89fa98ee2a4f4cf9d2a5
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385455
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list:
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:tests into
charm-k8s-wordpress:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385455
--
Your
Change successfully merged at revision a4419d4d2e6ec6330dfe7f845a9e2f26b8fb3207
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385457
Your team Wordpress Charmers is requested to review the proposed merge of
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385457
--
Your
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385457
--
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:tests into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385455
--
Review: Approve
Yup, all good.
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385455
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Review: Approve
Yup.
Consider dropping the type annotations or deciding to add more of them. My code
has them because I'm experimenting, and haven't got a firm recommendation one
way or the other.
Diff comments:
> diff --git a/src/charm.py b/src/charm.py
> index a4cd679..e6af8ed 100755
> ---
Review: Approve
Seems fine, apart from being a shell script, which we have a general policy
against because they grow and devour future travellers. Given it is calling
plugin_handler.py, I even know there is an interpreter already on the image :)
Not for this branch, but worth adding a task to
This merge proposal is being monitored by mergebot. Change the status to
Approved to merge.
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385457
Your team Wordpress Charmers is requested to review the proposed merge of
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Commit message changed to:
WordPress secrets need to be the same on all pods.
For more details,
This merge proposal is being monitored by mergebot. Change the status to
Approved to merge.
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/385456
Your team Wordpress Charmers is requested to review the proposed merge of
Thomas Cuthbert has proposed merging
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master.
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see:
Thomas Cuthbert has proposed merging
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see:
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Commit message changed to:
Ensure WordPress secrets are in sync on pods
For more details, see:
This merge proposal is being monitored by mergebot. Change the status to
Approved to merge.
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385455
Your team Wordpress Charmers is requested to review the proposed merge of
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:tests into
charm-k8s-wordpress:master has been updated.
Commit message changed to:
Unit tests to ensure WordPress secrets are in sync on pods
For more details, see:
Thomas Cuthbert has proposed merging
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:tests into
charm-k8s-wordpress:master.
Commit message:
Unit tests to ensure WordPress secrets are in sync on pods
Requested reviews:
Canonical IS Reviewers (canonical-is-reviewers)
Wordpress
28 matches
Mail list logo
