Re: [Wordpress-charmers] [Merge] ~stub/charm-k8s-wordpress:mysql-relation into charm-k8s-wordpress:master

Some inline comments, and you have a test failure in test_is_config_valid. Haven't tested yet, but will do so shortly. Diff comments: > diff --git a/src/charm.py b/src/charm.py > index edade47..efe9026 100755 > --- a/src/charm.py > +++ b/src/charm.py > @@ -115,20 +117,20 @@ class

Re: [Wordpress-charmers] [Merge] ~stub/charm-k8s-wordpress:mysql-relation into charm-k8s-wordpress:master

This merge proposal is being monitored by mergebot. Change the status to Approved to merge. -- https://code.launchpad.net/~stub/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395826 Your team Wordpress Charmers is requested to review the proposed merge of

[Wordpress-charmers] [Merge] ~stub/charm-k8s-wordpress:mysql-relation into charm-k8s-wordpress:master

Tom Haddon has proposed merging ~stub/charm-k8s-wordpress:mysql-relation into charm-k8s-wordpress:master. Commit message: Implement a MySQL database relation The database connection details from the relation will override any provided in the charm configuration. Requested reviews: Wordpress

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:optional-tls into charm-k8s-wordpress:master

Review: Approve Yup, all good. -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396062 Your team Wordpress Charmers is requested to review the proposed merge of ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:optional-tls into

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action into charm-k8s-wordpress:master

Review: Approve Looks good! Diff comments: > diff --git a/src/charm.py b/src/charm.py > index edade47..1c2f1de 100755 > --- a/src/charm.py > +++ b/src/charm.py > @@ -146,7 +152,8 @@ class WordpressCharm(CharmBase): > msg = "Wordpress needs configuration" >

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action into charm-k8s-wordpress:master

Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action into charm-k8s-wordpress:master. Commit message: Add an action to retrieve initial password Requested reviews: Canonical IS Reviewers (canonical-is-reviewers) Wordpress Charmers

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action into charm-k8s-wordpress:master

This action can now be run from any unit. -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395982 Your team Wordpress Charmers is requested to review the proposed merge of ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action into charm-k8s-wordpress:master

The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action into charm-k8s-wordpress:master has been updated. Status: Needs review => Work in progress For more details, see:

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action into charm-k8s-wordpress:master

There's actually a problem with this. We need to use leadership data (or a peer relation) since StoredState is per unit. -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395982 Your team Wordpress Charmers is requested to review the proposed merge of

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:maintenance-status into charm-k8s-wordpress:master

This merge proposal is being monitored by mergebot. Change the status to Approved to merge. -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396065 Your team Wordpress Charmers is requested to review the proposed merge of

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:maintenance-status into charm-k8s-wordpress:master

Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:maintenance-status into charm-k8s-wordpress:master. Commit message: Fix unit status to stay in 'active' once configured Requested reviews: Wordpress Charmers (wordpress-charmers) For more details, see:

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:optional-tls into charm-k8s-wordpress:master

This merge proposal is being monitored by mergebot. Change the status to Approved to merge. -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396062 Your team Wordpress Charmers is requested to review the proposed merge of

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:optional-tls into charm-k8s-wordpress:master

Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:optional-tls into charm-k8s-wordpress:master. Commit message: Make tls_secret_name optional to avoid one step in local dev setup Requested reviews: Wordpress Charmers (wordpress-charmers) For more

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:end-user into charm-k8s-wordpress:master

This merge proposal is being monitored by mergebot. Change the status to Approved to merge. -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396059 Your team Wordpress Charmers is requested to review the proposed merge of

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:end-user into charm-k8s-wordpress:master

Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:end-user into charm-k8s-wordpress:master. Commit message: Update docs to be more end-user focused, refer to discourse-based docs, and use correct casing of WordPress Requested reviews: Wordpress Charmers

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into charm-k8s-wordpress:master

The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into charm-k8s-wordpress:master has been updated. Status: Approved => Merged For more details, see:

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into charm-k8s-wordpress:master

Change successfully merged at revision f7316fa1c552d60a5865c3edad746c5920c65778 -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396038 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list:

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into charm-k8s-wordpress:master

The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see:

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into charm-k8s-wordpress:master

Review: Approve -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396038 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to :