[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2019-12-04 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master. Commit message: Set up our first basic unit test Requested reviews: Canonical IS Reviewers (canonical-is-reviewers) Wordpress Charmers (wordpress-charmers

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2019-12-03 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/375596

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2019-12-17 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/376327

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-20 Thread Barry Price
Successful Jenkins run of my branch: https://jenkins.canonical.com/is/job/wordpress-k8s-image-builder/19/console -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377851 Your team Wordpress Charmers is requested to review the proposed merge of

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:build-focal into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-20 Thread Barry Price
Review: Needs Fixing Couple of things: 1. Let's tag with series, e.g. wordpress:bionic-latest and wordpress:focal-latest 2. Making fetch/build separate steps without a dependency means we can (accidentally) build an image without the themes/plugins included. I don't think we want to block

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-03-06 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: Adding plugin handling for Akismet and Launchpad OpenID integration Requested reviews

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-24 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Work in progress For more details, see:

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-24 Thread Barry Price
Build is still working, at least: https://jenkins.canonical.com/is/job/wordpress-k8s-image-builder/24/console -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920 Your team Wordpress Charmers is requested to review the proposed merge of

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-01-23 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master. Commit message: Hi Requested reviews: Wordpress Charmers (wordpress-charmers) For more details, see: https://code.launchpad.net/~barryprice/charm-k8s-wordpress

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-23 Thread Barry Price
Confirmed working with a local (juju/microk8s) deploy. -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920 Your team Wordpress Charmers is requested to review the proposed merge of

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-23 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: First pass at handling site config via env variables Requested reviews: Wordpress

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-01-23 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/377904

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-23 Thread Barry Price
Passing run: https://jenkins.canonical.com/is/job/wordpress-k8s-image-builder/21/console Still need to confirm the image actually runs as expected... -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920 Your team Wordpress Charmers is

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-23 Thread Barry Price
And another, post-fix: https://jenkins.canonical.com/is/job/wordpress-k8s-image-builder/22/console -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920 Your team Wordpress Charmers is requested to review the proposed merge of

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-01-30 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master. Commit message: Expand and wire up plugin config, plus formatting fixes Requested reviews: Canonical IS Reviewers (canonical-is-reviewers) Wordpress Charmers

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:focal into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-30 Thread Barry Price
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:focal into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see:

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-24 Thread Barry Price
Deploy confirmed working too. Ready for re-review, I think. -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920 Your team Wordpress Charmers is requested to review the proposed merge of

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-24 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: First pass at handling site config via env variables Requested reviews: Canonical

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/workpress-k8s-image-builder:master

2020-01-13 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/workpress-k8s-image-builder:master has been updated. Status: Needs review => Superseded For more details, see:

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/workpress-k8s-image-builder:master

2020-01-13 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/workpress-k8s-image-builder:master. Commit message: Create a Docker image to run the latest Wordpress, with our whitelisted plugins

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-15 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: Print themes as they're being downloaded, as well as plugins Requested reviews

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/print-plugin-names:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-15 Thread Barry Price
Review: Approve Sure - I'll do the same for themes -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/print-plugin-names/+merge/377639 Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. -- Mailing

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/print-plugin-names:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-15 Thread Barry Price
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/print-plugin-names:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see:

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-15 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Merged => Superseded For more details, see:

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-15 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: Print themes as they're being downloaded, as well as plugins Requested reviews

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-21 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see:

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-01-21 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master. Commit message: Handle redirects better, detect and warn about missing DB config, add registry authentication support, fix status.maintenance() syntax error

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-20 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: Add maintainer/build date labels, make tags more sensible Requested reviews

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-13 Thread Barry Price
Thanks, addressed 2/3, will push a fresh branch and we can discuss the other later today. Diff comments: > diff --git a/Dockerfile b/Dockerfile > new file mode 100644 > index 000..38866f4 > --- /dev/null > +++ b/Dockerfile > @@ -0,0 +1,55 @@ > +FROM ubuntu:bionic > + > +RUN echo 'debconf

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-03-08 Thread Barry Price
Addressed most of these - pushing fixes Diff comments: > diff --git a/Dockerfile b/Dockerfile > index 24b6b0b..c866c98 100644 > --- a/Dockerfile > +++ b/Dockerfile > @@ -19,7 +19,8 @@ RUN echo 'debconf debconf/frontend select Noninteractive' | > debconf-set-selectio > # Update all packages,

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-04-16 Thread Barry Price
Review: Approve LGTM +1 -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/382463 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to :

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-03-27 Thread Barry Price
Thanks, left some responses and will push fixes for these as well as others. Diff comments: > diff --git a/reactive/wordpress.py b/src/charm.py > similarity index 53% > rename from reactive/wordpress.py > rename to src/charm.py > index 9a1b013..9d5be4d 100644 > --- a/reactive/wordpress.py > +++

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into charm-k8s-wordpress:master

2020-04-30 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Work in progress For more details, see:

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into charm-k8s-wordpress:master

2020-04-30 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into charm-k8s-wordpress:master. Commit message: Basic swift config for openstack-objectstorage plugin, no input validation yet Requested reviews: Wordpress Charmers (wordpress-charmers

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-04-30 Thread Barry Price
For context: https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383120 -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/383235 Your team Wordpress Charmers is requested to review the proposed merge of

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-04-29 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master. Commit message: Add openstack-objectstorage (swift!) support Companion MP to https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-04-29 Thread Barry Price
The proposal to merge ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see:

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-04-29 Thread Barry Price
Review: Approve Charm change is done: https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383120 So approving this, but will be landing further fixes from my own branch --

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-05-11 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see:

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-17 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master. Commit message: Load wp_plugin_swift_config as YAML, not a string Requested reviews: Canonical IS Reviewers (canonical-is-reviewers) Wordpress Charmers

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-17 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383951

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:configure-pod into charm-k8s-wordpress:master

2020-05-11 Thread Barry Price
Review: Approve Thanks, makes sense -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383499 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to :

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:configure-pod into charm-k8s-wordpress:master

2020-05-11 Thread Barry Price
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:configure-pod into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see:

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-05-11 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: Basic swift config for openstack-objectstorage plugin, no input validation yet

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-14 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master. Commit message: Update operator submodule, add min-juju-version for storage support Requested reviews: Wordpress Charmers (wordpress-charmers) For more details

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:better-import-warnings into charm-k8s-wordpress:master

2020-05-12 Thread Barry Price
Review: Approve +1 -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383769 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to :

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:better-import-warnings into charm-k8s-wordpress:master

2020-05-12 Thread Barry Price
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:better-import-warnings into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see:

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-03-23 Thread Barry Price
Addressed all comments, pushing fixed code now. Diff comments: > diff --git a/.gitignore b/.gitignore > index e0f7f96..d8aaacd 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -1,3 +1,6 @@ > files/plugins/ > files/themes/ > +.coverage > .tox/ > +files/__pycache__/ > +tests/unit/__pycache__/

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-21 Thread Barry Price
Barry Price has proposed merging ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master. Commit message: Add an Ingress resource to our pod spec, hard-coded port for now Requested reviews: Wordpress Charmers (wordpress-charmers) For more details, see

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-21 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Work in progress For more details, see:

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-21 Thread Barry Price
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Work in progress => Superseded For more details, see:

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-22 Thread Barry Price
This now deploys cleanly, but defines no probes. It can be merged as-is, as long as re-adding probes is taken care of at some point. -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384331 Your team Wordpress Charmers is requested to review the

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-21 Thread Barry Price
n.b. the current target cluster doesn't recognise "startupProbe" so please do not merge until I've got (at least) that issue figured out :) -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384331 Your team Wordpress Charmers is requested to review the

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-06-17 Thread Barry Price
Review: Approve Sure +1 -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/385885 Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. -- Mailing list:

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-06-17 Thread Barry Price
The proposal to merge ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see:

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-06-14 Thread Barry Price
The proposal to merge ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385729 --

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-06-14 Thread Barry Price
Review: Approve +1 -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385729 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to :

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-06-19 Thread Barry Price
The proposal to merge ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/386074 --

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-06-19 Thread Barry Price
Review: Approve +1 -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/386074 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to :

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:merge_stuff into charm-k8s-wordpress:master

2020-12-02 Thread Barry Price
Review: Approve LGTM -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394793 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to :

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-12-02 Thread Barry Price
Review: Approve LGTM -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394731 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to :

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:test-coverage into charm-k8s-wordpress:master

2021-01-15 Thread Barry Price
Review: Approve LGTM -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396312 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to :

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:kubuntu-org into charm-k8s-wordpress:master

2021-08-11 Thread Barry Price
Review: Approve Yup -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/406893 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to :

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:kubuntu-org into charm-k8s-wordpress:master

2021-08-11 Thread Barry Price
The proposal to merge ~tcuthbert/charm-k8s-wordpress:kubuntu-org into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/406893 -- Your team

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2021-08-11 Thread Barry Price
The proposal to merge ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/406894 -- Your team Wordpress

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2021-08-11 Thread Barry Price
Review: Approve +1 -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/406894 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to :