Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master.
Commit message:
Set up our first basic unit test
Requested reviews:
Canonical IS Reviewers (canonical-is-reviewers)
Wordpress Charmers (wordpress-charmers
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/375596
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/376327
Successful Jenkins run of my branch:
https://jenkins.canonical.com/is/job/wordpress-k8s-image-builder/19/console
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377851
Your team Wordpress Charmers is requested to review the proposed merge of
Review: Needs Fixing
Couple of things:
1. Let's tag with series, e.g. wordpress:bionic-latest and
wordpress:focal-latest
2. Making fetch/build separate steps without a dependency means we can
(accidentally) build an image without the themes/plugins included. I don't
think we want to block
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Commit message:
Adding plugin handling for Akismet and Launchpad OpenID integration
Requested reviews
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Work in progress
For more details, see:
Build is still working, at least:
https://jenkins.canonical.com/is/job/wordpress-k8s-image-builder/24/console
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920
Your team Wordpress Charmers is requested to review the proposed merge of
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master.
Commit message:
Hi
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress
Confirmed working with a local (juju/microk8s) deploy.
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920
Your team Wordpress Charmers is requested to review the proposed merge of
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Commit message:
First pass at handling site config via env variables
Requested reviews:
Wordpress
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/377904
Passing run:
https://jenkins.canonical.com/is/job/wordpress-k8s-image-builder/21/console
Still need to confirm the image actually runs as expected...
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920
Your team Wordpress Charmers is
And another, post-fix:
https://jenkins.canonical.com/is/job/wordpress-k8s-image-builder/22/console
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920
Your team Wordpress Charmers is requested to review the proposed merge of
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master.
Commit message:
Expand and wire up plugin config, plus formatting fixes
Requested reviews:
Canonical IS Reviewers (canonical-is-reviewers)
Wordpress Charmers
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:focal into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Deploy confirmed working too. Ready for re-review, I think.
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920
Your team Wordpress Charmers is requested to review the proposed merge of
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Commit message:
First pass at handling site config via env variables
Requested reviews:
Canonical
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/workpress-k8s-image-builder:master
has been updated.
Status: Needs review => Superseded
For more details, see:
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/workpress-k8s-image-builder:master.
Commit message:
Create a Docker image to run the latest Wordpress, with our whitelisted plugins
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Commit message:
Print themes as they're being downloaded, as well as plugins
Requested reviews
Review: Approve
Sure - I'll do the same for themes
--
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/print-plugin-names/+merge/377639
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/print-plugin-names:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Merged => Superseded
For more details, see:
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Commit message:
Print themes as they're being downloaded, as well as plugins
Requested reviews
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master.
Commit message:
Handle redirects better, detect and warn about missing DB config, add registry
authentication support, fix status.maintenance() syntax error
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Commit message:
Add maintainer/build date labels, make tags more sensible
Requested reviews
Thanks, addressed 2/3, will push a fresh branch and we can discuss the other
later today.
Diff comments:
> diff --git a/Dockerfile b/Dockerfile
> new file mode 100644
> index 000..38866f4
> --- /dev/null
> +++ b/Dockerfile
> @@ -0,0 +1,55 @@
> +FROM ubuntu:bionic
> +
> +RUN echo 'debconf
Addressed most of these - pushing fixes
Diff comments:
> diff --git a/Dockerfile b/Dockerfile
> index 24b6b0b..c866c98 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -19,7 +19,8 @@ RUN echo 'debconf debconf/frontend select Noninteractive' |
> debconf-set-selectio
> # Update all packages,
Review: Approve
LGTM +1
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/382463
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Thanks, left some responses and will push fixes for these as well as others.
Diff comments:
> diff --git a/reactive/wordpress.py b/src/charm.py
> similarity index 53%
> rename from reactive/wordpress.py
> rename to src/charm.py
> index 9a1b013..9d5be4d 100644
> --- a/reactive/wordpress.py
> +++
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Work in progress
For more details, see:
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
charm-k8s-wordpress:master.
Commit message:
Basic swift config for openstack-objectstorage plugin, no input validation yet
Requested reviews:
Wordpress Charmers (wordpress-charmers
For context:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383120
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/383235
Your team Wordpress Charmers is requested to review the proposed merge of
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master.
Commit message:
Add openstack-objectstorage (swift!) support
Companion MP to
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
Charm change is done:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383120
So approving this, but will be landing further fixes from my own branch
--
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master.
Commit message:
Load wp_plugin_swift_config as YAML, not a string
Requested reviews:
Canonical IS Reviewers (canonical-is-reviewers)
Wordpress Charmers
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383951
Review: Approve
Thanks, makes sense
--
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383499
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:configure-pod into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Commit message:
Basic swift config for openstack-objectstorage plugin, no input validation yet
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master.
Commit message:
Update operator submodule, add min-juju-version for storage support
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details
Review: Approve
+1
--
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383769
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:better-import-warnings
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Addressed all comments, pushing fixed code now.
Diff comments:
> diff --git a/.gitignore b/.gitignore
> index e0f7f96..d8aaacd 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,3 +1,6 @@
> files/plugins/
> files/themes/
> +.coverage
> .tox/
> +files/__pycache__/
> +tests/unit/__pycache__/
Barry Price has proposed merging
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master.
Commit message:
Add an Ingress resource to our pod spec, hard-coded port for now
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Work in progress
For more details, see:
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Work in progress => Superseded
For more details, see:
This now deploys cleanly, but defines no probes.
It can be merged as-is, as long as re-adding probes is taken care of at some
point.
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384331
Your team Wordpress Charmers is requested to review the
n.b. the current target cluster doesn't recognise "startupProbe" so please do
not merge until I've got (at least) that issue figured out :)
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384331
Your team Wordpress Charmers is requested to review the
Review: Approve
Sure +1
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/385885
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385729
--
Review: Approve
+1
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385729
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/386074
--
Review: Approve
+1
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/386074
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Review: Approve
LGTM
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394793
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Review: Approve
LGTM
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394731
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Review: Approve
LGTM
--
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396312
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Review: Approve
Yup
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/406893
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
The proposal to merge ~tcuthbert/charm-k8s-wordpress:kubuntu-org into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/406893
--
Your team
The proposal to merge ~tcuthbert/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/406894
--
Your team Wordpress
Review: Approve
+1
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/406894
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
66 matches
Mail list logo