Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:tox-lint-black into
charm-k8s-wordpress:master.
Commit message:
Switch to using tox defined black and lint targets to avoid needing local
install
Requested reviews:
Wordpress Charmers (wordpress
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:tox-lint-black into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Work in progress
For more details, see:
Let's switch to using tox targets for lint
Diff comments:
> diff --git a/Makefile b/Makefile
> index 6dc2159..3891e12 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2,5 +2,20 @@ lint:
> black -l 120 -t py37 reactive/
> flake8 reactive/
Since you've got tox targets for this now,
Two minor comments inline. Would be good to get @stub's feedback on it as well.
Much of this looks like it's testable in a similar way to how we do for the
content-cache charm (for example) - see ./tests/unit/test_content_cache.py for
examples (we don't need full test coverage initially but it
Review: Approve
Approved with one comment about adding a comment
Diff comments:
> diff --git a/Dockerfile b/Dockerfile
> index a6bed91..f667d10 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -1,7 +1,11 @@
> FROM ubuntu:bionic
>
> -ARG http_proxy
> -ARG https_proxy
> +LABEL
Some inline comments.
Diff comments:
> diff --git a/Dockerfile b/Dockerfile
> index 24b6b0b..7abcf33 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -50,10 +50,22 @@ COPY --chown=www-data:www-data ./files/themes/
> /var/www/html/wp-content/themes/
> COPY ./files/wp-info.php /var/www/html/
>
Some comments inline.
I do think some kind of timeout for retrying wait_for_wordpress makes sense,
even if it's something like an hour or two. Will ask for input from some others
on this.
Diff comments:
> diff --git a/Dockerfile b/Dockerfile
> index 24b6b0b..c866c98 100644
> --- a/Dockerfile
One comment inline about making wp_plugin_openid_team_map more human-readable
Diff comments:
> diff --git a/config.yaml b/config.yaml
> index a622726..00638bd 100644
> --- a/config.yaml
> +++ b/config.yaml
> @@ -70,7 +70,18 @@ options:
> type: string
> description: Blog hostname
>
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/378300
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Two comments inline
Diff comments:
> diff --git a/Dockerfile b/Dockerfile
> index d9d9d67..ae922d5 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -8,21 +8,16 @@ ARG BUILD_DATE
>
> LABEL org.label-schema.build-date=$BUILD_DATE
>
> +ENV APACHE_CONFDIR=/etc/apache2
> +ENV
Review: Approve
Based on discussions on IRC I'm approving this. I'd missed the fact we were
still doing an autoremove, and it seems there's no functional difference to
adding --no-install-recommends, so that must be being set in the docker
images's apt preferences already.
--
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:focal into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Commit message:
Allow builds of the image on focal with a Makefile arg
Requested reviews:
Wordpress
Some comments inline
Diff comments:
> diff --git a/Dockerfile b/Dockerfile
> new file mode 100644
> index 000..38866f4
> --- /dev/null
> +++ b/Dockerfile
> @@ -0,0 +1,55 @@
> +FROM ubuntu:bionic
> +
> +RUN echo 'debconf debconf/frontend select Noninteractive' |
> debconf-set-selections
> +
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377499
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/print-plugin-names:master into
charm-k8s-wordpress:master.
Commit message:
Print the names of plugins as we download them
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https
One comment inline
Diff comments:
> diff --git a/fetcher.py b/fetcher.py
> index 9f93073..eb6c0b5 100755
> --- a/fetcher.py
> +++ b/fetcher.py
> @@ -110,7 +110,7 @@ def get_themes(branch_themes):
> current_branch = 0
> for branch_theme in branch_themes:
> current_branch =
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377649
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
Review: Approve
One minor comment, other than that looks good, thanks.
Diff comments:
> diff --git a/tests/unit/test_plugin_hander.py
> b/tests/unit/test_plugin_hander.py
> new file mode 100644
> index 000..82c0fec
> --- /dev/null
> +++ b/tests/unit/test_plugin_hander.py
> @@ -0,0 +1,32 @@
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme-formatting into
charm-k8s-wordpress:master.
Commit message:
Update formatting of README for better display on jaas.ai
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details
The proposal to merge ~tcuthbert/charm-k8s-wordpress:operator into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/382463
--
Your team Wordpress
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/382364
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
I had to run both of these commands to get things to work:
git submodule update --recursive --init
git submodule update --recursive --remote
This left me with some git status in my working branch. Do we need to update
the submodule reference?
Diff comments:
> diff --git
Review: Approve
Can move "import logging" above the sys.path.append to avoid needing noqa for
that entry, otherwise looks good for now, thanks!
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/381502
Your team Wordpress Charmers is subscribed to
Have added some comments
Diff comments:
> diff --git a/src/charm.py b/src/charm.py
> new file mode 100755
> index 000..7505ed0
> --- /dev/null
> +++ b/src/charm.py
> @@ -0,0 +1,289 @@
> +#!/usr/bin/env python3
> +
> +import io
> +import re
> +import subprocess
> +import sys
> +from pprint
Some comments inline
Diff comments:
> diff --git a/src/charm.py b/src/charm.py
> new file mode 100755
> index 000..cccf55f
> --- /dev/null
> +++ b/src/charm.py
> @@ -0,0 +1,333 @@
> +#!/usr/bin/env python3
> +
> +import re
> +import secrets
> +import subprocess
> +import string
> +import sys
Some comments inline
Diff comments:
> diff --git a/reactive/wordpress.py b/src/charm.py
> similarity index 53%
> rename from reactive/wordpress.py
> rename to src/charm.py
> index 9a1b013..9d5be4d 100644
> --- a/reactive/wordpress.py
> +++ b/src/charm.py
> @@ -1,292 +1,308 @@
> +#!/usr/bin/env
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:docker-fixes
into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Commit message:
Fix docker_deps apt install invocation
Requested reviews:
Wordpress Charmers
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:docker-fixes
into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Commit message:
No need to quite docker_deps in Dockerfile
Requested reviews:
Wordpress Charmers
This will need a charm change as well, so leaving this for when barry is able
to work on that.
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/382913
Your team Wordpress Charmers is requested to review the proposed merge of
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme-image-config into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:pkg-ordering
into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
Commit message:
Move docker package dependencies to an alpha sorted list in the Makefile for
easier
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme-image-config into
charm-k8s-wordpress:master.
Commit message:
Clarify in the the readme that you can use a private image
Requested reviews:
Canonical IS Reviewers (canonical-is-reviewers
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:better-import-warnings
into charm-k8s-wordpress:master.
Commit message:
Clean up how we're using noqa E402 by using it on the line causing the later
warnings
Requested reviews:
Wordpress Charmers
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383718
--
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383718
--
Review: Approve
LGTM, although I don't think the comment is so useful
Diff comments:
> diff --git a/files/plugin_handler.py b/files/plugin_handler.py
> index 4feb8f2..eb9172a 100644
> --- a/files/plugin_handler.py
> +++ b/files/plugin_handler.py
> @@ -128,3 +134,20 @@ if __name__ == "__main__":
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into
charm-k8s-wordpress:master has been updated.
Description changed to:
Fix a typo in a comment, standardise comment capitalisation and use msg
variable for repeated messages
For more details, see:
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into
charm-k8s-wordpress:master has been updated.
Commit message changed to:
Fix a typo in a comment, standardise comment capitalisation and use msg
variable for repeated messages
For more details, see:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into
charm-k8s-wordpress:master.
Commit message:
Fix a typo in a comment, standardise comment capitalisation and use msg
variable for repeated messages
Requested reviews:
Wordpress Charmers
I'm not sure I understand why we're specifying 2.8.0 as the min-juju-version
since we're not making any charm changes here in terms of storage support. Or
am I just missing some context on something that was broken before 2.8.0 that
we weren't previously aware of?
--
Review: Approve
Ah, so the context I was missing is that this is required to tell juju it
doesn't need a persistent volume, which will be needed to ensure deployment on
k8s can happen without persistent storage.
--
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:configure-pod into
charm-k8s-wordpress:master.
Commit message:
Always set pod spec to avoid race condition if leadership changes between
configure_pods calls
Requested reviews:
Wordpress Charmers
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:return-immediately into
charm-k8s-wordpress:master.
Commit message:
Switch the 'return' pattern in is_vhost_ready to match wordpress_configured
Requested reviews:
Wordpress Charmers (wordpress-charmers
Review: Needs Fixing
This seems to be using a config option that doesn't exist yet (probe_regex).
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384516
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/384526
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384527
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Review: Needs Fixing
We should block if tls_secret_name isn't set.
Diff comments:
> diff --git a/src/charm.py b/src/charm.py
> index 46ad990..947dd6a 100755
> --- a/src/charm.py
> +++ b/src/charm.py
> @@ -156,6 +158,39 @@ class WordpressK8sCharm(CharmBase):
> else:
>
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384611
--
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384611
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:tox into
charm-k8s-wordpress:master.
Commit message:
Move flake8 hints from lint tox target to flake8 so editors will pick up on them
Requested reviews:
Canonical IS Reviewers (canonical-is-reviewers
Let's update it from /tmp/.tox to minimise possible collisions
Diff comments:
> diff --git a/Makefile b/Makefile
> index cf18918..a4853e1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,16 +1,24 @@
> -lint:
> +format:
> @echo "Normalising python layout with black."
> @tox -e black
>
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:wordpress_plugin_integration
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
LGTM, thx. We'll want to come back and figure out how to use a temporary
directory rather than hard coding a path in /tmp, but this is fine for now.
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/386800
Your team Wordpress Charmers
Review: Needs Fixing
Let's add a test for this, ideally for the make_pod_resources method as a whole.
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/386302
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing
Looks good, one small typo inline (akismit vs. akismet). I think we'll just
need to document how you run these tests (against an already deployed
environment and with some files in a folder that's exported as WORKSPACE env
dir?).
Diff comments:
> diff --git
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Commit message changed to:
WP_HTTP_BLOCK_EXTERNAL is blocking akismet from contacting the anti
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
LGTM
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/386370
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385482
--
Review: Approve
LGTM
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385482
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
The proposal to merge
~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
LGTM
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/385089
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
into charm-k8s-wordpress:master.
Commit message:
Add an action to retrieve initial password
Requested reviews:
Canonical IS Reviewers (canonical-is-reviewers)
Wordpress Charmers
This action can now be run from any unit.
--
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395982
Your team Wordpress Charmers is requested to review the proposed merge of
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Work in progress
For more details, see:
There's actually a problem with this. We need to use leadership data (or a peer
relation) since StoredState is per unit.
--
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395982
Your team Wordpress Charmers is requested to review the proposed merge of
Some inline comments, and you have a test failure in test_is_config_valid.
Haven't tested yet, but will do so shortly.
Diff comments:
> diff --git a/src/charm.py b/src/charm.py
> index edade47..efe9026 100755
> --- a/src/charm.py
> +++ b/src/charm.py
> @@ -115,20 +117,20 @@ class
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:optional-tls into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Tom Haddon has proposed merging ~stub/charm-k8s-wordpress:mysql-relation into
charm-k8s-wordpress:master.
Commit message:
Implement a MySQL database relation
The database connection details from the relation will
override any provided in the charm configuration.
Requested reviews:
Wordpress
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
Looks great, thanks, and have tested locally.
--
https://code.launchpad.net/~stub/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395826
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list:
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:end-user into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Work in progress
For more details, see:
The proposal to merge ~stub/charm-k8s-wordpress:mysql-relation into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~stub/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395826
--
Your team Wordpress
The proposal to merge ~stub/charm-k8s-wordpress:mysql-relation into
charm-k8s-wordpress:master has been updated.
Status: Merged => Needs review
For more details, see:
https://code.launchpad.net/~stub/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395826
--
Your team Wordpress Charmers
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action
into charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:maintenance-status into
charm-k8s-wordpress:master.
Commit message:
Fix unit status to stay in 'active' once configured
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:focal-image into
charm-k8s-wordpress:master.
Commit message:
Fix docker entrypoint to work for bionic or focal
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:focal-image into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396179
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-not-tls into
charm-k8s-wordpress:master.
Commit message:
Don't force TLS on the admin site if don't have a tls_secret_name configured,
to avoid one step in local set up
Requested reviews:
Canonical
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-not-tls into
charm-k8s-wordpress:master has been updated.
Description changed to:
Don't force TLS on the admin site if we don't have a tls_secret_name
configured, to avoid one step in local set up
For more
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-not-tls into
charm-k8s-wordpress:master has been updated.
Commit message changed to:
Don't force TLS on the admin site if we don't have a tls_secret_name
configured, to avoid one step in local set up
For more
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/394385
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme into
charm-k8s-wordpress:master.
Commit message:
Update README to be more end-user focused, showing initial deployment steps up
front
Requested reviews:
Wordpress Charmers (wordpress-charmers
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-builder-tests into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/394940
--
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394793
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-builder-tests into
charm-k8s-wordpress:master.
Commit message:
Updates tests to pass since merging image-building branch
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:icon into
charm-k8s-wordpress:master.
Commit message:
Add icon
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394731
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
The proposal to merge ~tcuthbert/charm-k8s-wordpress:master into
charm-k8s-wordpress:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394731
--
Your team Wordpress
Tom Haddon has proposed merging
~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-version into
charm-k8s-wordpress:master.
Commit message:
Download a specific version rather than just 'latest' - this will make it more
obvious when to upgrade. Will also update OCI Recipe to if/once
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/393537
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
Two small comments inline, otherwise looks good.
Diff comments:
> diff --git a/requirements.txt b/requirements.txt
> index 888e37a..addda44 100644
> --- a/requirements.txt
> +++ b/requirements.txt
> @@ -1,2 +1,3 @@
> # Include python requirements here
> requests
> +ops
This should be before
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/393590
Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to :
1 - 100 of 146 matches
Mail list logo
