Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2019-12-02 Thread Tom Haddon
Two minor comments inline. Would be good to get @stub's feedback on it as well. Much of this looks like it's testable in a similar way to how we do for the content-cache charm (for example) - see ./tests/unit/test_content_cache.py for examples (we don't need full test coverage initially but it w

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:tox-lint-black into charm-k8s-wordpress:master

2019-12-04 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:tox-lint-black into charm-k8s-wordpress:master. Commit message: Switch to using tox defined black and lint targets to avoid needing local install Requested reviews: Wordpress Charmers (wordpress

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:tox-lint-black into charm-k8s-wordpress:master

2019-12-04 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:tox-lint-black into charm-k8s-wordpress:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+me

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2019-12-04 Thread Tom Haddon
Let's switch to using tox targets for lint Diff comments: > diff --git a/Makefile b/Makefile > index 6dc2159..3891e12 100644 > --- a/Makefile > +++ b/Makefile > @@ -2,5 +2,20 @@ lint: > black -l 120 -t py37 reactive/ > flake8 reactive/ Since you've got tox targets for this now, let's

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-13 Thread Tom Haddon
Some comments inline Diff comments: > diff --git a/Dockerfile b/Dockerfile > new file mode 100644 > index 000..38866f4 > --- /dev/null > +++ b/Dockerfile > @@ -0,0 +1,55 @@ > +FROM ubuntu:bionic > + > +RUN echo 'debconf debconf/frontend select Noninteractive' | > debconf-set-selections > + >

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-15 Thread Tom Haddon
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~barrypric

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-15 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377499 Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. -- Mailing list: https://

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/print-plugin-names:master into charm-k8s-wordpress:master

2020-01-15 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/print-plugin-names:master into charm-k8s-wordpress:master. Commit message: Print the names of plugins as we download them Requested reviews: Wordpress Charmers (wordpress-charmers) For more details, see: https

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/print-plugin-names:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-15 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/print-plugin-names:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: Print the names of plugins as we download them Requested reviews: Wordpress Charmers (wordpress

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-15 Thread Tom Haddon
One comment inline Diff comments: > diff --git a/fetcher.py b/fetcher.py > index 9f93073..eb6c0b5 100755 > --- a/fetcher.py > +++ b/fetcher.py > @@ -110,7 +110,7 @@ def get_themes(branch_themes): > current_branch = 0 > for branch_theme in branch_themes: > current_branch = curre

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-15 Thread Tom Haddon
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~barrypric

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-15 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377649 Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. -- Mailing list: https://

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:build-focal into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-20 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:build-focal into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: Separate out Makefile targets so we can more easily test focal builds, remove unused

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-21 Thread Tom Haddon
Review: Approve Approved with one comment about adding a comment Diff comments: > diff --git a/Dockerfile b/Dockerfile > index a6bed91..f667d10 100644 > --- a/Dockerfile > +++ b/Dockerfile > @@ -1,7 +1,11 @@ > FROM ubuntu:bionic > > -ARG http_proxy > -ARG https_proxy > +LABEL maintainer="word

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-29 Thread Tom Haddon
Two comments inline Diff comments: > diff --git a/Dockerfile b/Dockerfile > index d9d9d67..ae922d5 100644 > --- a/Dockerfile > +++ b/Dockerfile > @@ -8,21 +8,16 @@ ARG BUILD_DATE > > LABEL org.label-schema.build-date=$BUILD_DATE > > +ENV APACHE_CONFDIR=/etc/apache2 > +ENV APACHE_ENVVARS=/etc

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-29 Thread Tom Haddon
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~barrypric

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-29 Thread Tom Haddon
Review: Approve Based on discussions on IRC I'm approving this. I'd missed the fact we were still doing an autoremove, and it seems there's no functional difference to adding --no-install-recommends, so that must be being set in the docker images's apt preferences already. -- https://code.laun

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:focal into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-01-29 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:focal into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: Allow builds of the image on focal with a Makefile arg Requested reviews: Wordpress

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-01-30 Thread Tom Haddon
One comment inline about making wp_plugin_openid_team_map more human-readable Diff comments: > diff --git a/config.yaml b/config.yaml > index a622726..00638bd 100644 > --- a/config.yaml > +++ b/config.yaml > @@ -70,7 +70,18 @@ options: > type: string > description: Blog hostname >

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-01-30 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/378300 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to : wordpress-char

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-01-30 Thread Tom Haddon
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/378300 -

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-03-04 Thread Tom Haddon
Some inline comments. Diff comments: > diff --git a/Dockerfile b/Dockerfile > index 24b6b0b..7abcf33 100644 > --- a/Dockerfile > +++ b/Dockerfile > @@ -50,10 +50,22 @@ COPY --chown=www-data:www-data ./files/themes/ > /var/www/html/wp-content/themes/ > COPY ./files/wp-info.php /var/www/html/ >

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-03-06 Thread Tom Haddon
Some comments inline. I do think some kind of timeout for retrying wait_for_wordpress makes sense, even if it's something like an hour or two. Will ask for input from some others on this. Diff comments: > diff --git a/Dockerfile b/Dockerfile > index 24b6b0b..c866c98 100644 > --- a/Dockerfile >

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-03-10 Thread Tom Haddon
Review: Approve One minor comment, other than that looks good, thanks. Diff comments: > diff --git a/tests/unit/test_plugin_hander.py > b/tests/unit/test_plugin_hander.py > new file mode 100644 > index 000..82c0fec > --- /dev/null > +++ b/tests/unit/test_plugin_hander.py > @@ -0,0 +1,32 @@

[Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-03-23 Thread Tom Haddon
The proposal to merge ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~barrypric

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-03-26 Thread Tom Haddon
Some comments inline Diff comments: > diff --git a/reactive/wordpress.py b/src/charm.py > similarity index 53% > rename from reactive/wordpress.py > rename to src/charm.py > index 9a1b013..9d5be4d 100644 > --- a/reactive/wordpress.py > +++ b/src/charm.py > @@ -1,292 +1,308 @@ > +#!/usr/bin/env py

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-04-01 Thread Tom Haddon
Have added some comments Diff comments: > diff --git a/src/charm.py b/src/charm.py > new file mode 100755 > index 000..7505ed0 > --- /dev/null > +++ b/src/charm.py > @@ -0,0 +1,289 @@ > +#!/usr/bin/env python3 > + > +import io > +import re > +import subprocess > +import sys > +from pprint imp

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-04-03 Thread Tom Haddon
Tom Haddon has proposed merging ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:operator into charm-k8s-wordpress:master. Commit message: Convert to operator framework Requested reviews: Wordpress Charmers (wordpress-charmers) For more details, see: https://code.launchpad.net

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-04-03 Thread Tom Haddon
Some comments inline Diff comments: > diff --git a/src/charm.py b/src/charm.py > new file mode 100755 > index 000..cccf55f > --- /dev/null > +++ b/src/charm.py > @@ -0,0 +1,333 @@ > +#!/usr/bin/env python3 > + > +import re > +import secrets > +import subprocess > +import string > +import sys

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-04-06 Thread Tom Haddon
Review: Approve Can move "import logging" above the sys.path.append to avoid needing noqa for that entry, otherwise looks good for now, thanks! -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/381502 Your team Wordpress Charmers is subscribed to branch

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-04-08 Thread Tom Haddon
I had to run both of these commands to get things to work: git submodule update --recursive --init git submodule update --recursive --remote This left me with some git status in my working branch. Do we need to update the submodule reference? Diff comments: > diff --git a/tests/unit/test_char

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-04-08 Thread Tom Haddon
One additional note about import ordering Diff comments: > diff --git a/tests/unit/test_charm.py b/tests/unit/test_charm.py > new file mode 100644 > index 000..db859b6 > --- /dev/null > +++ b/tests/unit/test_charm.py > @@ -0,0 +1,57 @@ > +#!/usr/bin/env python3 > + > +import copy > +import un

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme-formatting into charm-k8s-wordpress:master

2020-04-09 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme-formatting into charm-k8s-wordpress:master. Commit message: Update formatting of README for better display on jaas.ai Requested reviews: Wordpress Charmers (wordpress-charmers) For more details

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-04-16 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/382364 Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. -- Mailing list: https://l

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-04-16 Thread Tom Haddon
The proposal to merge ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-04-17 Thread Tom Haddon
The proposal to merge ~tcuthbert/charm-k8s-wordpress:operator into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/382463 -- Your team Wordpress C

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-04-17 Thread Tom Haddon
Review: Approve LGTM -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/382463 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to : wordpress-charmers

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:pkg-ordering into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-04-23 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:pkg-ordering into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: Move docker package dependencies to an alpha sorted list in the Makefile for easier

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme-image-config into charm-k8s-wordpress:master

2020-04-23 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme-image-config into charm-k8s-wordpress:master. Commit message: Clarify in the the readme that you can use a private image Requested reviews: Canonical IS Reviewers (canonical-is-reviewers

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:docker-fixes into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-04-24 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:docker-fixes into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: Fix docker_deps apt install invocation Requested reviews: Wordpress Charmers

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:docker-fixes into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-04-24 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:docker-fixes into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. Commit message: No need to quite docker_deps in Dockerfile Requested reviews: Wordpress Charmers

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-04-24 Thread Tom Haddon
This will need a charm change as well, so leaving this for when barry is able to work on that. -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/382913 Your team Wordpress Charmers is requested to review the proposed merge of ~tcuthbert/charm-k8

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme-image-config into charm-k8s-wordpress:master

2020-04-24 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme-image-config into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:return-immediately into charm-k8s-wordpress:master

2020-05-01 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:return-immediately into charm-k8s-wordpress:master. Commit message: Switch the 'return' pattern in is_vhost_ready to match wordpress_configured Requested reviews: Wordpress Charmers (wordpres

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:configure-pod into charm-k8s-wordpress:master

2020-05-06 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:configure-pod into charm-k8s-wordpress:master. Commit message: Always set pod spec to avoid race condition if leadership changes between configure_pods calls Requested reviews: Wordpress Charmers

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into charm-k8s-wordpress:master

2020-05-11 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into charm-k8s-wordpress:master has been updated. Description changed to: Fix a typo in a comment, standardise comment capitalisation and use msg variable for repeated messages For more details, see: https:/

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into charm-k8s-wordpress:master

2020-05-11 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into charm-k8s-wordpress:master has been updated. Commit message changed to: Fix a typo in a comment, standardise comment capitalisation and use msg variable for repeated messages For more details, see: http

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into charm-k8s-wordpress:master

2020-05-11 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into charm-k8s-wordpress:master. Commit message: Fix a typo in a comment, standardise comment capitalisation and use msg variable for repeated messages Requested reviews: Wordpress Charmers

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-05-11 Thread Tom Haddon
Review: Approve LGTM, although I don't think the comment is so useful Diff comments: > diff --git a/files/plugin_handler.py b/files/plugin_handler.py > index 4feb8f2..eb9172a 100644 > --- a/files/plugin_handler.py > +++ b/files/plugin_handler.py > @@ -128,3 +134,20 @@ if __name__ == "__main__":

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:better-import-warnings into charm-k8s-wordpress:master

2020-05-12 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:better-import-warnings into charm-k8s-wordpress:master. Commit message: Clean up how we're using noqa E402 by using it on the line causing the later warnings Requested reviews: Wordpress Cha

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-14 Thread Tom Haddon
I'm not sure I understand why we're specifying 2.8.0 as the min-juju-version since we're not making any charm changes here in terms of storage support. Or am I just missing some context on something that was broken before 2.8.0 that we weren't previously aware of? -- https://code.launchpad.net/

Re: [Wordpress-charmers] [Merge] ~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-14 Thread Tom Haddon
Review: Approve Ah, so the context I was missing is that this is required to tell juju it doesn't need a persistent volume, which will be needed to ensure deployment on k8s can happen without persistent storage. -- https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/charm-k8s-wordpr

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into charm-k8s-wordpress:master

2020-05-18 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383718 --

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into charm-k8s-wordpress:master

2020-05-18 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:typo-fix into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/383718 --

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:operator into charm-k8s-wordpress:master

2020-05-26 Thread Tom Haddon
Review: Needs Fixing This seems to be using a config option that doesn't exist yet (probe_regex). -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384516 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list:

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-26 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384527 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to : wordpress-charm

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-05-26 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/384526 Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. -- Mailing list: https://l

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-27 Thread Tom Haddon
Review: Needs Fixing We should block if tls_secret_name isn't set. Diff comments: > diff --git a/src/charm.py b/src/charm.py > index 46ad990..947dd6a 100755 > --- a/src/charm.py > +++ b/src/charm.py > @@ -156,6 +158,39 @@ class WordpressK8sCharm(CharmBase): > else: > logger

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-27 Thread Tom Haddon
The proposal to merge ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384611 --

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-05-27 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/384611 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to : wordpress-charm

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-06-04 Thread Tom Haddon
The proposal to merge ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-06-04 Thread Tom Haddon
Review: Approve LGTM -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/385089 Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. -- Mailing list: https://launch

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-06-10 Thread Tom Haddon
The proposal to merge ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385482 --

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-06-10 Thread Tom Haddon
Review: Approve LGTM -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/385482 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to : wordpress-charmers@l

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-06-24 Thread Tom Haddon
Review: Needs Fixing Let's add a test for this, ideally for the make_pod_resources method as a whole. -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/386302 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing l

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-06-24 Thread Tom Haddon
Review: Approve One small suggestion inline, otherwise looks good. Diff comments: > diff --git a/tests/unit/test_charm.py b/tests/unit/test_charm.py > index 2ac93e0..614c718 100644 > --- a/tests/unit/test_charm.py > +++ b/tests/unit/test_charm.py > @@ -88,3 +88,41 @@ class TestWordpressK8sCharm(

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-06-25 Thread Tom Haddon
Review: Approve LGTM -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/386370 Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. -- Mailing list: https://launch

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-06-25 Thread Tom Haddon
The proposal to merge ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Commit message changed to: WP_HTTP_BLOCK_EXTERNAL is blocking akismet from contacting the anti spa

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-06-25 Thread Tom Haddon
The proposal to merge ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:integration into charm-k8s-wordpress:master

2020-06-29 Thread Tom Haddon
Looks good, one small typo inline (akismit vs. akismet). I think we'll just need to document how you run these tests (against an already deployed environment and with some files in a folder that's exported as WORKSPACE env dir?). Diff comments: > diff --git a/tests/integration/test_wordpress_p

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:wordpress_plugin_integration into charm-k8s-wordpress:master

2020-07-03 Thread Tom Haddon
Let's update it from /tmp/.tox to minimise possible collisions Diff comments: > diff --git a/Makefile b/Makefile > index cf18918..a4853e1 100644 > --- a/Makefile > +++ b/Makefile > @@ -1,16 +1,24 @@ > -lint: > +format: > @echo "Normalising python layout with black." > @tox -e black >

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:wordpress_plugin_integration into charm-k8s-wordpress:master

2020-07-03 Thread Tom Haddon
The proposal to merge ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:wordpress_plugin_integration into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordp

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress:wordpress_plugin_integration into charm-k8s-wordpress:master

2020-07-03 Thread Tom Haddon
Review: Approve LGTM, thx. We'll want to come back and figure out how to use a temporary directory rather than hard coding a path in /tmp, but this is fine for now. -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/386800 Your team Wordpress Charmers is

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:tox into charm-k8s-wordpress:master

2020-07-22 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:tox into charm-k8s-wordpress:master. Commit message: Move flake8 hints from lint tox target to flake8 so editors will pick up on them Requested reviews: Canonical IS Reviewers (canonical-is-reviewers

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:update_charm into charm-k8s-wordpress:master

2020-11-10 Thread Tom Haddon
Two small comments inline, otherwise looks good. Diff comments: > diff --git a/requirements.txt b/requirements.txt > index 888e37a..addda44 100644 > --- a/requirements.txt > +++ b/requirements.txt > @@ -1,2 +1,3 @@ > # Include python requirements here > requests > +ops This should be before re

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:update_charm into charm-k8s-wordpress:master

2020-11-10 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/393537 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to : wordpress-cha

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:update_charm into charm-k8s-wordpress:master

2020-11-11 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/393590 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to : wordpress-cha

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-11-20 Thread Tom Haddon
Review: Approve LGTM -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394229 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to : wordpress-charmers

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-11-20 Thread Tom Haddon
The proposal to merge ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394229 -- Your team Wordpress Cha

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

2020-11-24 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/394385 Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master. -- Mailing list: https://l

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-12-02 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394731 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to : wordpress-cha

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master

2020-12-02 Thread Tom Haddon
The proposal to merge ~tcuthbert/charm-k8s-wordpress:master into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394731 -- Your team Wordpress Cha

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:icon into charm-k8s-wordpress:master

2020-12-02 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:icon into charm-k8s-wordpress:master. Commit message: Add icon Requested reviews: Wordpress Charmers (wordpress-charmers) For more details, see: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:merge_stuff into charm-k8s-wordpress:master

2020-12-02 Thread Tom Haddon
Review: Approve LGTM, thx -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/394793 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordpress:master. -- Mailing list: https://launchpad.net/~wordpress-charmers Post to : wordpress-cha

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-builder-tests into charm-k8s-wordpress:master

2020-12-04 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-builder-tests into charm-k8s-wordpress:master. Commit message: Updates tests to pass since merging image-building branch Requested reviews: Wordpress Charmers (wordpress-charmers) For more details

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-builder-tests into charm-k8s-wordpress:master

2020-12-07 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-builder-tests into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme into charm-k8s-wordpress:master

2020-12-07 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme into charm-k8s-wordpress:master. Commit message: Update README to be more end-user focused, showing initial deployment steps up front Requested reviews: Wordpress Charmers (wordpress-charmers) For

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme into charm-k8s-wordpress:master

2020-12-07 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:readme into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/394940 -- Y

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-version into charm-k8s-wordpress:master

2020-12-17 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-version into charm-k8s-wordpress:master. Commit message: Download a specific version rather than just 'latest' - this will make it more obvious when to upgrade. Will also update OCI Recipe

Re: [Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-version into charm-k8s-wordpress:master

2021-01-04 Thread Tom Haddon
Thanks for the comments. I think those can be addressed in a separate MP so I'll merge this for now and address those separately. -- https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395494 Your team Wordpress Charmers is subscribed to branch charm-k8s-wordp

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-version into charm-k8s-wordpress:master

2021-01-04 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:image-version into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/39549

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into charm-k8s-wordpress:master

2021-01-08 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into charm-k8s-wordpress:master. Commit message: Switch to version 5.6 as the default image, make the deployment process easier by setting some config defaults Requested reviews: Wordpress

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into charm-k8s-wordpress:master

2021-01-08 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into charm-k8s-wordpress:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/39

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into charm-k8s-wordpress:master

2021-01-08 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into charm-k8s-wordpress:master. Commit message: Switch to version 5.6 as the default image, make the deployment process easier by setting some config defaults Requested reviews: Canonical IS

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into charm-k8s-wordpress:master

2021-01-08 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:five-six into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395944 --

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action into charm-k8s-wordpress:master

2021-01-08 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:admin-password-action into charm-k8s-wordpress:master. Commit message: Add an action to retrieve initial password Requested reviews: Wordpress Charmers (wordpress-charmers) Related bugs: Bug #1907063 in

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into charm-k8s-wordpress:master

2021-01-10 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into charm-k8s-wordpress:master. Commit message: Remove duplicated argument and label definition from Dockerfile Requested reviews: Wordpress Charmers (wordpress-charmers) For more

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into charm-k8s-wordpress:master

2021-01-11 Thread Tom Haddon
The proposal to merge ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:dockerfile-cleanup into charm-k8s-wordpress:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:end-user into charm-k8s-wordpress:master

2021-01-11 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:end-user into charm-k8s-wordpress:master. Commit message: Update docs to be more end-user focused, refer to discourse-based docs, and use correct casing of WordPress Requested reviews: Wordpress Charmers

[Wordpress-charmers] [Merge] ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:optional-tls into charm-k8s-wordpress:master

2021-01-11 Thread Tom Haddon
Tom Haddon has proposed merging ~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress:optional-tls into charm-k8s-wordpress:master. Commit message: Make tls_secret_name optional to avoid one step in local dev setup Requested reviews: Wordpress Charmers (wordpress-charmers) For more details

  1   2   >