Change successfully merged at revision baf77967b42ecd7a846463cb7405c12cc860a18d
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/383235
Your team Wordpress Charmers is subscribed to branch
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~barrypr
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.
Review: Approve
LGTM, although I don't think the comment is so useful
Diff comments:
> diff --git a/files/plugin_handler.py b/files/plugin_handler.py
> index 4feb8f2..eb9172a 100644
> --- a/files/plugin_handler.py
> +++ b/files/plugin_handler.py
> @@ -128,3 +134,20 @@ if __name__ == "__main__":
-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to : wordpress-charmers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~wordpress
Requested reviews:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/383235
--
Your team Wordpress Charmers is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git
of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to : wordpress-charmers@lists.launchpad.net
Unsubscribe : https
Change successfully merged at revision e1aedf5b4848c748e6731e5de3c42bdbc09fc2e7
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/380153
Your team Wordpress Charmers is subscribed to branch
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~barrypr
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.
Addressed all comments, pushing fixed code now.
Diff comments:
> diff --git a/.gitignore b/.gitignore
> index e0f7f96..d8aaacd 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,3 +1,6 @@
> files/plugins/
> files/themes/
> +.coverage
> .tox/
> +files/__pycache__/
> +tests/unit/__pycache__/
Review: Approve
One minor comment, other than that looks good, thanks.
Diff comments:
> diff --git a/tests/unit/test_plugin_hander.py
> b/tests/unit/test_plugin_hander.py
> new file mode 100644
> index 000..82c0fec
> --- /dev/null
> +++ b/tests/unit/test_plugin_hander.py
> @@ -0,0 +1,32 @@
://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/380153
Your team Wordpress Charmers is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s
;s:4:"team";s:19:"canonical-sysadmins";""",
> + """s:4:"role";s:13:"administrator";s:6:"server";s:1:"0";}""",
> +
> """i:2;O:8:"stdClass"
-editors";s:4:"role";s:6:"editor";s:6:"server";s:1:"0";}i:3;O:8:"stdClass":4:{s:2:"id";i:3;s:4:"team";s:24:"canonical-website-admins";s:4:"role";s:13:"administrator";s:6:"server";s:1:
1:"0";}i:3;O:8:"stdClass":4:{s:2:"id";i:3;s:4:"team";s:24:"canonical-website-admins";s:4:"role";s:13:"administrator";s:6:"server";s:1:"0";}i:4;O:8:"stdClass":4:{s:2:"id";i:4;s:4:&q
-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to : wordpress-charmers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~wordpress
:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/380153
--
Your team Wordpress Charmers is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git/wordpress
sleep(sleep_time)
> +else:
> +if response.status == 200:
> +success = True
> +else:
> + logging.info('Waiting for Wordpress to return HTTP 200 (got
> {})'.format(response.status))
> + sleep(
Change successfully merged at revision d926292f1df9ee1c686a69370a4c1bcede7421b6
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920
Your team Wordpress Charmers is subscribed to branch
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~barrypr
Review: Approve
Based on discussions on IRC I'm approving this. I'd missed the fact we were
still doing an autoremove, and it seems there's no functional difference to
adding --no-install-recommends, so that must be being set in the docker
images's apt preferences already.
--
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.
dir"; mkdir -p "$dir"; chown "$APACHE_RUN_USER:$APACHE_RUN_GROUP"
> "$dir"; chmod 777 "$dir"; done \
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920
Your team Wordpress Cha
/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
diff --git a/Dockerfile b/Dockerfile
index d9d9d67..ae922d5 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -8,21 +8,16 @@ ARG BUILD_DATE
LABEL org.label
Deploy confirmed working too. Ready for re-review, I think.
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920
Your team Wordpress Charmers is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s
of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to : wordpress-charmers@lists.launchpad.net
Unsubscribe : https
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.
pad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920
Your team Wordpress Charmers is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wo
-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to : wordpress-charmers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~wordpress
Confirmed working with a local (juju/microk8s) deploy.
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920
Your team Wordpress Charmers is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image
Charmers (wordpress-charmers)
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377920
--
Your team Wordpress Charmers is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image
/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to : wordpress-charmers@lists.launchpad.net
Unsubscribe : https://launchpad.net
is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to : wordpress-charmers
Change successfully merged at revision 625248ee904c67b6fcaa2640476d54d7088c5bc9
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377851
Your team Wordpress Charmers is subscribed to branch
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~barrypr
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.
Review: Approve
Approved with one comment about adding a comment
Diff comments:
> diff --git a/Dockerfile b/Dockerfile
> index a6bed91..f667d10 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -1,7 +1,11 @@
> FROM ubuntu:bionic
>
> -ARG http_proxy
> -ARG https_proxy
> +LABEL
of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to : wordpress-charmers@lists.launchpad.net
Unsubscribe : https
:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377851
--
Your team Wordpress Charmers is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~barrypr
Change successfully merged at revision 27fa70ac52af813fc0bd35a68a8ea2d2e49ff9bf
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377649
Your team Wordpress Charmers is subscribed to branch
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377649
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
with('lp:'):
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377649
Your team Wordpress Charmers is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers
-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to : wordpress-charmers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~wordpress
:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377649
--
Your team Wordpress Charmers is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Merged => Superseded
For more details, see:
https://code.launchpad.net/~barrypr
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~barrypr
:
Wordpress Charmers (wordpress-charmers)
For more details, see:
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377648
--
Your team Wordpress Charmers is requested to review the proposed merge of
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~barrypr
Change successfully merged at revision de3ad0c4a3b51b6750c1d06f28bd7f2fbc3899f8
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377499
Your team Wordpress Charmers is subscribed to branch
The proposal to merge
~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.
Review: Approve
LGTM, thx
--
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377499
Your team Wordpress Charmers is subscribed to branch
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list:
est
> prod-is-external.docker-registry.canonical.com/wordpress:latest
> + @docker push
> prod-is-external.docker-registry.canonical.com/wordpress:latest
> +
> +deps:
> + @echo "Checking dependencies are present"
> + which bzr || sudo apt-get install -y bzr
@docker push
> prod-is-external.docker-registry.canonical.com/wordpress:latest
> +
> +deps:
> + @echo "Checking dependencies are present"
> + which bzr || sudo apt-get install -y bzr
> + which git || sudo apt-get install -y git
My preference would be t
-k8s-wordpress/+git/wordpress-k8s-image-builder:master into
~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.
--
Mailing list: https://launchpad.net/~wordpress-charmers
Post to : wordpress-charmers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~wordpress
57 matches
Mail list logo
