Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:additional_hostnames into charm-k8s-wordpress:master

2021-01-13 Thread Tom Haddon
Added some comments inline. Diff comments: > diff --git a/src/charm.py b/src/charm.py > index f1a2252..5d9f4e9 100755 > --- a/src/charm.py > +++ b/src/charm.py > @@ -85,6 +86,10 @@ def gather_wordpress_secrets(): > return rv > > > +def split_additional_hostnames(hostnames): > +

Re: [Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:additional_hostnames into charm-k8s-wordpress:master

2021-01-13 Thread Canonical IS Mergebot
This merge proposal is being monitored by mergebot. Change the status to Approved to merge. -- https://code.launchpad.net/~tcuthbert/charm-k8s-wordpress/+git/charm-k8s-wordpress-1/+merge/395661 Your team Wordpress Charmers is requested to review the proposed merge of

[Wordpress-charmers] [Merge] ~tcuthbert/charm-k8s-wordpress:additional_hostnames into charm-k8s-wordpress:master

2021-01-13 Thread Thomas Cuthbert
Thomas Cuthbert has proposed merging ~tcuthbert/charm-k8s-wordpress:additional_hostnames into charm-k8s-wordpress:master. Commit message: Support sites with multiple hostnames ie fridge.u.c / ubuntu-news.org Requested reviews: Wordpress Charmers (wordpress-charmers) For more details, see: