Re: [wtp-dev] extending the jsp editor
I tried to update the grammar for jsp (not gsp) to work with jflex 1.4.3 and hit a bit of a wall. I documented everything I've done so far here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=296976 On Sun, Dec 6, 2009 at 4:44 PM, Nitin Dahyabhai nit...@us.ibm.com wrote: Andrew Eisenberg wrote: Well, I made some changes to the grammar and the skeleton file, and ran the tests. Unfortunately, the changes I made will not allow the new grammar to be compiled using the old version of jflex. Also, I have 8 tests failing. I can create a bug report and attach the new grammar file. I expected that they'd not be able to compile with both versions unmodified--it's the price we pay for not keeping within JFlex's APIs. Attaching the changed version to a bug would be most helpful, assuming you mean changes made to port the grammar forward, and not for its use with gsps. -- --- Nitin Dahyabhai Eclipse WTP Source Editing IBM Rational ___ wtp-dev mailing list wtp-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/wtp-dev ___ wtp-dev mailing list wtp-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/wtp-dev
Re: [wtp-dev] extending the jsp editor
Andrew Eisenberg wrote: Well, I made some changes to the grammar and the skeleton file, and ran the tests. Unfortunately, the changes I made will not allow the new grammar to be compiled using the old version of jflex. Also, I have 8 tests failing. I can create a bug report and attach the new grammar file. I expected that they'd not be able to compile with both versions unmodified--it's the price we pay for not keeping within JFlex's APIs. Attaching the changed version to a bug would be most helpful, assuming you mean changes made to port the grammar forward, and not for its use with gsps. -- --- Nitin Dahyabhai Eclipse WTP Source Editing IBM Rational ___ wtp-dev mailing list wtp-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/wtp-dev
Re: [wtp-dev] extending the jsp editor
Andrew, The archive of versions on SourceForge likely ends at 1.3.0 because 1.2.x predates its existence as a SourceForge project. We've not made it a priority to update that tokenizer's specification to be compatible with newer versions of JFlex, since as you saw it makes use of a number of internals specific to code generated with that version. A number of other tokenizers in WTP are properly API clean and can always be generated with the latest and greatest JFlex. A thorough Google search or a polite request on the jflex-users mailing list should yield an answer. My own investigations when it was first released showed the internals of code generated by 1.3 to be vastly different than 1.2.2's, but I'm told that 1.4's is actually pretty similar. Any interest in helping us update our files? Regards, --- Nitin Dahyabhai Eclipse WTP Source Editing IBM Rational ___ wtp-dev mailing list wtp-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/wtp-dev
Re: [wtp-dev] extending the jsp editor
Sure. That's something that I can help out with. I'll try a few things and see if I can get things working. Where are the test cases located? It looks like the naming scheme has changed. And so, the skeleton.sse file is out of date. On Fri, Dec 4, 2009 at 12:01 PM, Nitin Dahyabhai nit...@us.ibm.com wrote: Andrew, The archive of versions on SourceForge likely ends at 1.3.0 because 1.2.x predates its existence as a SourceForge project. We've not made it a priority to update that tokenizer's specification to be compatible with newer versions of JFlex, since as you saw it makes use of a number of internals specific to code generated with that version. A number of other tokenizers in WTP are properly API clean and can always be generated with the latest and greatest JFlex. A thorough Google search or a polite request on the jflex-users mailing list should yield an answer. My own investigations when it was first released showed the internals of code generated by 1.3 to be vastly different than 1.2.2's, but I'm told that 1.4's is actually pretty similar. Any interest in helping us update our files? Regards, --- Nitin Dahyabhai Eclipse WTP Source Editing IBM Rational ___ wtp-dev mailing list wtp-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/wtp-dev ___ wtp-dev mailing list wtp-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/wtp-dev
Re: [wtp-dev] extending the jsp editor
Andrew, They're in org.eclipse.jst.jsp.core.tests.source.JSPTokenizerTest and org.eclipse.jst.jsp.ui.tests.other.ScannerUnitTests in the org.eclipse.jst.jsp.core.tests and org.eclipse.jst.jsp.ui.tests plug-ins, respectively. :pserver:anonym...@dev.eclipse.org:/cvsroot/webtools - sourceediting/tests/org.eclipse.jst.jsp.core.tests - sourceediting/tests/org.eclipse.jst.jsp.ui.tests The testBlock* methods of org.eclipse.jst.jsp.ui.tests.other.ScannerUnitTests are the most likely to break, as they test the functionality that accesses the tokenizers' internal character buffer. Thanks, --- Nitin Dahyabhai Eclipse WTP Source Editing IBM Rational ___ wtp-dev mailing list wtp-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/wtp-dev
Re: [wtp-dev] extending the jsp editor
Well, I made some changes to the grammar and the skeleton file, and ran the tests. Unfortunately, the changes I made will not allow the new grammar to be compiled using the old version of jflex. Also, I have 8 tests failing. I can create a bug report and attach the new grammar file. On Fri, Dec 4, 2009 at 2:04 PM, Nitin Dahyabhai nit...@us.ibm.com wrote: Andrew, They're in org.eclipse.jst.jsp.core.tests.source.JSPTokenizerTest and org.eclipse.jst.jsp.ui.tests.other.ScannerUnitTests in the org.eclipse.jst.jsp.core.tests and org.eclipse.jst.jsp.ui.tests plug-ins, respectively. :pserver:anonym...@dev.eclipse.org:/cvsroot/webtools - sourceediting/tests/org.eclipse.jst.jsp.core.tests - sourceediting/tests/org.eclipse.jst.jsp.ui.tests The testBlock* methods of org.eclipse.jst.jsp.ui.tests.other.ScannerUnitTests are the most likely to break, as they test the functionality that accesses the tokenizers' internal character buffer. Thanks, --- Nitin Dahyabhai Eclipse WTP Source Editing IBM Rational ___ wtp-dev mailing list wtp-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/wtp-dev ___ wtp-dev mailing list wtp-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/wtp-dev
