Re: [x265] [PATCH] threadpool: fix warning: ‘int popCount(uint64_t)’ defined but not used [-Wunused-function]

2016-05-30 Thread Deepthi Nandakumar
Thanks for the patch, Praveen. Mateusz' earlier patch provides a more complete fix and has been pushed. On Mon, May 30, 2016 at 6:48 PM, Praveen Tiwari < prav...@multicorewareinc.com> wrote: > I remember some numa functionality requires minimum window 7, they are not > supported on previous

Re: [x265] [PATCH] threadpool: fix warning: ‘int popCount(uint64_t)’ defined but not used [-Wunused-function]

2016-05-30 Thread Praveen Tiwari
I remember some numa functionality requires minimum window 7, they are not supported on previous version of window OS. Regards, Praveen On Mon, May 30, 2016 at 6:43 PM, Mateusz wrote: > There is a serious bug in threadpool code that prevent working in Windows >

Re: [x265] [PATCH] threadpool: fix warning: ‘int popCount(uint64_t)’ defined but not used [-Wunused-function]

2016-05-30 Thread Mateusz
There is a serious bug in threadpool code that prevent working in Windows XP/Vista. VS 2015 error when compiling for 32-bit Windows XP: (ClCompile target) -> I:\vs\x265\source\common\threadpool.cpp(590): error C3861: 'GetNumaNodeProcessorMaskEx': identifier not found [I:\vs\x265\ma\