Re: [x265] [PATCH] do not use std;:list for the class AccessUnit

2013-09-19 Thread Deepthi Nandakumar
FrameEncoder and compressFrame needs to be refactored for mallocs and failures to be handled correctly. On Thu, Sep 19, 2013 at 1:31 PM, Gopu Govindaswamy g...@multicorewareinc.com wrote: # HG changeset patch # User Gopu Govindaswamy g...@multicorewareinc.com # Date 1379577682 -19800 #

Re: [x265] [PATCH 5 of 5] cli: report errors from registering signal handler

2013-09-19 Thread SF Markus Elfring
+cliopt.log(X265_LOG_ERROR, Unable to register CTRL+C handler, error %d\n, errno); How do you think about to retrieve a message text for the passed error code? Would you like to call the function strerror there (and similar source code places)?

Re: [x265] [PATCH] lookahead: fix crash for I frame cost estimation

2013-09-19 Thread Deepthi Nandakumar
Can you try sending this as a fresh patch to the mailing list? Does not apply cleanly to the parent node. On Thu, Sep 19, 2013 at 2:46 PM, Deepthi Devaki Akkoorath deepthidev...@multicorewareinc.com wrote: # HG changeset patch # User Deepthi Devaki deepthidev...@multicorewareinc.com # Date

Re: [x265] [PATCH] types: use stdint.h data types for UChar, UShort, UInt64, Pel, TCoeff

2013-09-19 Thread Derek Buitenhuis
On 9/19/2013 5:18 AM, Steve Borho wrote: +typedef uint8_t UChar; +typedef uint16_t UShort; +typedef unsigned int UInt; +typedef int64_t Int64; +typedef uint64_t UInt64; This seems quite wrong, since they're not necessarily analogous on all platforms... like short. Why not

Re: [x265] [PATCH 1 of 2] Always active sao-lcu-opt because we broken it after Frame Parallelism

2013-09-19 Thread Derek Buitenhuis
On 9/19/2013 10:16 AM, Min Chen wrote: +// Disabled because Frame Parallelism call processRowPost early, it is broken data. +// OPT(sao-lcu-opt, param-saoLcuBasedOptimization,required_argument, 0, 0: SAO picture-based optimization, 1: SAO LCU-based optimization ) ... Why not fix it

Re: [x265] [PATCH 2 of 2] Control SAO and Deblock independence

2013-09-19 Thread chen
I check code again, no more reduce checks the SAO split into three parts, one run before deblock and another after, if we disable ao-lcu-opt, we have to bypass all of SAO operators on row level, we process sao after frame finished. At 2013-09-19 20:05:11,Derek Buitenhuis

Re: [x265] [PATCH 1 of 2] Always active sao-lcu-opt because we broken it after Frame Parallelism

2013-09-19 Thread chen
my 2 reasons: 1. turn it on may not get improvement quality or bitrate, but we need disable other acceleration feature 2. Maintain a rarely used features to be increase the workload At 2013-09-19 20:02:07,Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 9/19/2013 10:16 AM, Min Chen wrote: