[x265] [PATCH] Add x265 API defination to api.cpp

# HG changeset patch # User Sagar Kotecha sa...@multicorewareinc.com # Date 1393318766 -19800 # Tue Feb 25 14:29:26 2014 +0530 # Node ID 504c2a959e5815cb3020033289137f64cb458aee # Parent a36a669d09e89332dd91817afdf139853ba3ad03 Add x265 API defination to api.cpp diff -r a36a669d09e8 -r

Re: [x265] [PATCH] Add x265 API defination to api.cpp

Ok, looks good except x265_ssim should not be extern, and should be a part of common.cpp and not api.cpp. On Tue, Feb 25, 2014 at 2:33 PM, sa...@multicorewareinc.com wrote: # HG changeset patch # User Sagar Kotecha sa...@multicorewareinc.com # Date 1393318766 -19800 # Tue Feb 25

[x265] [PATCH] Add x265 API defination to api.cpp

# HG changeset patch # User Sagar Kotecha sa...@multicorewareinc.com # Date 1393320320 -19800 # Tue Feb 25 14:55:20 2014 +0530 # Node ID 559ef195b954fa4d3c8bbc9bf8b7619991596c36 # Parent a36a669d09e89332dd91817afdf139853ba3ad03 Add x265 API defination to api.cpp diff -r a36a669d09e8 -r

Re: [x265] [PATCH] Add x265 API defination to api.cpp

Sent new patch With Regards, Sagar On Tue, Feb 25, 2014 at 2:37 PM, Deepthi Nandakumar deep...@multicorewareinc.com wrote: Ok, looks good except x265_ssim should not be extern, and should be a part of common.cpp and not api.cpp. On Tue, Feb 25, 2014 at 2:33 PM, sa...@multicorewareinc.com

Re: [x265] [PATCH] Add x265 API defination to api.cpp

On Tue, Feb 25, 2014 at 3:25 AM, sa...@multicorewareinc.com wrote: # HG changeset patch # User Sagar Kotecha sa...@multicorewareinc.com # Date 1393320320 -19800 # Tue Feb 25 14:55:20 2014 +0530 # Node ID 559ef195b954fa4d3c8bbc9bf8b7619991596c36 # Parent

Re: [x265] [PATCH] Add x265 API defination to api.cpp

On Tue, Feb 25, 2014 at 3:07 AM, Deepthi Nandakumar deep...@multicorewareinc.com wrote: Ok, looks good except x265_ssim should not be extern, and should be a part of common.cpp and not api.cpp. So long as x265_ssim() is declared in x265.h, its implementation must be defined extern C. if the