[x265] [PATCH] framefilter: remove heap corruption in tld

2014-07-02 Thread aarthi
# HG changeset patch # User Aarthi Thirumalai # Date 1404290172 -19800 # Wed Jul 02 14:06:12 2014 +0530 # Node ID 69d9bd3eb5bd015d2e0c90d51eec0d7f8a4747d0 # Parent a18972fd05b1d6242a881bef979b9e1ff17543d9 framefilter: remove heap corruption in tld diff -r a18972fd05b1 -r 69d9bd3eb5bd

Re: [x265] [PATCH] framefilter: remove heap corruption in tld

2014-07-02 Thread Aarthi Priya Thirumalai
sry, Thg client didnt sync the changes properly for the previous commit. here is the right one # HG changeset patch # User Aarthi Thirumalai # Date 1404290172 -19800 # Wed Jul 02 14:06:12 2014 +0530 # Node ID a5a439242bbf367f5d76356b841cfa1ee9e119e4 # Parent

Re: [x265] [PATCH] framefilter: remove heap corruption in tld

2014-07-02 Thread Deepthi Nandakumar
The framefilter structure needs ThreadLocalData m_tld, that has to be initialised, and then used if wpp is not enabled. Not sure what you're trying to do here? On Wed, Jul 2, 2014 at 2:20 PM, Aarthi Priya Thirumalai aar...@multicorewareinc.com wrote: sry, Thg client didnt sync the changes

Re: [x265] [PATCH] framefilter: remove heap corruption in tld

2014-07-02 Thread Aarthi Priya Thirumalai
Exactly that! make FrameEncoder::m_tld a public member for framefilter to access, use it in when Wpp is disabled. On Wed, Jul 2, 2014 at 2:25 PM, Deepthi Nandakumar deep...@multicorewareinc.com wrote: The framefilter structure needs ThreadLocalData m_tld, that has to be initialised, and

Re: [x265] [PATCH] framefilter: remove heap corruption in tld

2014-07-02 Thread Deepthi Nandakumar
Hmm, I'm wondering doesnt m_tld rightfully belong to Encoder? On Wed, Jul 2, 2014 at 3:39 PM, Aarthi Priya Thirumalai aar...@multicorewareinc.com wrote: Exactly that! make FrameEncoder::m_tld a public member for framefilter to access, use it in when Wpp is disabled. On Wed, Jul 2, 2014

Re: [x265] [PATCH] framefilter: remove heap corruption in tld

2014-07-02 Thread Aarthi Priya Thirumalai
it has to be in scope of each Frame Encoder since frame can be are encoded in parallel with no wpp. On Wed, Jul 2, 2014 at 3:55 PM, Deepthi Nandakumar deep...@multicorewareinc.com wrote: Hmm, I'm wondering doesnt m_tld rightfully belong to Encoder? On Wed, Jul 2, 2014 at 3:39 PM, Aarthi

Re: [x265] [PATCH] framefilter: remove heap corruption in tld

2014-07-02 Thread chen
We can reuse [0] everytime, we alloc at least 1 TLD in Encoder::create() At 2014-07-02 18:09:51,Aarthi Priya Thirumalai aar...@multicorewareinc.com wrote: Exactly that! make FrameEncoder::m_tld a public member for framefilter to access, use it in when Wpp is disabled. On Wed, Jul 2,

Re: [x265] [PATCH] framefilter: remove heap corruption in tld

2014-07-02 Thread Steve Borho
On Wed, Jul 2, 2014 at 10:35 AM, chen chenm...@163.com wrote: We can reuse [0] everytime, we alloc at least 1 TLD in Encoder::create() Not if another frame encoder or frame filter can be using it at the same time; and definitely not if the Encoder's TLD array is static. This is why the

Re: [x265] [PATCH] framefilter: remove heap corruption in tld

2014-07-02 Thread chen
At 2014-07-02 23:54:17,Steve Borho st...@borho.org wrote: On Wed, Jul 2, 2014 at 10:35 AM, chen chenm...@163.com wrote:  We can reuse [0] everytime, we alloc at least 1 TLD in Encoder::create() Not if another frame encoder or frame filter can be using it at the same time; and definitely not if