[x265] [PATCH] no-rdo: giving weightage to the cost of all CU's and neighbour CU's for early exit

2013-11-07 Thread sumalatha
# HG changeset patch # User Sumalatha Polureddy # Date 1383823751 -19800 # Node ID a54b30b16e83048a7a2ef5584e1e1c9682216075 # Parent 0a1b379be359cbcf76140ac392104c856a037c78 no-rdo: giving weightage to the cost of all CU's and neighbour CU's for early exit Early exit is done when CU cost at

Re: [x265] [PATCH] no-rdo: giving weightage to the cost of all CU's and neighbour CU's for early exit

2013-11-07 Thread Steve Borho
On Thu, Nov 7, 2013 at 5:29 AM, sumala...@multicorewareinc.com wrote: # HG changeset patch # User Sumalatha Polureddy # Date 1383823751 -19800 # Node ID a54b30b16e83048a7a2ef5584e1e1c9682216075 # Parent 0a1b379be359cbcf76140ac392104c856a037c78 no-rdo: giving weightage to the cost of all

Re: [x265] [PATCH] no-rdo: giving weightage to the cost of all CU's and neighbour CU's for early exit

2013-11-07 Thread Deepthi Nandakumar
I have a few questions. 1. Do we need so many local variables? 2. Why are we adding outTempCU-cost to totalCost and then comparing against outBestCU-cost? That doesnt make much sense to me. AFAIk, outTempCU does not contain any valid data - we should remove this. 3. Should we be adding

Re: [x265] [PATCH] no-rdo: giving weightage to the cost of all CU's and neighbour CU's for early exit

2013-11-07 Thread Sumalatha Polureddy
On Fri, Nov 8, 2013 at 8:03 AM, Deepthi Nandakumar deep...@multicorewareinc.com wrote: I have a few questions. 1. Do we need so many local variables? As Steve suggested, totalCostNeigh and totalCountNeigh can be added inside each if () and will try to remove costCU, costCUAbove ,