Re: [x265] [PATCH 1 of 3] Chroma QP Offset: increase chroma QP when psy-rd is enabled

2014-06-26 Thread Derek Buitenhuis
On 6/26/2014 6:35 AM, BugMaster wrote: That is separate --psy (--no-psy) option in x264 and not --psy-rd Yeah, that was my point. :) - Derek ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel

Re: [x265] [PATCH 1 of 3] Chroma QP Offset: increase chroma QP when psy-rd is enabled

2014-06-26 Thread Deepthi Nandakumar
Ok, we dont have a separate psy option.yet On Jun 26, 2014 6:00 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 6/26/2014 6:35 AM, BugMaster wrote: That is separate --psy (--no-psy) option in x264 and not --psy-rd Yeah, that was my point. :) - Derek

Re: [x265] [PATCH 1 of 3] Chroma QP Offset: increase chroma QP when psy-rd is enabled

2014-06-25 Thread Derek Buitenhuis
On 6/25/2014 1:22 AM, deep...@multicorewareinc.com wrote: +/* In 444, chroma gets twice as much resolution, so halve quality when psy-rd is enabled */ +if (p-internalCsp == X265_CSP_I444 p-psyRd) +{ +p-cbQpOffset += 6; +p-crQpOffset += 6; +} I dont really

Re: [x265] [PATCH 1 of 3] Chroma QP Offset: increase chroma QP when psy-rd is enabled

2014-06-25 Thread Deepthi Nandakumar
This is primarily a visual quality improvement/psy-rd hack. In 444, since chroma resolution is on par with luma, and our eyes arent very sensitive to chroma, we increase the chroma QP so that those bits can be used up in luma. On Wed, Jun 25, 2014 at 4:35 PM, Derek Buitenhuis

Re: [x265] [PATCH 1 of 3] Chroma QP Offset: increase chroma QP when psy-rd is enabled

2014-06-25 Thread Deepthi Nandakumar
In a sense, psy-rd encapsulates all those r-d algorithms/tweaks/hacks that improve visual quality but may hurt objective metrics like psnr/ssim. In 444, this qp hack is likely to hurt objective metrics, hence it's turned on only if psychovisual improvement is desired. On Jun 25, 2014 7:02 PM,

Re: [x265] [PATCH 1 of 3] Chroma QP Offset: increase chroma QP when psy-rd is enabled

2014-06-25 Thread Derek Buitenhuis
On 6/25/2014 3:45 PM, Deepthi Nandakumar wrote: In a sense, psy-rd encapsulates all those r-d algorithms/tweaks/hacks that improve visual quality but may hurt objective metrics like psnr/ssim. In 444, this qp hack is likely to hurt objective metrics, hence it's turned on only if psychovisual

Re: [x265] [PATCH 1 of 3] Chroma QP Offset: increase chroma QP when psy-rd is enabled

2014-06-25 Thread BugMaster
On Wed, 25 Jun 2014 23:18:48 +0530, Deepthi Nandakumar wrote: They are. encoder.c:x264_validate_parameters if( b_open i_csp = X264_CSP_I444 i_csp X264_CSP_BGR h-param.analyse.b_psy )     h-param.analyse.i_chroma_qp_offset += 6; On Wed, Jun 25, 2014 at 11:12 PM, Derek Buitenhuis

[x265] [PATCH 1 of 3] Chroma QP Offset: increase chroma QP when psy-rd is enabled

2014-06-24 Thread deepthi
# HG changeset patch # User Deepthi Nandakumar deep...@multicorewareinc.com # Date 1403605850 -19800 # Tue Jun 24 16:00:50 2014 +0530 # Node ID 812dc9f61549299e686e6e12c7c4770aad792eec # Parent 18f936182df50cc5126d1707cd7c2b5fef289ccb Chroma QP Offset: increase chroma QP when psy-rd is